From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2623CC83000 for ; Tue, 28 Apr 2020 20:29:36 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0125B20731 for ; Tue, 28 Apr 2020 20:29:36 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=verdurent-com.20150623.gappssmtp.com header.i=@verdurent-com.20150623.gappssmtp.com header.b="Z4mcO0+4" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726500AbgD1U3f (ORCPT ); Tue, 28 Apr 2020 16:29:35 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:34056 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-FAIL-OK-FAIL) by vger.kernel.org with ESMTP id S1726286AbgD1U3e (ORCPT ); Tue, 28 Apr 2020 16:29:34 -0400 Received: from mail-ua1-x943.google.com (mail-ua1-x943.google.com [IPv6:2607:f8b0:4864:20::943]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 080F9C03C1AB for ; Tue, 28 Apr 2020 13:29:32 -0700 (PDT) Received: by mail-ua1-x943.google.com with SMTP id f5so12901158ual.5 for ; Tue, 28 Apr 2020 13:29:32 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=verdurent-com.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Pkj7kKKcclLvASvEGyrCI/6i5twP0NxxYNk+RIVUFp8=; b=Z4mcO0+46Tgu18zZ1ILlmbNz2QscI6HGOLUt2jq9eozqAy5T/bsUTxE9llCisBgdq+ 5Q8HDvyffxiry0/gYfAQjrpVLASdlCL8cJWR9DtHuywPHkbpv5UlZ7yrx0huAeHh3ftC 4ppmcha4ZlkJHkdZntWl60jDD3kul+Qv5BesDKBCWQHLpYdPWOGZbK9Ck4YLgF+4xU2c d0smJ1hXHK4q7+TZ834uhiMqXPmGT0UvC8BiFmH9I+C3VwMeqV7fKbPcteAB4h4nFgNG 6bGKK1FofR25GczJ3bsbw+Ftw4WKY9bo2sNOtpPjsp6BLPQ1DoW/twAvS9ae2K1NG1TM zXdQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Pkj7kKKcclLvASvEGyrCI/6i5twP0NxxYNk+RIVUFp8=; b=fflVfOe5LaDvt+dSLLR9Vmq3XjkOmZVTy3qDGlToQC0ETzkl1BbFM20jF4zDN57ChI d1wXE4dM2MmFZZ/y5CkwGDp30IOuZNtAOBACev1VjHEaf5xKL1RQKMbcqEHJmaQ35gx8 8tDwVSj/IIKBa3rZP6p/T4Fv2qUxkVPtpT4EgHFnJmZjrno2VHLqbFxoiQPVhBe6kBrk gNRk9kNrJF5Qz9jDIC3lRsvljw2xjPkpxu9zfaQ5o70Hk8bTB/gevzzMVsKYqHGeS5hT ZnFjf/FSIxJ9ZpbGQhm3CfBT46YAGc7jz2BQdSnvb+2zj+DFtQYa8Sl+7BuYVL30tXGO /ztg== X-Gm-Message-State: AGi0PuYNuIwgz6wott3e/Cqr36RYrIyytJnmwq5Iy8J6HJ3N0NN1yhTa jUnpdg4R6DwQX6o3Bj+Fty+evZM9pp0bJqlxPLv8LA== X-Google-Smtp-Source: APiQypJRtqhFbG7Rpns7Xg65/400D7gj9RtZJmOOrneoEGGX2VN0LUGpUc52NK91FBqKp4r/OAxibEQH/VFYLqZScB4= X-Received: by 2002:a67:e9d9:: with SMTP id q25mr22043390vso.27.1588105771956; Tue, 28 Apr 2020 13:29:31 -0700 (PDT) MIME-Version: 1.0 References: <1585232945-23368-1-git-send-email-Anson.Huang@nxp.com> In-Reply-To: <1585232945-23368-1-git-send-email-Anson.Huang@nxp.com> From: Amit Kucheria Date: Wed, 29 Apr 2020 01:58:56 +0530 Message-ID: Subject: Re: [PATCH V2] thermal: imx: Add missing of_node_put() To: Anson Huang Cc: Zhang Rui , Daniel Lezcano , Shawn Guo , Sascha Hauer , kernel@pengutronix.de, Fabio Estevam , Linux PM list , lakml , LKML , dl-linux-imx Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Mar 26, 2020 at 8:06 PM Anson Huang wrote: > > After finishing using cpu node got from of_get_cpu_node(), of_node_put() > needs to be called. > > Signed-off-by: Anson Huang > --- > Changes since V1: > - improve the logic, no need to use got. > --- > drivers/thermal/imx_thermal.c | 7 ++++--- > 1 file changed, 4 insertions(+), 3 deletions(-) > > diff --git a/drivers/thermal/imx_thermal.c b/drivers/thermal/imx_thermal.c > index e761c9b..1b84ea6 100644 > --- a/drivers/thermal/imx_thermal.c > +++ b/drivers/thermal/imx_thermal.c > @@ -649,7 +649,7 @@ MODULE_DEVICE_TABLE(of, of_imx_thermal_match); > static int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data) > { > struct device_node *np; > - int ret; > + int ret = 0; > > data->policy = cpufreq_cpu_get(0); > if (!data->policy) { > @@ -664,11 +664,12 @@ static int imx_thermal_register_legacy_cooling(struct imx_thermal_data *data) > if (IS_ERR(data->cdev)) { > ret = PTR_ERR(data->cdev); > cpufreq_cpu_put(data->policy); You could move this policy release outside the if block too, no? > - return ret; > } > } > > - return 0; > + of_node_put(np); > + > + return ret; > } > > static void imx_thermal_unregister_legacy_cooling(struct imx_thermal_data *data) > -- > 2.7.4 >