From: Amit Kucheria <amit.kucheria@verdurent.com>
To: Daniel Lezcano <daniel.lezcano@linaro.org>
Cc: Zhang Rui <rui.zhang@intel.com>,
"open list:THERMAL" <linux-pm@vger.kernel.org>,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH V2 4/9] thermal: Move trip point structure definition to private header
Date: Sat, 4 Apr 2020 13:00:00 +0530 [thread overview]
Message-ID: <CAHLCerPBT0mVqJpw9P+HSkdcKfq=prFDwWfaTy+2dPs3p+E3=Q@mail.gmail.com> (raw)
In-Reply-To: <20200402142747.8307-4-daniel.lezcano@linaro.org>
On Thu, Apr 2, 2020 at 7:58 PM Daniel Lezcano <daniel.lezcano@linaro.org> wrote:
>
> The struct thermal_trip is only used by the thermal internals, it is
> pointless to export the definition in the global header.
>
> Move the structure to the thermal_core.h internal header.
>
> Signed-off-by: Daniel Lezcano <daniel.lezcano@linaro.org>
Reviewed-by: Amit Kucheria <amit.kucheria@linaro.org>
> ---
> drivers/thermal/thermal_core.h | 13 +++++++++++++
> include/linux/thermal.h | 15 ---------------
> 2 files changed, 13 insertions(+), 15 deletions(-)
>
> diff --git a/drivers/thermal/thermal_core.h b/drivers/thermal/thermal_core.h
> index f99551ce9838..d37de708c28a 100644
> --- a/drivers/thermal/thermal_core.h
> +++ b/drivers/thermal/thermal_core.h
> @@ -58,6 +58,19 @@ int power_actor_get_min_power(struct thermal_cooling_device *cdev,
> struct thermal_zone_device *tz, u32 *min_power);
> int power_actor_set_power(struct thermal_cooling_device *cdev,
> struct thermal_instance *ti, u32 power);
> +/**
> + * struct thermal_trip - representation of a point in temperature domain
> + * @np: pointer to struct device_node that this trip point was created from
> + * @temperature: temperature value in miliCelsius
> + * @hysteresis: relative hysteresis in miliCelsius
> + * @type: trip point type
> + */
> +struct thermal_trip {
> + struct device_node *np;
> + int temperature;
> + int hysteresis;
> + enum thermal_trip_type type;
> +};
>
> /*
> * This structure is used to describe the behavior of
> diff --git a/include/linux/thermal.h b/include/linux/thermal.h
> index e0279f7b43f4..7adbfe092281 100644
> --- a/include/linux/thermal.h
> +++ b/include/linux/thermal.h
> @@ -332,21 +332,6 @@ struct thermal_zone_of_device_ops {
> int (*set_trip_temp)(void *, int, int);
> };
>
> -/**
> - * struct thermal_trip - representation of a point in temperature domain
> - * @np: pointer to struct device_node that this trip point was created from
> - * @temperature: temperature value in miliCelsius
> - * @hysteresis: relative hysteresis in miliCelsius
> - * @type: trip point type
> - */
> -
> -struct thermal_trip {
> - struct device_node *np;
> - int temperature;
> - int hysteresis;
> - enum thermal_trip_type type;
> -};
> -
> /* Function declarations */
> #ifdef CONFIG_THERMAL_OF
> int thermal_zone_of_get_sensor_id(struct device_node *tz_np,
> --
> 2.17.1
>
next prev parent reply other threads:[~2020-04-04 7:30 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-02 14:27 [PATCH V2 1/9] thermal: Move default governor config option to the internal header Daniel Lezcano
2020-04-02 14:27 ` [PATCH V2 2/9] thermal: Move struct thermal_attr to the private header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 3/9] thermal: Move internal IPA functions Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 4/9] thermal: Move trip point structure definition to private header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria [this message]
2020-04-02 14:27 ` [PATCH V2 5/9] thermal: Move get_tz_trend to the internal header Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 6/9] thermal: Move get_thermal_instance " Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 7/9] thermal: Change IS_ENABLED to IFDEF in the header file Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 8/9] thermal: Remove stubs for thermal_zone_[un]bind_cooling_device Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-02 14:27 ` [PATCH V2 9/9] thermal: Remove thermal_zone_device_update() stub Daniel Lezcano
2020-04-04 7:30 ` Amit Kucheria
2020-04-04 7:30 ` [PATCH V2 1/9] thermal: Move default governor config option to the internal header Amit Kucheria
2020-04-12 8:35 ` Zhang Rui
2020-04-12 8:39 ` Daniel Lezcano
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHLCerPBT0mVqJpw9P+HSkdcKfq=prFDwWfaTy+2dPs3p+E3=Q@mail.gmail.com' \
--to=amit.kucheria@verdurent.com \
--cc=daniel.lezcano@linaro.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=rui.zhang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).