Re: [PATCH net-next v3 1/3] devlink: introduce framework for selftests

From: Vikas Gupta <vikas.gupta@broadcom.com>
To: Jakub Kicinski <kuba@kernel.org>
Cc: Jiri Pirko <jiri@nvidia.com>,
	netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
	"David S. Miller" <davem@davemloft.net>,
	dsahern@kernel.org, stephen@networkplumber.org,
	Eric Dumazet <edumazet@google.com>,
	pabeni@redhat.com, ast@kernel.org, leon@kernel.org,
	linux-doc@vger.kernel.org, corbet@lwn.net,
	Michael Chan <michael.chan@broadcom.com>,
	Andrew Gospodarek <andrew.gospodarek@broadcom.com>
Subject: Re: [PATCH net-next v3 1/3] devlink: introduce framework for selftests
Date: Tue, 19 Jul 2022 15:48:05 +0530	[thread overview]
Message-ID: <CAHLZf_uLHdz3hxz+ZtkoK_wGLpfPbh_cdkWOnmpRBX6TpNTDEg@mail.gmail.com> (raw)
In-Reply-To: <20220718203346.6aab5c4e@kernel.org>

[-- Attachment #1: Type: text/plain, Size: 670 bytes --]

Hi Jakub,

On Tue, Jul 19, 2022 at 9:03 AM Jakub Kicinski <kuba@kernel.org> wrote:
>
> On Mon, 18 Jul 2022 11:50:30 +0530 Vikas Gupta wrote:
> > +     for (i = 1; i < DEVLINK_SELFTEST_ATTR_MAX + 1; i++) {
> > +             u8 res;
> > +
> > +             if (nla_get_flag(tb[i])) {
> > +                     res = devlink->ops->selftest_run(devlink, i,
>
> Shouldn't we selftest_check() first to make sure the driver supports
> given test?
 Yes, I`ll add selftest_check() here rather than letting the driver return SKIP.

Thanks,
Vikas

>
> > +     [DEVLINK_ATTR_SELFTESTS_INFO] = { .type = NLA_NESTED },
>
>         ... = NLA_POLICY_NESTED(devlink_selftest_nl_policy),

[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4206 bytes --]