From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751909Ab2G0HHu (ORCPT ); Fri, 27 Jul 2012 03:07:50 -0400 Received: from mail-ob0-f174.google.com ([209.85.214.174]:51378 "EHLO mail-ob0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751565Ab2G0HHq (ORCPT ); Fri, 27 Jul 2012 03:07:46 -0400 MIME-Version: 1.0 In-Reply-To: <19738.1343299564@warthog.procyon.org.uk> References: <20120720215636.14854.41208.stgit@warthog.procyon.org.uk> <28702.1343135952@warthog.procyon.org.uk> <6193.1343211798@warthog.procyon.org.uk> <5901.1343244093@warthog.procyon.org.uk> <19738.1343299564@warthog.procyon.org.uk> From: Michael Kerrisk Date: Fri, 27 Jul 2012 09:07:25 +0200 X-Google-Sender-Auth: SxCbfd_kAFJpajROQCnTSTTaPIQ Message-ID: Subject: Re: [PATCH 00/13] UAPI header file split To: David Howells Cc: linux-arch@vger.kernel.org, linux-kernel@vger.kernel.org, arnd@arndb.de, tglx@linutronix.de, mingo@kernel.org, davej@redhat.com Content-Type: text/plain; charset=ISO-8859-1 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Jul 26, 2012 at 12:46 PM, David Howells wrote: > Michael Kerrisk wrote: > >> >> >> 3. HEADER COMMENTS NOT RETAINED IN KAPI FILES >> > >> > How about the attached changes? This is a delta to the disintegrate markers >> > diff I sent earlier. >> >> That looks about right to me. >> >> Acked-by: Michael Kerrisk > > Excellent, thanks. The question is where can I attach your ack? I'm not > going to simply tag these on the end as a new patch, but rather the changes > are included in the regenerated patches as I changed the scripts. > > So just the main set of scripted commits? Modulo the following statements: * The conceptual approach of your scripts makes sense to me. * I checked a significant, but far from complete, sample of the output files, and the results look correct. * My comparator scripts support the belief that no content is being lost in the resulting header files (once you've made the changes noted yesterday). then you could add my Acked-by: for the commits generated by the scripts. Acked-by: Michael Kerrisk Cheers, Michael -- Michael Kerrisk Linux man-pages maintainer; http://www.kernel.org/doc/man-pages/ Author of "The Linux Programming Interface", http://blog.man7.org/