From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIMWL_WL_HIGH,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3F136C2BA2B for ; Thu, 16 Apr 2020 04:47:34 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 18BFA20771 for ; Thu, 16 Apr 2020 04:47:34 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (1024-bit key) header.d=broadcom.com header.i=@broadcom.com header.b="DIr5D1Dw" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2404631AbgDPErb (ORCPT ); Thu, 16 Apr 2020 00:47:31 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59200 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2392038AbgDPErZ (ORCPT ); Thu, 16 Apr 2020 00:47:25 -0400 Received: from mail-lj1-x242.google.com (mail-lj1-x242.google.com [IPv6:2a00:1450:4864:20::242]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 37904C061A0F for ; Wed, 15 Apr 2020 21:47:25 -0700 (PDT) Received: by mail-lj1-x242.google.com with SMTP id z26so6271566ljz.11 for ; Wed, 15 Apr 2020 21:47:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=broadcom.com; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=+NDlWQ/mRFjSuqtZlOq7qrYq4K4xoJ9j5o51tM/JSCc=; b=DIr5D1DwGtuWE+AQZWvlocaxYUwNMz4kWu1civ3xfMmjTJptX9W/wDWceP+Ufd46OU TMM1FddMh61/VRQPGRl+VZiqTv/2mTZGXp6xwrFGC0wqsbdu1e/qXu7bPPJxzKwElWZ9 W+/w8sk81hHsOttLqrUDm1veCpPpttvFydWhg= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=+NDlWQ/mRFjSuqtZlOq7qrYq4K4xoJ9j5o51tM/JSCc=; b=a9C17VT8JMhGi5CiNd1p+3/JbKRHpb/X+m5qZbg5V+RRvX6dYy+DdUNJwg4ij1Eleq UNFa7enQVAGnvAXa5GT+4gnKNNX8tixGLAqSKMqScQ3i5XbAKZdWe5x+RGBT+2EiVIBR Cn207aN2Ebju8ra1iI/BxdRFwBific8ZIvptXJHaj5dLVHJv6OMH2A/6sI8G7zBMe23w WA2jEDj1DshKk5obSb7G+SGfG7TshP/DnessOZrw/FG2jZNQGIr7/D1On921RJlOOm3w u/TbrpQfA+mAem7PNjKSntKa2+nL/rUU/poVHdr+Q4iBhKLMSpWoti9+0fK/dPdH8xs0 G1iA== X-Gm-Message-State: AGi0PuY3PVTesrgQTFSrxbsW4XVnsDpf2P4UYLG2qc8PSXNIzUV6KZne EyjGb/njtEWpuoV8A+lmCBnq92luBJ8kUnKWbZ6d/w== X-Google-Smtp-Source: APiQypJA4A7ULXkeBweYmQbdUIOUieWPyVIxDPOys0Ry6iqrOvNMb71M3vq6dhM29YnR8rKQis03m1kXD1m5wzUHDRU= X-Received: by 2002:a2e:b4d0:: with SMTP id r16mr125354ljm.129.1587012443450; Wed, 15 Apr 2020 21:47:23 -0700 (PDT) MIME-Version: 1.0 References: <20200322182019.32493-1-rayagonda.kokatanur@broadcom.com> <20200415122945.GC910@ninjato> In-Reply-To: <20200415122945.GC910@ninjato> From: Rayagonda Kokatanur Date: Thu, 16 Apr 2020 10:17:11 +0530 Message-ID: Subject: Re: [PATCH v1 1/1] i2c: iproc: generate stop event for slave writes To: Wolfram Sang Cc: Ray Jui , Scott Branden , BCM Kernel Feedback , Lori Hikichi , Shreesha Rajashekar , Nishka Dasgupta , linux-i2c@vger.kernel.org, linux-arm-kernel@lists.infradead.org, Linux Kernel Mailing List Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Apr 15, 2020 at 5:59 PM Wolfram Sang wrote: > > On Sun, Mar 22, 2020 at 11:50:19PM +0530, Rayagonda Kokatanur wrote: > > When slave status is I2C_SLAVE_RX_END, generate I2C_SLAVE_STOP > > event to i2c_client. > > > > Fixes: c245d94ed106 ("i2c: iproc: Add multi byte read-write support for slave mode") > > Signed-off-by: Rayagonda Kokatanur > > Just to make sure: That means the HW has already detected a STOP > condition on the bus? Yes. > > > --- > > drivers/i2c/busses/i2c-bcm-iproc.c | 3 +++ > > 1 file changed, 3 insertions(+) > > > > diff --git a/drivers/i2c/busses/i2c-bcm-iproc.c b/drivers/i2c/busses/i2c-bcm-iproc.c > > index 30efb7913b2e..b58224b7ba79 100644 > > --- a/drivers/i2c/busses/i2c-bcm-iproc.c > > +++ b/drivers/i2c/busses/i2c-bcm-iproc.c > > @@ -360,6 +360,9 @@ static bool bcm_iproc_i2c_slave_isr(struct bcm_iproc_i2c_dev *iproc_i2c, > > value = (u8)((val >> S_RX_DATA_SHIFT) & S_RX_DATA_MASK); > > i2c_slave_event(iproc_i2c->slave, > > I2C_SLAVE_WRITE_RECEIVED, &value); > > + if (rx_status == I2C_SLAVE_RX_END) > > + i2c_slave_event(iproc_i2c->slave, > > + I2C_SLAVE_STOP, &value); > > } > > } else if (status & BIT(IS_S_TX_UNDERRUN_SHIFT)) { > > /* Master read other than start */ > > -- > > 2.17.1 > >