From: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
To: Rob Herring <robh+dt@kernel.org>
Cc: Frank Rowand <frowand.list@gmail.com>,
devicetree@vger.kernel.org,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"maintainer:BROADCOM BCM7XXX ARM ARCHITECTURE"
<bcm-kernel-feedback-list@broadcom.com>
Subject: Re: [PATCH v1 1/1] scripts: dtc: mask flags bit when check i2c addr
Date: Tue, 3 Mar 2020 10:26:17 +0530 [thread overview]
Message-ID: <CAHO=5PFuercRYBzupd-Zb3q8v3sQWGT2ySXodG9S5NVj7Ta+1Q@mail.gmail.com> (raw)
In-Reply-To: <CAL_JsqLXvVnVq0Mc1d0WMLNjURbHe9T3bKNb+5D6Nz3iyTK8GA@mail.gmail.com>
On Fri, Feb 28, 2020 at 7:20 PM Rob Herring <robh+dt@kernel.org> wrote:
>
> On Fri, Feb 28, 2020 at 2:48 AM Rayagonda Kokatanur
> <rayagonda.kokatanur@broadcom.com> wrote:
> >
> > Generally i2c addr should not be greater than 10-bit. The highest 2 bits
> > are used for I2C_TEN_BIT_ADDRESS and I2C_OWN_SLAVE_ADDRESS. Need to mask
> > these flags if check slave addr valid.
> >
> > Signed-off-by: Rayagonda Kokatanur <rayagonda.kokatanur@broadcom.com>
> > ---
> > scripts/dtc/Makefile | 2 +-
> > scripts/dtc/checks.c | 5 +++++
> > 2 files changed, 6 insertions(+), 1 deletion(-)
>
> dtc changes must be submitted against upstream dtc.
Please let me know link to clone the upstream dtc branch.
>
>
> > diff --git a/scripts/dtc/Makefile b/scripts/dtc/Makefile
> > index 3acbb410904c..c5e8d6a9e73c 100644
> > --- a/scripts/dtc/Makefile
> > +++ b/scripts/dtc/Makefile
> > @@ -9,7 +9,7 @@ dtc-objs := dtc.o flattree.o fstree.o data.o livetree.o treesource.o \
> > dtc-objs += dtc-lexer.lex.o dtc-parser.tab.o
> >
> > # Source files need to get at the userspace version of libfdt_env.h to compile
> > -HOST_EXTRACFLAGS := -I $(srctree)/$(src)/libfdt
> > +HOST_EXTRACFLAGS := -I $(srctree)/$(src)/libfdt -I$(srctree)/tools/include
> >
> > ifeq ($(shell pkg-config --exists yaml-0.1 2>/dev/null && echo yes),)
> > ifneq ($(CHECK_DTBS),)
> > diff --git a/scripts/dtc/checks.c b/scripts/dtc/checks.c
> > index 756f0fa9203f..17c9ed4137b5 100644
> > --- a/scripts/dtc/checks.c
> > +++ b/scripts/dtc/checks.c
> > @@ -3,6 +3,7 @@
> > * (C) Copyright David Gibson <dwg@au1.ibm.com>, IBM Corporation. 2007.
> > */
> >
> > +#include <linux/bits.h>
>
> Not a UAPI header not that that would be much better as dtc also builds on Mac.
>
> > #include "dtc.h"
> > #include "srcpos.h"
> >
> > @@ -17,6 +18,9 @@
> > #define TRACE(c, fmt, ...) do { } while (0)
> > #endif
> >
> > +#define I2C_TEN_BIT_ADDRESS BIT(31)
> > +#define I2C_OWN_SLAVE_ADDRESS BIT(30)
> > +
> > enum checkstatus {
> > UNCHECKED = 0,
> > PREREQ,
> > @@ -1048,6 +1052,7 @@ static void check_i2c_bus_reg(struct check *c, struct dt_info *dti, struct node
> >
> > for (len = prop->val.len; len > 0; len -= 4) {
> > reg = fdt32_to_cpu(*(cells++));
> > + reg &= ~(I2C_OWN_SLAVE_ADDRESS | I2C_TEN_BIT_ADDRESS);
>
> I'd just mask the top byte so we don't have to update on the next flag we add.
Do you mean something like this, shown below ?
reg &= 0xFFFF_FC000;
>
> Rob
next prev parent reply other threads:[~2020-03-03 4:56 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-28 8:48 [PATCH v1 1/1] scripts: dtc: mask flags bit when check i2c addr Rayagonda Kokatanur
2020-02-28 13:49 ` Rob Herring
2020-03-03 4:56 ` Rayagonda Kokatanur [this message]
2020-03-03 16:12 ` Frank Rowand
2020-03-04 5:59 ` Rayagonda Kokatanur
2020-03-24 5:41 ` Rayagonda Kokatanur
2020-03-25 19:07 ` Rob Herring
2020-03-26 4:34 ` Rayagonda Kokatanur
2020-03-26 5:53 ` Rayagonda Kokatanur
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHO=5PFuercRYBzupd-Zb3q8v3sQWGT2ySXodG9S5NVj7Ta+1Q@mail.gmail.com' \
--to=rayagonda.kokatanur@broadcom.com \
--cc=bcm-kernel-feedback-list@broadcom.com \
--cc=devicetree@vger.kernel.org \
--cc=frowand.list@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).