From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1751929AbcFUXGe (ORCPT <rfc822;w@1wt.eu>);
	Tue, 21 Jun 2016 19:06:34 -0400
Received: from mail-yw0-f169.google.com ([209.85.161.169]:36026 "EHLO
	mail-yw0-f169.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751516AbcFUXGc (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Tue, 21 Jun 2016 19:06:32 -0400
MIME-Version: 1.0
In-Reply-To: <20160621212238.GA5809@piout.net>
References: <1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com>
 <1466493770-11895-12-git-send-email-andrew.smirnov@gmail.com> <20160621212238.GA5809@piout.net>
From: Andrey Smirnov <andrew.smirnov@gmail.com>
Date: Tue, 21 Jun 2016 16:06:11 -0700
Message-ID: <CAHQ1cqE+Y9iQeZ=nqFdNEa15RyARn54RHG8pO6jh7CLRfqBUnQ@mail.gmail.com>
Subject: Re: [PATCH v2 13/17] RTC: ds1307: Report oscillator problems more intelligently
To: Alexandre Belloni <alexandre.belloni@free-electrons.com>
Cc: rtc-linux@googlegroups.com, Alessandro Zummo <a.zummo@towertech.it>,
        linux-kernel@vger.kernel.org, Chris Healy <cphealy@gmail.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jun 21, 2016 at 2:22 PM, Alexandre Belloni
<alexandre.belloni@free-electrons.com> wrote:
> On 21/06/2016 at 00:22:46 -0700, Andrey Smirnov wrote :
>> Report oscillator problems more intelligently, by printing more
>> information about what cause the issue and not yelling "SET TIME!" at
>> the user.
>>
>
> Well, the proper way of doing that is to ensure that -EINVAL is returned
> when reading the time until it has been set once instead of starting the
> oscillator and forgetting about that useful information.

Agreed, will change in v3.