From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S932401AbcHISrk (ORCPT ); Tue, 9 Aug 2016 14:47:40 -0400 Received: from mail-yb0-f195.google.com ([209.85.213.195]:35951 "EHLO mail-yb0-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S932207AbcHISrj (ORCPT ); Tue, 9 Aug 2016 14:47:39 -0400 MIME-Version: 1.0 In-Reply-To: <20160801140351.49119867@roar.ozlabs.ibm.com> References: <1469747238-17432-1-git-send-email-andrew.smirnov@gmail.com> <1469747238-17432-3-git-send-email-andrew.smirnov@gmail.com> <20160801140351.49119867@roar.ozlabs.ibm.com> From: Andrey Smirnov Date: Tue, 9 Aug 2016 11:47:37 -0700 Message-ID: Subject: Re: [PATCH v2 3/3] powerpc: Convert fsl_rstcr_restart to a reset handler To: Nicholas Piggin Cc: linuxppc-dev@lists.ozlabs.org, linux-kernel@vger.kernel.org, Scott Wood , Alessio Igor Bogani , Paul Mackerras , Daniel Axtens Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Sun, Jul 31, 2016 at 9:03 PM, Nicholas Piggin wrote: > On Thu, 28 Jul 2016 16:07:18 -0700 > Andrey Smirnov wrote: > >> Convert fsl_rstcr_restart into a function to be registered with >> register_reset_handler(). >> >> Signed-off-by: Andrey Smirnov >> --- >> >> Changes since v1: >> >> - fsl_rstcr_restart is registered as a reset handler in >> setup_rstcr, replacing per-board arch_initcall approach > > Bear in mind I don't know much about the embedded or platform code! > > The documentation for reset notifiers says that they are expected > to be registered from drivers, not arch code. That seems to only be > intended to mean that the standard ISA or platform reset would > normally be handled directly by the arch, whereas if you have an > arch specific driver for a reset hardware that just happens to live > under arch/, then fsl_rstcr_restart / mpc85xx_cds_restart would be > valid use of reset notifier. Yeah, IMHO there's quite a bit of code in sysdev/ which in ideal world would go into drivers/ and I think fsl_rstcr_restart is among it (similar example on MIPS is drivers/power/reset/brcmstb-reboot.c). > > So this change seems reasonable to me. One small question: > > >> +static int mpc85xx_cds_restart_register(void) >> +{ >> + static struct notifier_block restart_handler; >> + >> + restart_handler.notifier_call = mpc85xx_cds_restart; >> + restart_handler.priority = 192; > > Should there be a header with #define's for these priorities? I don't have any strong preference either way, I do however think that introducing such #define should go into a separate patch-set, since you'd probably want to propagate that change across all of the users of the API. Thanks, Andrey