From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Guenter Roeck <linux@roeck-us.net>
Cc: platform-driver-x86@vger.kernel.org,
Hans de Goede <hdegoede@redhat.com>,
Mark Gross <markgross@kernel.org>,
Jean Delvare <jdelvare@suse.com>,
linux-kernel <linux-kernel@vger.kernel.org>,
linux-hwmon@vger.kernel.org
Subject: Re: [PATCH] platform/x86: Add Steam Deck driver
Date: Sat, 12 Feb 2022 14:36:32 -0800 [thread overview]
Message-ID: <CAHQ1cqFcL0coZBY=A9gf1Y3dqaZrSU=y2tmJtivM3rk1ZDZdKw@mail.gmail.com> (raw)
In-Reply-To: <20220206053309.GA3140643@roeck-us.net>
On Sat, Feb 5, 2022 at 9:33 PM Guenter Roeck <linux@roeck-us.net> wrote:
>
> On Sat, Feb 05, 2022 at 06:20:23PM -0800, Andrey Smirnov wrote:
> > Add a driver exposing various bits and pieces of functionality
> > provided by Steam Deck specific VLV0100 device presented by EC
> > firmware. This includes but not limited to:
> >
> > - CPU/device's fan control
> > - Read-only access to DDIC registers
> > - Battery tempreature measurements
> > - Various display related control knobs
> > - USB Type-C connector event notification
> >
> > Cc: Hans de Goede <hdegoede@redhat.com>
> > Cc: Mark Gross <markgross@kernel.org>
> > Cc: Jean Delvare <jdelvare@suse.com>
> > Cc: Guenter Roeck <linux@roeck-us.net>
> > Cc: linux-kernel@vger.kernel.org (open list)
> > Cc: platform-driver-x86@vger.kernel.org
> > Cc: linux-hwmon@vger.kernel.org
> > Signed-off-by: Andrey Smirnov <andrew.smirnov@gmail.com>
> > ---
> >
> ...
> > +
> > +static umode_t
> > +steamdeck_is_visible(struct kobject *kobj, struct attribute *attr, int index)
> > +{
> > + return attr->mode;
> > +}
>
> This is unnecessary. Using attr->mode is the default operation if there
> is no is_visible function.
>
Thanks, will drop
next prev parent reply other threads:[~2022-02-12 22:36 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-06 2:20 [PATCH] platform/x86: Add Steam Deck driver Andrey Smirnov
2022-02-06 5:33 ` Guenter Roeck
2022-02-12 22:36 ` Andrey Smirnov [this message]
2022-02-06 15:19 ` Barnabás Pőcze
2022-02-12 23:30 ` Andrey Smirnov
2022-02-17 16:28 ` Hans de Goede
2022-02-06 17:51 ` Guenter Roeck
2022-02-12 23:34 ` Andrey Smirnov
2022-02-08 8:51 ` Greg KH
2022-02-12 23:37 ` Andrey Smirnov
2024-04-24 15:40 ` Clayton Craft
2022-02-17 16:26 ` Hans de Goede
2022-02-17 16:41 ` Hans de Goede
2022-02-19 21:08 ` Andrey Smirnov
2022-02-22 17:17 ` Hans de Goede
2022-02-17 16:35 ` Hans de Goede
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHQ1cqFcL0coZBY=A9gf1Y3dqaZrSU=y2tmJtivM3rk1ZDZdKw@mail.gmail.com' \
--to=andrew.smirnov@gmail.com \
--cc=hdegoede@redhat.com \
--cc=jdelvare@suse.com \
--cc=linux-hwmon@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@roeck-us.net \
--cc=markgross@kernel.org \
--cc=platform-driver-x86@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).