From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1751608AbcFUXtY (ORCPT ); Tue, 21 Jun 2016 19:49:24 -0400 Received: from mail-yw0-f171.google.com ([209.85.161.171]:33014 "EHLO mail-yw0-f171.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751347AbcFUXtX (ORCPT ); Tue, 21 Jun 2016 19:49:23 -0400 MIME-Version: 1.0 In-Reply-To: <20160621211712.GZ5809@piout.net> References: <1466493770-11895-1-git-send-email-andrew.smirnov@gmail.com> <20160621211712.GZ5809@piout.net> From: Andrey Smirnov Date: Tue, 21 Jun 2016 16:43:45 -0700 Message-ID: Subject: Re: [PATCH v2 02/17] RTC: ds1307: Disable square wave and timers as default To: Alexandre Belloni Cc: rtc-linux@googlegroups.com, Alessandro Zummo , linux-kernel@vger.kernel.org, Chris Healy Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jun 21, 2016 at 2:17 PM, Alexandre Belloni wrote: > On 21/06/2016 at 00:22:35 -0700, Andrey Smirnov wrote : >> Disable square wave and timers as default for DS1337/39/41 and >> DS3231. The rationale being that configuring a chip this way puts it >> into a known state with lower power consumption. While it is not very >> likely it is still possible that the code controlling RTCs that ran >> before this driver configured it to produce square wave and left it in >> such a state. >> > > The main issue being that if it has been configured that way (from the > bootloader for example). It is probably necessary for the board. There > may be users of that clock and this patch definitively breaks them. > The proper way of doing that is to add CCF support in the driver. See: > http://patchwork.ozlabs.org/patch/576201/ Implementing CCF support would still break users who rely on this particular behavior and they would still have to spend effort modifying their boards' device tree blob, so doing it the way you propose wouldn't really save those users from pain, it would just give them a way out. Unfortunately, I don't have a bandwidth to develop and test a feature that I don't have a use-case for, so I'll drop this patch from v3. Andrey