From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 41E40C3A5A7 for ; Wed, 4 Sep 2019 02:55:56 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 1323B2073F for ; Wed, 4 Sep 2019 02:55:56 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="NJoNsQJF" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728023AbfIDCzz (ORCPT ); Tue, 3 Sep 2019 22:55:55 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:36687 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727938AbfIDCzy (ORCPT ); Tue, 3 Sep 2019 22:55:54 -0400 Received: by mail-io1-f68.google.com with SMTP id b136so16748839iof.3; Tue, 03 Sep 2019 19:55:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=7KAHv1e63QK9hCRccVZugLye8tI2fhDiGMo9YSU17+k=; b=NJoNsQJFq84KLUFHY7UF2Gj+5i1DC2QrkkF3c2BI/l+/qelsHvd9IPqek+VF0v6pPH a+Ftiz0FoLR3DtdpAUhM3w7unJ9XkpR25N7C+ICbsrvwwA6IATHtu8OMHizph2d446rH I9N2zQgWCeHLsZ+T3GHmZwG1BzCSOqvxPGEDPCaxTZfXhZrX+CL0nAFVBZEpDtMX42ao t8GztDVo3ciyEUIsv/Jz5ZAhpkhOj1Exwj0GOhi1tySoOjIL9nZelQNS1dwcTBc1fzkK uW+XZ9N5gpT8Yry8dRcfiueZPc0Fqi4P1pCaJpqahIOqLSj1PtjSFRtS3ZV2oOhdHnk1 XBQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=7KAHv1e63QK9hCRccVZugLye8tI2fhDiGMo9YSU17+k=; b=ZfvSP2PYu4dYEfIZDxPZWUGsi47NiJNYuHkLB4kuzKYZqAqvh5xYagAc+QMOpfWM6G tCKqsw+N1zHxeHW1gxabzstTsvLwEotN9DntxLzdSDWOR92h4aCrPRx6uo3ALxkMvTG/ BFvQPM25q+DHM3s8TpVaNEK8q6XpMq3a5y6eDzUgziZHshQD1N6oP0kKxRjxXX3QOoXR r11EaVMfhfP8u+gNt1whZCBW9Sd+UoX+f++fpCJ5pG/0l+r0MmrDPymBxVKx/tmNse/6 Gt8yM98DjzDVBDbEe3kRdNr0Uazo9txWLeyNWCSQxXOz5b6ahZpKHmlGow81nY3lTsfp 8cJQ== X-Gm-Message-State: APjAAAXDhRtPrJKdnx4Hwh1tHToUASXYIp/PstnTvlprjQrOnTM4usH5 tVUeQroCTH6tIOazxC+pJuPe4Rx1Prnwiy2lR7c= X-Google-Smtp-Source: APXvYqy6DIeTsmKuzWXHD8W0nCChr0Alz2XaxQY19OH+kuUIfOdhhVc9KFZZeaXvRXwFufqw05eVIm+j3dVI5LKa8Ow= X-Received: by 2002:a5d:8502:: with SMTP id q2mr23512677ion.287.1567565753605; Tue, 03 Sep 2019 19:55:53 -0700 (PDT) MIME-Version: 1.0 References: <20190904023515.7107-1-andrew.smirnov@gmail.com> <20190904023515.7107-3-andrew.smirnov@gmail.com> In-Reply-To: From: Andrey Smirnov Date: Tue, 3 Sep 2019 19:55:42 -0700 Message-ID: Subject: Re: [PATCH 02/12] crypto: caam - use devres to unmap JR's registers To: Fabio Estevam Cc: "open list:HARDWARE RANDOM NUMBER GENERATOR CORE" , Chris Healy , Lucas Stach , =?UTF-8?Q?Horia_Geant=C4=83?= , Herbert Xu , Iuliana Prodan , linux-kernel Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Sep 3, 2019 at 7:43 PM Fabio Estevam wrote: > > Hi Andrey, > > On Tue, Sep 3, 2019 at 11:37 PM Andrey Smirnov = wrote: > > > > Use devres to unmap memory and drop explicit de-initialization > > code. > > > > NOTE: There's no corresponding unmapping code in caam_jr_remove which > > seems like a resource leak. > > > > Signed-off-by: Andrey Smirnov > > Cc: Chris Healy > > Cc: Lucas Stach > > Cc: Horia Geant=C4=83 > > Cc: Herbert Xu > > Cc: Iuliana Prodan > > Cc: linux-crypto@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/crypto/caam/jr.c | 13 +++++++++---- > > 1 file changed, 9 insertions(+), 4 deletions(-) > > > > diff --git a/drivers/crypto/caam/jr.c b/drivers/crypto/caam/jr.c > > index 417ad52615c6..7947d61a25cf 100644 > > --- a/drivers/crypto/caam/jr.c > > +++ b/drivers/crypto/caam/jr.c > > @@ -498,6 +498,7 @@ static int caam_jr_probe(struct platform_device *pd= ev) > > struct caam_job_ring __iomem *ctrl; > > struct caam_drv_private_jr *jrpriv; > > static int total_jobrs; > > + struct resource *r; > > int error; > > > > jrdev =3D &pdev->dev; > > @@ -513,9 +514,15 @@ static int caam_jr_probe(struct platform_device *p= dev) > > nprop =3D pdev->dev.of_node; > > /* Get configuration properties from device tree */ > > /* First, get register page */ > > - ctrl =3D of_iomap(nprop, 0); > > + r =3D platform_get_resource(pdev, IORESOURCE_MEM, 0); > > + if (!r) { > > + dev_err(jrdev, "platform_get_resource() failed\n"); > > + return -ENOMEM; > > + } > > + > > + ctrl =3D devm_ioremap(jrdev, r->start, resource_size(r)); > > It seems that using devm_platform_ioremap_resource() could make the > code even smaller. Unfortunately that function would do devm_ioremap_resource() under the hood and claim the ownership of the corresponding memory region. That's going to create a conflict with devm_of_iomap() used in "crypto: caam - use devres to unmap memory". Thanks, Andrey Smirnov