linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Andrey Smirnov <andrew.smirnov@gmail.com>
To: Fabio Estevam <festevam@gmail.com>
Cc: Shawn Guo <shawnguo@kernel.org>,
	Mark Rutland <mark.rutland@arm.com>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	Russell King <linux@armlinux.org.uk>,
	linux-kernel <linux-kernel@vger.kernel.org>,
	Rob Herring <robh+dt@kernel.org>,
	Sascha Hauer <kernel@pengutronix.de>,
	Fabio Estevam <fabio.estevam@nxp.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	Andrey Yurovsky <yurovsky@gmail.com>
Subject: Re: [PATCH 6/8] ARM: dts: imx7d-sdb: Add GPIO expander node
Date: Fri, 14 Apr 2017 08:25:48 -0700	[thread overview]
Message-ID: <CAHQ1cqHat=25=esVnBJCaFdXJqUCtvghD5UjnRNG0taaZF_Dag@mail.gmail.com> (raw)
In-Reply-To: <CAOMZO5A9u9bjbFa=0LQ_gnwFry4wm2HGD8xncThb3ta1TaZ1aw@mail.gmail.com>

On Thu, Apr 13, 2017 at 3:20 PM, Fabio Estevam <festevam@gmail.com> wrote:
> Hi Andrey,
>
> On Thu, Apr 13, 2017 at 10:32 AM, Andrey Smirnov
> <andrew.smirnov@gmail.com> wrote:
>
>> diff --git a/arch/arm/boot/dts/imx7d-sdb.dts b/arch/arm/boot/dts/imx7d-sdb.dts
>> index 5be01a1..e0ff276 100644
>> --- a/arch/arm/boot/dts/imx7d-sdb.dts
>> +++ b/arch/arm/boot/dts/imx7d-sdb.dts
>> @@ -52,6 +52,30 @@
>>                 reg = <0x80000000 0x80000000>;
>>         };
>>
>> +       spi4 {
>
> Here you use spi4 label...
>
>> +               compatible = "spi-gpio";
>> +               pinctrl-names = "default";
>> +               pinctrl-0 = <&pinctrl_spi1>;
>
> and here spi1, which is a bit confusing.
>

Agreed. It is confusing, will fix in v2.

>> +               status = "okay";
>> +               gpio-sck = <&gpio1 13 0>;
>> +               gpio-mosi = <&gpio1 9 0>;
>> +               cs-gpios = <&gpio1 12 0>;
>
> You could use GPIO_ACTIVE_HIGH flag for better readability.

Missed that, will fix in v2.

Thanks,
Andrey Smirnov

  reply	other threads:[~2017-04-14 15:25 UTC|newest]

Thread overview: 38+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2017-04-13 13:32 [PATCH 0/8] i.MX7 PCIe related device tree changes Andrey Smirnov
2017-04-13 13:32 ` [PATCH 1/8] Revert "ARM: dts: imx: Remove unexistant property" Andrey Smirnov
2017-04-13 13:32 ` [PATCH 2/8] ARM: dts: imx6: Specify 'anatop-enable-bit' where appropriate Andrey Smirnov
2017-04-13 13:32 ` [PATCH 3/8] ARM: dts: imx7s: Adjust anatop-enable-bit for 'reg_1p0d' Andrey Smirnov
2017-04-14  3:28   ` Shawn Guo
2017-04-14 14:33     ` Andrey Smirnov
2017-04-14 15:32   ` Dong Aisheng
2017-04-14 16:08     ` Andrey Smirnov
2017-04-13 13:32 ` [PATCH 4/8] ARM: dts: imx7s: Add node for GPC Andrey Smirnov
2017-04-13 19:03   ` Tyler Baker
2017-04-13 19:18     ` Fabio Estevam
2017-04-13 19:24       ` Tyler Baker
2017-04-13 19:55         ` Fabio Estevam
2017-04-13 20:13           ` Tyler Baker
2017-04-13 20:49             ` Fabio Estevam
2017-04-13 21:20               ` Andrey Smirnov
2017-04-13 21:35               ` Tyler Baker
2017-04-13 22:00                 ` Fabio Estevam
2017-04-13 21:19     ` Andrey Smirnov
2017-04-14  3:40   ` Shawn Guo
2017-04-14 15:19     ` Andrey Smirnov
2017-04-14 15:49       ` Dong Aisheng
2017-04-14 15:50         ` Andrey Smirnov
2017-04-13 13:32 ` [PATCH 5/8] ARM: dts: imx7s: Mark 'gpr' compatible with i.MX6 variant Andrey Smirnov
2017-04-14 15:56   ` Dong Aisheng
2017-04-14 16:30     ` Andrey Smirnov
2017-04-13 13:32 ` [PATCH 6/8] ARM: dts: imx7d-sdb: Add GPIO expander node Andrey Smirnov
2017-04-13 22:20   ` Fabio Estevam
2017-04-14 15:25     ` Andrey Smirnov [this message]
2017-04-14  3:47   ` Shawn Guo
2017-04-14 15:32     ` Andrey Smirnov
2017-04-14 16:00     ` Dong Aisheng
2017-04-13 13:32 ` [PATCH 7/8] ARM: dts: imx7d: Add node for PCIe controller Andrey Smirnov
2017-04-13 13:32 ` [PATCH 8/8] ARM: dts: imx7d-sdb: Enable PCIe peripheral Andrey Smirnov
2017-04-13 22:23   ` Fabio Estevam
2017-04-14  3:51   ` Shawn Guo
2017-04-14 15:45     ` Andrey Smirnov
2017-04-19 18:28 ` [PATCH 0/8] i.MX7 PCIe related device tree changes Tyler Baker

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHQ1cqHat=25=esVnBJCaFdXJqUCtvghD5UjnRNG0taaZF_Dag@mail.gmail.com' \
    --to=andrew.smirnov@gmail.com \
    --cc=devicetree@vger.kernel.org \
    --cc=fabio.estevam@nxp.com \
    --cc=festevam@gmail.com \
    --cc=kernel@pengutronix.de \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux@armlinux.org.uk \
    --cc=mark.rutland@arm.com \
    --cc=robh+dt@kernel.org \
    --cc=shawnguo@kernel.org \
    --cc=yurovsky@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).