From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.8 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SIGNED_OFF_BY, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 236F6C433FF for ; Wed, 31 Jul 2019 02:08:48 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id EBE6F206A2 for ; Wed, 31 Jul 2019 02:08:47 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="OeaMkMEs" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728129AbfGaCIr (ORCPT ); Tue, 30 Jul 2019 22:08:47 -0400 Received: from mail-io1-f68.google.com ([209.85.166.68]:43404 "EHLO mail-io1-f68.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1727300AbfGaCIq (ORCPT ); Tue, 30 Jul 2019 22:08:46 -0400 Received: by mail-io1-f68.google.com with SMTP id k20so132782644ios.10; Tue, 30 Jul 2019 19:08:46 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=DVKzHn3AiDgjL2TSg70JGryYa6JNjz51534bP69c4bo=; b=OeaMkMEsI0c0wtZUN+ae2Xn9kjhZ9iycRduxtwit3OvqnZ7+66zbECfBpwh9M5583+ 5YSqKnM4g351WOoqyE5uJr+IgWqaSgSRAOlY6wG13/K2Z9sAC1Tq3ODYJU9WYDuaJ+AP 4R0PzIW1WVCOiX/6mm2LjHL9uDhwWOAnheTwmJK9sQjRsK35ohqiccygKWdkMYRc9N6M Oqp34wdkpLCiQiFGICLfACjNLAD/h2tu3JAzUI07NigSijAHzYHj968PXbLngpTRd5BG 222nfDSZoFysH3qAdwjghAMXz6eeaDNJQYuehGiATicDemBv1HbnS/ykAEI9zSGLRjhl bjqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=DVKzHn3AiDgjL2TSg70JGryYa6JNjz51534bP69c4bo=; b=b5i//Az+jubxFqihP8RfUzrfAY7lrJOzwwf9itz8f7v2v4vQvU+NZlw+F9O2iDa8ud Bul4vMq4HMSJIv86mzfFgx8OSfuH41zG/PATDTlwtpZ4ep4aFbJGdZ1iPoffbdZcZ555 1EXzZGSADkeL/B+tKIR+jdkJtwoKt+j/cvOA/NmIlmrfQMGpfLd0Lvtqv/3ntjhZvivZ kcQDs6M97k4ukF4AqNceaASgtehIo0aeBcb6HcPgAFewIcf6pQBanUnXNpwbhZkTOg2y 2B2lX3gWZtwK3fL0A28JXoqv05xukWNieFonjHuiz/7h54uY4gZ59nFUZAYKAZC2uERI HxWw== X-Gm-Message-State: APjAAAUAArcIkeOZpC/Db8rQn5Ss+ifcLrLUQxmXQToc31BsFCP3DCPw 6FqPu9DGZZqb5hRcjDVR1Vr8OvfDd0KLcX6vFOY= X-Google-Smtp-Source: APXvYqwzQGth7oDH1CzaOi1cJBfASBrA30/A2aXvOg9sbA1+0FSzmDX0r4QTTBczMvKibOuiCz07Lx32jw0WvFyrjbM= X-Received: by 2002:a02:3b62:: with SMTP id i34mr126559340jaf.91.1564538925626; Tue, 30 Jul 2019 19:08:45 -0700 (PDT) MIME-Version: 1.0 References: <20190729195226.8862-1-andrew.smirnov@gmail.com> <20190729195226.8862-7-andrew.smirnov@gmail.com> <20190730155112.GA11837@kroah.com> In-Reply-To: <20190730155112.GA11837@kroah.com> From: Andrey Smirnov Date: Tue, 30 Jul 2019 19:08:34 -0700 Message-ID: Subject: Re: [PATCH 06/24] tty: serial: fsl_lpuart: Drop unnecessary sg_set_buf() call To: Greg Kroah-Hartman Cc: linux-serial@vger.kernel.org, Stefan Agner , Chris Healy , Cory Tusar , Lucas Stach , Jiri Slaby , dl-linux-imx , linux-kernel Content-Type: text/plain; charset="UTF-8" Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Jul 30, 2019 at 8:51 AM Greg Kroah-Hartman wrote: > > On Mon, Jul 29, 2019 at 12:52:08PM -0700, Andrey Smirnov wrote: > > Sg_init_one() will already call sg_set_buf(), so another explicit call > > right after it is unnecessary. Drop it. > > > > Signed-off-by: Andrey Smirnov > > Cc: Stefan Agner > > Cc: Bhuvanchandra DV > > Cc: Chris Healy > > Cc: Cory Tusar > > Cc: Lucas Stach > > Cc: Greg Kroah-Hartman > > Cc: Jiri Slaby > > Cc: linux-imx@nxp.com > > Cc: linux-serial@vger.kernel.org > > Cc: linux-kernel@vger.kernel.org > > --- > > drivers/tty/serial/fsl_lpuart.c | 1 - > > 1 file changed, 1 deletion(-) > > > > diff --git a/drivers/tty/serial/fsl_lpuart.c b/drivers/tty/serial/fsl_lpuart.c > > index 1b3f2a87e558..b600f591c8c2 100644 > > --- a/drivers/tty/serial/fsl_lpuart.c > > +++ b/drivers/tty/serial/fsl_lpuart.c > > @@ -1144,7 +1144,6 @@ static inline int lpuart_start_rx_dma(struct lpuart_port *sport) > > return -ENOMEM; > > > > sg_init_one(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); > > - sg_set_buf(&sport->rx_sgl, ring->buf, sport->rx_dma_rng_buf_len); > > nent = dma_map_sg(sport->port.dev, &sport->rx_sgl, 1, DMA_FROM_DEVICE); > > > > if (!nent) { > > This patch doesn't apply, is it already in the tree from someone else? > Yeah, looks like d9aa9ab4fe6b5c43b9ccb8a0811dadcfe40ea27f from your tty tree already covered this and I didn't have it in my tree. Will drop in v2. Thanks, Andrey Smirnov