From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id C5852C433F5 for ; Thu, 29 Sep 2022 19:34:35 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229716AbiI2Tee (ORCPT ); Thu, 29 Sep 2022 15:34:34 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47952 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229489AbiI2Teb (ORCPT ); Thu, 29 Sep 2022 15:34:31 -0400 Received: from mail-pj1-x1035.google.com (mail-pj1-x1035.google.com [IPv6:2607:f8b0:4864:20::1035]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id EE397139423 for ; Thu, 29 Sep 2022 12:34:30 -0700 (PDT) Received: by mail-pj1-x1035.google.com with SMTP id a5-20020a17090aa50500b002008eeb040eso5728601pjq.1 for ; Thu, 29 Sep 2022 12:34:30 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=/2GwsSTauJmjYfkTPtC2/6DT6emkrfoGXZJnJAKA7Q4=; b=foDx98KEnUwOdRff85G0E13/0WM6bs/iCCF+h2oxTRfhB7Y8cg42aTZN6jyESeGP+M SMXoHJxaNBf/dU4aqoq9XMjty27bRq6o4egGu9mjF8HT6/tzgOCXTI19ixxEOtuJv4Hq BZNIv06QP3dxoJFec7uxD64LNaJdcxUwDvWos= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=/2GwsSTauJmjYfkTPtC2/6DT6emkrfoGXZJnJAKA7Q4=; b=I2gn6QcuoXizkF/BbRshR0RV/maAJAO1Uv/za0XcRGYu0OM/OxudCjmrLQQ0UnE+EO kwrDHrbneNUKzHg5XsGsxzZusbPjBFHCjV+9JfrN3vyqnnuIl8WxMjA4wmu2e7FBST0q RU9GU90tf8fLBQGiBnr8EvlXu2g/UhtvQfZhD2wQoZMxWZOQFVfvNxvtGvNDRYeHbQCI j781+zmW1hZKmZH740fhsfhq1KbSXseXe/3rDLXVwVodaDgNp05uQUu5vG9b2sdz8hnI YjiiNeDeWhbm+YJ8JVa9PrJ6v9PFxdoVc/hu1a9GS5eFEpzfDRz008g9P9iv4WHfaESx j6uQ== X-Gm-Message-State: ACrzQf3eslM+aQ8ghSciaYBIXIYgvn1yVb4+iR5FPdLdAYCOkWbPrD93 6BNDyttH4TbMHAZcuQcQdYawx8WHCXGrmg== X-Google-Smtp-Source: AMsMyM4Kv6VOAUfEczk1ES3269E4yRoMMK7PlDJn5A0yVSQTzS0ST30779DLaEBCMLxeLit6iPRqqg== X-Received: by 2002:a17:90b:1b09:b0:208:4e74:7315 with SMTP id nu9-20020a17090b1b0900b002084e747315mr4128556pjb.103.1664480070313; Thu, 29 Sep 2022 12:34:30 -0700 (PDT) Received: from mail-pf1-f181.google.com (mail-pf1-f181.google.com. [209.85.210.181]) by smtp.gmail.com with ESMTPSA id nt9-20020a17090b248900b00200b12f2bf3sm118624pjb.51.2022.09.29.12.34.29 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 29 Sep 2022 12:34:30 -0700 (PDT) Received: by mail-pf1-f181.google.com with SMTP id d10so2312152pfh.6 for ; Thu, 29 Sep 2022 12:34:29 -0700 (PDT) X-Received: by 2002:a63:e16:0:b0:43b:d646:1bb7 with SMTP id d22-20020a630e16000000b0043bd6461bb7mr4327148pgl.53.1664479651010; Thu, 29 Sep 2022 12:27:31 -0700 (PDT) MIME-Version: 1.0 References: <20220929161917.2348231-1-rrangel@chromium.org> <20220929093200.v6.6.I8092e417a8152475d13d8d638eb4c5d8ea12ac7b@changeid> In-Reply-To: From: Raul Rangel Date: Thu, 29 Sep 2022 13:27:19 -0600 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: [PATCH v6 06/13] ACPI: resources: Add wake_capable parameter to acpi_dev_irq_flags To: "Rafael J. Wysocki" Cc: ACPI Devel Maling List , linux-input , Andy Shevchenko , Dmitry Torokhov , Hans de Goede , Mika Westerberg , Mario Limonciello , Tim Van Patten , Linus Walleij , "jingle.wu" , Dan Williams , Greg Kroah-Hartman , Jonathan Cameron , Len Brown , Nathan Chancellor , Nick Desaulniers , Terry Bowman , Tom Rix , Linux Kernel Mailing List , llvm@lists.linux.dev Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Sep 29, 2022 at 1:18 PM Rafael J. Wysocki wrote: > > On Thu, Sep 29, 2022 at 6:19 PM Raul E Rangel wrote: > > > > ACPI IRQ/Interrupt resources contain a bit that describes if the > > interrupt should wake the system. This change exposes that bit via > > a new IORESOURCE_IRQ_WAKECAPABLE flag. Drivers should check this flag > > I would call this IORESOURCE_IRQ_WAKE which is (a) simpler and easier > to read and (b) it sort of matches the "wakeirq" naming convention. It was Dmitry who originally suggested the name. I personally like the CAPABLE in the name. It makes it clear that it's capable of acting as a wake source, not to be confused with being enabled as a wake source. > > This is not a big deal if you insist on this name and for a good > reason, but just something I would do differently. > > The patch LGTM otherwise. >