From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753669Ab1L2Lts (ORCPT ); Thu, 29 Dec 2011 06:49:48 -0500 Received: from mail-ey0-f174.google.com ([209.85.215.174]:33552 "EHLO mail-ey0-f174.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752427Ab1L2Lto convert rfc822-to-8bit (ORCPT ); Thu, 29 Dec 2011 06:49:44 -0500 MIME-Version: 1.0 In-Reply-To: <4EFC52F0.1010709@t-online.de> References: <87ty4ss0z4.fsf@prochyra.name> <87ty4qdpna.fsf@prochyra.name> <20111224142028.GA32171@srcf.ucam.org> <4EFC3FA8.6020401@gmail.com> <4EFC52F0.1010709@t-online.de> Date: Thu, 29 Dec 2011 12:49:41 +0100 Message-ID: Subject: Re: [PATCH] Platform: samsung-laptop: add DMI information for Samsung N150 Plus From: Corentin Chary To: =?UTF-8?Q?Richard_Sch=C3=BCtz?= Cc: David Herrmann , Matthew Garrett , Andrzej Prochyra , platform-driver-x86@vger.kernel.org, linux-kernel@vger.kernel.org, "Zhang, Rui" Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8BIT Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Dec 29, 2011 at 12:45 PM, Richard Schütz wrote: > Am 29.12.2011 11:23, schrieb Corentin Chary: >> >> On 12/26/2011 11:22 AM, David Herrmann wrote: >> >>> On Mon, Dec 26, 2011 at 10:49 AM, Corentin Chary >>> wrote: >>>> >>>> On Sat, Dec 24, 2011 at 3:28 PM, David Herrmann >>>> wrote: >>>>> >>>>> On Sat, Dec 24, 2011 at 3:20 PM, Matthew >>>>> Garrett wrote: >>>>>> >>>>>> On Sat, Dec 24, 2011 at 02:12:57PM +0000, Andrzej Prochyra wrote: >>>>>>> >>>>>>> 'acpi_video0' not functional. Brightness can be controlled through >>>>>>> intel_backlight interface. There are 21 brightness levels and the >>>>>>> backlight can be turned off. >>>>>> >>>>>> >>>>>> If acpi_video0 doesn't work then we either need to work out why >>>>>> it's not >>>>>> working or make it vanish completely, so this patch isn't the correct >>>>>> approach. >>>>> >>>>> >>>>> Just to make clear, intel_backlight isn't working properly either. If >>>>> my laptop boots with backlight at 50% then intel_backlight will only >>>>> work in the range 0%-50% on my machine. If I use the samsung module to >>>>> set it to 100% then intel_backlight works correctly in the range >>>>> 0-100% until next reboot/suspend. > > > The same problem exists on my N145 Plus, too. > >>>>> So I'd recommend staying with the samsung module and disabling the >>>>> acpi_backlight entirely. The samsung module is the only backlight >>>>> control which works properly. >>>> >>>> >>>> Can I take a look at the DSDT to see how it's broken ? >>>> If it's really not functional, then it should be added to the >>>> blacklist in video_detect.c >>> >>> >>> Raw and disassembled dsdt is attached. >> >> >> Took a quick look but didn't find anything obvious. What happens exactly >> with acpi_video0 ? > > > Either Samsung's ACPI is totally broken [ACPI Warning: _BQC returned an > invalid level (20110623/video-472)] or they just don't support backlight > setting via ACPI at all. Therefore it's implemented in the SABI stuff. So > every device that needs SABI should be blacklisted in video_detect. And that's ? Because new laptops that use SABI seems to have a working acpi_video0. Currently, N1{4,5}* seems to be affected. -- Corentin Chary http://xf.iksaif.net