From: Todd Kjos <tkjos@google.com>
To: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
Cc: "Todd Kjos" <tkjos@android.com>,
"Arve Hjønnevåg" <arve@android.com>,
"open list:ANDROID DRIVERS" <devel@driverdev.osuosl.org>,
LKML <linux-kernel@vger.kernel.org>,
"Martijn Coenen" <maco@google.com>,
joel@joelfernandes.org,
"Android Kernel Team" <kernel-team@android.com>
Subject: Re: [PATCH v2 1/3] binder: fix sparse warnings on locking context
Date: Thu, 6 Dec 2018 08:37:41 -0800 [thread overview]
Message-ID: <CAHRSSExQzgVZdk09rxoow-OTbEq0fhgW+MgemToEPEN=TiwWLA@mail.gmail.com> (raw)
In-Reply-To: <20181206144408.GA24078@kroah.com>
On Thu, Dec 6, 2018 at 6:51 AM Greg KH <gregkh@linuxfoundation.org> wrote:
>
> On Wed, Dec 05, 2018 at 03:19:24PM -0800, Todd Kjos wrote:
> > Add __acquire()/__release() annnotations to fix warnings
> > in sparse context checking
> >
> > There is one case where the warning was due to a lack of
> > a "default:" case in a switch statement where a lock was
> > being released in each of the cases, so the default
> > case was added.
> >
> > Signed-off-by: Todd Kjos <tkjos@google.com>
> > ---
> > v2: no change, just resubmitted as #1 of 3 patches instead of by itself
>
> I've already applied this one, right?
No, not yet. I confused you by failing to add the "v2" in the subject
for the other two submitted with it that you applied this morning:
binder: filter out nodes when showing binder procs
binder: fix kerneldoc header for struct binder_buffer
Sorry about the confusion. This one still needs to be applied.
-Todd
>
> thanks,
>
> greg k-h
next prev parent reply other threads:[~2018-12-06 16:37 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2018-12-05 23:19 [PATCH v2 1/3] binder: fix sparse warnings on locking context Todd Kjos
2018-12-05 23:19 ` [PATCH 2/3] binder: fix kerneldoc header for struct binder_buffer Todd Kjos
2018-12-05 23:19 ` [PATCH 3/3] binder: filter out nodes when showing binder procs Todd Kjos
2018-12-06 14:44 ` [PATCH v2 1/3] binder: fix sparse warnings on locking context Greg KH
2018-12-06 16:37 ` Todd Kjos [this message]
2018-12-07 7:08 ` Greg Kroah-Hartman
2018-12-07 16:25 ` Todd Kjos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHRSSExQzgVZdk09rxoow-OTbEq0fhgW+MgemToEPEN=TiwWLA@mail.gmail.com' \
--to=tkjos@google.com \
--cc=arve@android.com \
--cc=devel@driverdev.osuosl.org \
--cc=gregkh@linuxfoundation.org \
--cc=joel@joelfernandes.org \
--cc=kernel-team@android.com \
--cc=linux-kernel@vger.kernel.org \
--cc=maco@google.com \
--cc=tkjos@android.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).