From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 32B86C4332F for ; Fri, 10 Nov 2023 18:33:53 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344967AbjKJSdx (ORCPT ); Fri, 10 Nov 2023 13:33:53 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:39424 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1345850AbjKJScq (ORCPT ); Fri, 10 Nov 2023 13:32:46 -0500 Received: from mail-qk1-x734.google.com (mail-qk1-x734.google.com [IPv6:2607:f8b0:4864:20::734]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id ED81672B1 for ; Thu, 9 Nov 2023 22:46:53 -0800 (PST) Received: by mail-qk1-x734.google.com with SMTP id af79cd13be357-77891f362cfso146045085a.1 for ; Thu, 09 Nov 2023 22:46:53 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1699598813; x=1700203613; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=eHJDdNWZZ4tIwkHZEN1gC9OcT0HCJr1RVppBH6tmUws=; b=d5gTjl5c9wk3h/lnULn5BMuG7FtGiYmygFMeQU/6nDh7PooX51nvSbbKsFutX2MG+0 47yJlisISclPMm+0tY/ukfiyM8TePKGixWcxPqSESJ65vZA55LXPyrd9urR2KIJ/flQD 2DE1ZDKtgyHOvm8rlVokhGG2YKEudLbkOOGMu06agNao6UPrOZh0Kgs8HlrF77GFvBL0 u1lCQp+AEWxulaQ5fsjxhYJ4vIzMpyq/i8bfAJZBJTmUDDfFDedWI9a3LJv4xcAX53qJ NioCHWc+Smf6FNYilnBrEGoc1sutpjOxn6xVqLhhFpffwWp0pvHffoQhnHhTWQA9oyen XXKw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1699598813; x=1700203613; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=eHJDdNWZZ4tIwkHZEN1gC9OcT0HCJr1RVppBH6tmUws=; b=HNKhg2qfpgC2R4PZ/g7NHzlj7jXOBaCyPWe6tT3LwrbGGXuigZcHzZ5MI3jZ6aDzUW q8Icwwv7/dQVojOz0CLKeLNWCMQugOKxB9xxSofPf4TfLh7px7QRCPNVgx9KAGVJZ07B knZddfozVDymwgdr3bu7mR8VYlK/cB3X2hbHfYIo716+RVF44n4TM54T3Aeb46htZRMa je+8M6LmVAlbuwlbGYSLuDEyzvE3SqZ8wkfYqVwE8sEibHd4/UVoq4K2s9qAj7y4XlVG 50e9zOVgX5T1p0sT5Jjqcsrd1uchFv/ENdF5KL04QOGuk0JMDWjgvPhipfwbYfQxnG+m E7dg== X-Gm-Message-State: AOJu0YweJf5HN++4K62MW1j1EQT3TuE45nDnY/jX6futpMs152YtnyRu TYy/hjRuhaGhURd5JsQo37QhgpCkGbUtSIBFfv195eWEhG3d2JqiE7Q= X-Google-Smtp-Source: AGHT+IHV8+0MFbC/VQpqHkvElGy/RL/z/ISeA+lbF9gB7A+2xFrkzHZehvrtNrke+02jjGbQaJXjvKRk/eDFLYB8QzU= X-Received: by 2002:a05:6102:3d8b:b0:44d:38d6:5cb8 with SMTP id h11-20020a0561023d8b00b0044d38d65cb8mr631035vsv.10.1699589171185; Thu, 09 Nov 2023 20:06:11 -0800 (PST) MIME-Version: 1.0 References: <20231106024413.2801438-1-almasrymina@google.com> <20231106024413.2801438-9-almasrymina@google.com> In-Reply-To: From: Mina Almasry Date: Thu, 9 Nov 2023 20:06:00 -0800 Message-ID: Subject: Re: [RFC PATCH v3 08/12] net: support non paged skb frags To: Paolo Abeni Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, linaro-mm-sig@lists.linaro.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Jesper Dangaard Brouer , Ilias Apalodimas , Arnd Bergmann , David Ahern , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Shakeel Butt , Jeroen de Borst , Praveen Kaligineedi Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Nov 9, 2023 at 1:15=E2=80=AFAM Paolo Abeni wrot= e: > > On Sun, 2023-11-05 at 18:44 -0800, Mina Almasry wrote: > [...] > > @@ -3421,7 +3446,7 @@ static inline struct page *skb_frag_page(const sk= b_frag_t *frag) > > */ > > static inline void __skb_frag_ref(skb_frag_t *frag) > > { > > - get_page(skb_frag_page(frag)); > > + page_pool_page_get_many(frag->bv_page, 1); > > I guess the above needs #ifdef CONFIG_PAGE_POOL guards and explicit > skb_frag_is_page_pool_iov() check ? > It doesn't actually. page_pool_page_* helpers are compiled in regardless of CONFIG_PAGE_POOL, and handle both page_pool_iov* & page* just fine (the checking happens inside the function). You may yell at me that it's too confusing... I somewhat agree, but I'm unsure of what is a better name or location for the helpers. The helpers handle (page_pool_iov* || page*) gracefully, so they seem to belong in the page pool for me, but it is indeed surprising/confusing that these helpers are available even if !CONFIG_PAGE_POOL. > > Cheers, > > Paolo > > --=20 Thanks, Mina