From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 26442C4167B for ; Fri, 8 Dec 2023 19:31:22 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1574678AbjLHTbN (ORCPT ); Fri, 8 Dec 2023 14:31:13 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58540 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229572AbjLHTbK (ORCPT ); Fri, 8 Dec 2023 14:31:10 -0500 Received: from mail-ua1-x92c.google.com (mail-ua1-x92c.google.com [IPv6:2607:f8b0:4864:20::92c]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 5B01B1712 for ; Fri, 8 Dec 2023 11:31:16 -0800 (PST) Received: by mail-ua1-x92c.google.com with SMTP id a1e0cc1a2514c-7c82eb9e95aso480583241.3 for ; Fri, 08 Dec 2023 11:31:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20230601; t=1702063875; x=1702668675; darn=vger.kernel.org; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=kWu+J+wzMOcih150vf6YNmhjcZNaZMBMCrHoJTVq0Uw=; b=AA19aOJzqgtW3RV80AFQwVMChqnhyx3dotQVTb0hrBmAlbNUmsuBTJtMrljDDTaPE4 UT2XZXwwEhyL6RvaC5iWygV0PrrojOamdQDwSsldkfSAMM7VJCtSIzBuUePJhJzEMdpX CPGh4gECrlJoIIISE5H4oez9KZbbP2rZerJwxtlHukbw8x1DHD6xfCD40QWJNSF2TTZv jyd/PaV6H4EEWDsI8Bemrygg75E84QrYgetKO+iTPy9VQtZwScDXn3sfczLGri9aGHpp 7vil7CrYcYmsqEFV7IMvKlG6rg+3CTnia8RBmcwiGoSy+xuGXcA38kRCZHFSMQWuS23S tl7Q== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1702063875; x=1702668675; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=kWu+J+wzMOcih150vf6YNmhjcZNaZMBMCrHoJTVq0Uw=; b=KQY81VobONsz7tv0nkIHXplEemcueDS5es1vQenLE+BBhFeB1icHyeBbV5i70mN+a3 ReZR0g55B1x2AOq05LDFtag2jQskfNtV/oI8N+QR5y83qHlyll1eIGnxUvn+B04zrNyy F0Bo2sszhBJk9pvCQSG5u0WCVW+JiNMPuqyI/GuNqDWiCNZCckAob+vymZZ4s9gw19H8 8NcoVLck9CLxRaqd/e3tFNAhScMvnGrqk+wxF7fLOgYmMK3/AdfUY7Nhs8V/wd95eh3N U8Czff3ADQnO7giaqcEIMJzpi9vi/vVPk0bZAHuTVLUmI+u0onZ3PUJ2iPstrrzmnksP yduA== X-Gm-Message-State: AOJu0Yz3GZpwI4ClV1Llly/rc6xL8MS3BUOqzcq1lWJ3Dla/vPw+3TN1 urFnH/wqpf4wNkJmElVzbnQRlQjmlMsRIjaHtLQnoA== X-Google-Smtp-Source: AGHT+IEWy2ZoASGB97Xf4UzepNASdfhsiRufEtATUoKuaLdGqOq89E4y/cKAIuTMSGCSkffzh0Lc4oz7kiKBOoq4yro= X-Received: by 2002:a05:6102:3ec4:b0:464:40b2:e59f with SMTP id n4-20020a0561023ec400b0046440b2e59fmr628329vsv.32.1702063875124; Fri, 08 Dec 2023 11:31:15 -0800 (PST) MIME-Version: 1.0 References: <20231208005250.2910004-1-almasrymina@google.com> <3fea9ae9-e9e6-4ba5-812b-2775a6ed9e6a@kernel.org> In-Reply-To: <3fea9ae9-e9e6-4ba5-812b-2775a6ed9e6a@kernel.org> From: Mina Almasry Date: Fri, 8 Dec 2023 11:31:01 -0800 Message-ID: Subject: Re: [net-next v1 00/16] Device Memory TCP To: David Ahern Cc: Shailend Chand , netdev@vger.kernel.org, linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-arch@vger.kernel.org, linux-kselftest@vger.kernel.org, bpf@vger.kernel.org, linux-media@vger.kernel.org, dri-devel@lists.freedesktop.org, "David S. Miller" , Eric Dumazet , Jakub Kicinski , Paolo Abeni , Jonathan Corbet , Jeroen de Borst , Praveen Kaligineedi , Jesper Dangaard Brouer , Ilias Apalodimas , Arnd Bergmann , Willem de Bruijn , Shuah Khan , Sumit Semwal , =?UTF-8?Q?Christian_K=C3=B6nig?= , Yunsheng Lin , Harshitha Ramamurthy , Shakeel Butt Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, Dec 8, 2023 at 9:57=E2=80=AFAM David Ahern wro= te: > > On 12/7/23 5:52 PM, Mina Almasry wrote: > > Major changes in v1: > > -------------- > > > > 1. Implemented MVP queue API ndos to remove the userspace-visible > > driver reset. > > > > 2. Fixed issues in the napi_pp_put_page() devmem frag unref path. > > > > 3. Removed RFC tag. > > > > Many smaller addressed comments across all the patches (patches have > > individual change log). > > > > Full tree including the rest of the GVE driver changes: > > https://github.com/mina/linux/commits/tcpdevmem-v1 > > > > Still a lot of DEVMEM references (e.g., socket API). Any reason not to > move those to DMABUF? > In my mind the naming (maybe too silly/complicated, feel free to correct) i= s: The feature is devmem TCP because we really care about TCPing into device memory. So the uapi/feature name retains devmem. dmabuf is the abstraction for devmem that we use. In theory someone can come up with a driver that doesn't like dmabuf and uses something else instead, and the devmem TCP support can be extended to support that something else. Functions that handle specifically dmabuf and are not generic to support general devmem are named accordingly (netdev_alloc_dmabuf/netdev_free_dmabuf) page_pool_iov is a generic type to support generic non-paged memory, functions that are supposed to handle any generic non-paged memory and named accordingly (page_pool_iov_get_many). --=20 Thanks, Mina