linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Mina Almasry <almasrymina@google.com>
To: Mike Kravetz <mike.kravetz@oracle.com>
Cc: "Matthew Wilcox (Oracle)" <willy@infradead.org>,
	YueHaibing <yuehaibing@huawei.com>,
	Axel Rasmussen <axelrasmussen@google.com>,
	Peter Xu <peterx@redhat.com>,
	Andrew Morton <akpm@linux-foundation.org>,
	Linus Torvalds <torvalds@linux-foundation.org>,
	linux-mm@kvack.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] mm: Make copy_huge_page() always available
Date: Mon, 12 Jul 2021 12:32:44 -0700	[thread overview]
Message-ID: <CAHS8izP7Q8VX+kpzzEUML625aPVOJkUADFs-gnBXWF-QaeKKhA@mail.gmail.com> (raw)
In-Reply-To: <9877bef9-b2e8-6a8c-4d68-7df7f3fb71eb@oracle.com>

On Mon, Jul 12, 2021 at 10:52 AM Mike Kravetz <mike.kravetz@oracle.com> wrote:
>
> On 7/12/21 8:32 AM, Matthew Wilcox (Oracle) wrote:
> > Rewrite copy_huge_page() and move it into mm/util.c so it's always
> > available.  Fixes an exposure of uninitialised memory on configurations
> > with HUGETLB and UFFD enabled and MIGRATION disabled.
> >
> > Fixes: 8cc5fcbb5be8 ("mm, hugetlb: fix racy resv_huge_pages underflow on UFFDIO_COPY")
> > Signed-off-by: Matthew Wilcox (Oracle) <willy@infradead.org>

Reviewed-By: Mina Almasry <almasrymina@google.com>

> > ---
> >  include/linux/migrate.h |  5 -----
> >  include/linux/mm.h      |  1 +
> >  mm/migrate.c            | 48 -----------------------------------------
> >  mm/util.c               | 10 +++++++++
> >  4 files changed, 11 insertions(+), 53 deletions(-)
>
> Thanks Matthew,
>
> Reviewed-by: Mike Kravetz <mike.kravetz@oracle.com>
> --
> Mike Kravetz

  reply	other threads:[~2021-07-12 19:32 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-07-12 15:32 [PATCH] mm: Make copy_huge_page() always available Matthew Wilcox (Oracle)
2021-07-12 17:52 ` Mike Kravetz
2021-07-12 19:32   ` Mina Almasry [this message]
2021-07-14  2:12 ` Andrew Morton
2021-07-14  2:20   ` Matthew Wilcox
2021-07-14 16:09     ` Linus Torvalds

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHS8izP7Q8VX+kpzzEUML625aPVOJkUADFs-gnBXWF-QaeKKhA@mail.gmail.com \
    --to=almasrymina@google.com \
    --cc=akpm@linux-foundation.org \
    --cc=axelrasmussen@google.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-mm@kvack.org \
    --cc=mike.kravetz@oracle.com \
    --cc=peterx@redhat.com \
    --cc=torvalds@linux-foundation.org \
    --cc=willy@infradead.org \
    --cc=yuehaibing@huawei.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).