From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 18DA7C43219 for ; Wed, 10 Nov 2021 17:50:33 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0247E61002 for ; Wed, 10 Nov 2021 17:50:32 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232568AbhKJRxQ (ORCPT ); Wed, 10 Nov 2021 12:53:16 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:59932 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230380AbhKJRxO (ORCPT ); Wed, 10 Nov 2021 12:53:14 -0500 Received: from mail-io1-xd36.google.com (mail-io1-xd36.google.com [IPv6:2607:f8b0:4864:20::d36]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 589CBC061766 for ; Wed, 10 Nov 2021 09:50:26 -0800 (PST) Received: by mail-io1-xd36.google.com with SMTP id w22so3806652ioa.1 for ; Wed, 10 Nov 2021 09:50:26 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=0S9sZv9rv1MLrkq7aAvaZJLfChB0QbHa6Bap7OCVON4=; b=Mpj3q9y8P8tXTskEXoJ+jEkJNmYg08YiZzsMCwx006007UkWib0VzvWz+XRgkwol5g Cq2E/j2ydmsTRrr6KctSBpI480yI3FutqwVcqwb2VlKHUwJWTSsJTCzxJGnIs6kVN/3O DGBhPSDpOxGfegmMhpOX5LX4qoDI1mjiVhMW60IwBCuqrEqdpCvWOXNc2veK2u35aN08 9ckXcJZs87m5QlP77fFFqpf/4jYJaI9QF6U+YIzxX/8Yk9uT+ZKlfuBEgd4y9TQUghkw qaMwa1ayBoLvEKFMLOFsRyir02bszFEdJx/Mmy+VsMnvsU7c1SxsVicijg0LX8EzhIH2 MSxA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=0S9sZv9rv1MLrkq7aAvaZJLfChB0QbHa6Bap7OCVON4=; b=fVxZ5r7FXJsqSP+qUK5PznZv0ctZqChG/6zWrM2ittAXwNiJRq/RHW3E1/JaVIuK5k SxYdbXeE1y1w/NjUZYJCxjzLKWqGTasJxdXHgSVOutiLZt2S7cqwksCZ+w9vlplec9IG W6B4sO8ctFLpcCR4dS3tf0OoRsFozps4PnN0OvtBSJhYgqxRn9NK6wqDOT4Ptd1LA1/y xU9o2XaRkhDc0LeiMXIZQA1Vq2m/eYQVEtfKxw6TcwU5PcW7eHDhLqP+O3ewhuzBYGK9 NJ27Hqy/gpsQf9zabcCkA5P82/SCpZJ7sQbbsJ76AjqR9C59IDpXO1awAE1x5oiOPCAf EnPw== X-Gm-Message-State: AOAM533zwDuLncnxTkqJTkSuRf7Dq6nJvJ4ydysCFj4MSC1LAkPx8ElM 58ooY3jOe4V7WGrVGpbRgbG1dwSEm/cYkg02V87Nhg== X-Google-Smtp-Source: ABdhPJx8SVMZqY/M+G/wfHByt0Gdg7mcZQx8twUBaM2wGi8juiZIcAzzBUsezhqV/JnXuzMhcKYRZ7I6PzZJKf5g7kI= X-Received: by 2002:a02:c559:: with SMTP id g25mr489184jaj.123.1636566625557; Wed, 10 Nov 2021 09:50:25 -0800 (PST) MIME-Version: 1.0 References: <20211107235754.1395488-1-almasrymina@google.com> In-Reply-To: From: Mina Almasry Date: Wed, 10 Nov 2021 09:50:13 -0800 Message-ID: Subject: Re: [PATCH v4] mm: Add PM_HUGE_THP_MAPPING to /proc/pid/pagemap To: Peter Xu Cc: David Hildenbrand , Matthew Wilcox , "Paul E . McKenney" , Yu Zhao , Jonathan Corbet , Andrew Morton , Ivan Teterevkov , Florian Schmidt , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Nov 9, 2021 at 11:03 PM Peter Xu wrote: > > The ending "_MAPPING" seems redundant to me, how about just call it "PM_THP" or > "PM_HUGE" (as THP also means HUGE already)? > So I want to make it clear that the flag is set only when the page is PMD mappend and is a THP (not hugetlbfs or some other PMD device mapping). PM_THP would imply the flag is set only if the underlying page is THP without regard to whether it's actually PMD mapped or not.