LKML Archive on lore.kernel.org
 help / Atom feed
From: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
To: Rob Herring <robh@kernel.org>
Cc: Maxime Jourdan <maxi.jourdan@wanadoo.fr>,
	Neil Armstrong <narmstrong@baylibre.com>,
	Kevin Hilman <khilman@baylibre.com>,
	linux-arm-kernel@lists.infradead.org,
	linux-amlogic <linux-amlogic@lists.infradead.org>,
	Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
	dri-devel@lists.freedesktop.org, devicetree@vger.kernel.org
Subject: Re: [PATCH 4/4] drm/meson: convert to the new canvas module
Date: Fri, 10 Aug 2018 08:35:58 +0200
Message-ID: <CAHStOZ6oemCwYWb7dW6SS_ZaWEiVWSfrF=dB_G6CkVb6KS96nA@mail.gmail.com> (raw)
In-Reply-To: <5b6cc316.1c69fb81.682d3.1216@mx.google.com>

2018-08-10 0:41 GMT+02:00 Rob Herring <robh@kernel.org>:
> Hi, this is an automated email from Rob's (experimental) review bot. I
> found a couple of common problems with your patch. Please see below.
>
> On Wed,  1 Aug 2018 20:51:28 +0200, Maxime Jourdan wrote:
>> This removes the meson_canvas files within the meson/drm layer
>> and makes use of the new canvas module that is referenced in the dts.
>>
>> Canvases can be used by different IPs and modules, and it is as such
>> preferable to rely on a module that can safely dispatch canvases on
>> demand.
>>
>> Signed-off-by: Maxime Jourdan <maxi.jourdan@wanadoo.fr>
>
> The preferred subject prefix is "dt-bindings: <binding dir>: ...".
>
>> ---
>>  .../bindings/display/amlogic,meson-vpu.txt    |  9 +--
>>  arch/arm64/boot/dts/amlogic/meson-gx.dtsi     |  7 +-
>>  drivers/gpu/drm/meson/Kconfig                 |  1 +
>>  drivers/gpu/drm/meson/Makefile                |  2 +-
>>  drivers/gpu/drm/meson/meson_canvas.c          | 70 -------------------
>>  drivers/gpu/drm/meson/meson_canvas.h          | 42 -----------
>>  drivers/gpu/drm/meson/meson_crtc.c            |  5 +-
>>  drivers/gpu/drm/meson/meson_drv.c             | 35 ++++++----
>>  drivers/gpu/drm/meson/meson_drv.h             |  5 +-
>>  drivers/gpu/drm/meson/meson_plane.c           |  3 +-
>>  drivers/gpu/drm/meson/meson_viu.c             |  1 -
>>  11 files changed, 39 insertions(+), 141 deletions(-)
>>  delete mode 100644 drivers/gpu/drm/meson/meson_canvas.c
>>  delete mode 100644 drivers/gpu/drm/meson/meson_canvas.h
>>
>
> DT bindings (including binding headers) should be a separate patch. See
> Documentation/devicetree/bindings/submitting-patches.txt.
>

Hi, What's the standard procedure here ? The reason I kept
devicetree+drm changes together is because I didn't want to have
floating commits that would break the drm module.

Should I split the changes anyway ?

Maxime

  parent reply index

Thread overview: 19+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2018-08-01 18:51 [PATCH 0/4] soc: amlogic: add meson-canvas driver Maxime Jourdan
2018-08-01 18:51 ` [PATCH 1/4] " Maxime Jourdan
2018-08-02  8:38   ` Neil Armstrong
2018-08-02  8:52   ` Neil Armstrong
2018-08-02 13:14     ` Maxime Jourdan
2018-08-03 14:14   ` Yixun Lan
2018-08-03 21:47     ` Maxime Jourdan
2018-08-01 18:51 ` [PATCH 2/4] dt-bindings: soc: amlogic: add meson-canvas documentation Maxime Jourdan
2018-08-01 18:51 ` [PATCH 3/4] ARM64: dts: meson-gx: add dmcbus and canvas nodes Maxime Jourdan
2018-08-03 13:50   ` Yixun Lan
2018-08-04 20:02     ` Maxime Jourdan
2018-08-07  1:29       ` Yixun Lan
2018-08-01 18:51 ` [PATCH 4/4] drm/meson: convert to the new canvas module Maxime Jourdan
2018-08-02  8:39   ` Jerome Brunet
2018-08-02 12:34     ` Maxime Jourdan
2018-08-02 13:01       ` Jerome Brunet
2018-08-02 13:09         ` Maxime Jourdan
     [not found]   ` <5b6cc316.1c69fb81.682d3.1216@mx.google.com>
2018-08-10  6:35     ` Maxime Jourdan [this message]
2018-08-10  7:49       ` Neil Armstrong

Reply instructions:

You may reply publically to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHStOZ6oemCwYWb7dW6SS_ZaWEiVWSfrF=dB_G6CkVb6KS96nA@mail.gmail.com' \
    --to=maxi.jourdan@wanadoo.fr \
    --cc=devicetree@vger.kernel.org \
    --cc=dri-devel@lists.freedesktop.org \
    --cc=khilman@baylibre.com \
    --cc=linux-amlogic@lists.infradead.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=narmstrong@baylibre.com \
    --cc=robh@kernel.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

LKML Archive on lore.kernel.org

Archives are clonable:
	git clone --mirror https://lore.kernel.org/lkml/0 lkml/git/0.git
	git clone --mirror https://lore.kernel.org/lkml/1 lkml/git/1.git
	git clone --mirror https://lore.kernel.org/lkml/2 lkml/git/2.git
	git clone --mirror https://lore.kernel.org/lkml/3 lkml/git/3.git
	git clone --mirror https://lore.kernel.org/lkml/4 lkml/git/4.git
	git clone --mirror https://lore.kernel.org/lkml/5 lkml/git/5.git
	git clone --mirror https://lore.kernel.org/lkml/6 lkml/git/6.git
	git clone --mirror https://lore.kernel.org/lkml/7 lkml/git/7.git

	# If you have public-inbox 1.1+ installed, you may
	# initialize and index your mirror using the following commands:
	public-inbox-init -V2 lkml lkml/ https://lore.kernel.org/lkml \
		linux-kernel@vger.kernel.org linux-kernel@archiver.kernel.org
	public-inbox-index lkml


Newsgroup available over NNTP:
	nntp://nntp.lore.kernel.org/org.kernel.vger.linux-kernel


AGPL code for this site: git clone https://public-inbox.org/ public-inbox