From: Michal Simek <monstr@monstr.eu>
To: LKML <linux-kernel@vger.kernel.org>,
Michal Simek <monstr@monstr.eu>, git <git@xilinx.com>
Cc: Andre Przywara <andre.przywara@arm.com>,
Kalyani Akula <kalyani.akula@xilinx.com>,
Krzysztof Kozlowski <krzk@kernel.org>,
Laurent Pinchart <laurent.pinchart@ideasonboard.com>,
Manish Narani <manish.narani@xilinx.com>,
Rajan Vaja <rajan.vaja@xilinx.com>,
Rob Herring <robh+dt@kernel.org>,
DTML <devicetree@vger.kernel.org>,
linux-arm <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] arm64: dts: zynqmp: Add address-cells property to interrupt controllers
Date: Thu, 21 Jan 2021 11:17:34 +0100 [thread overview]
Message-ID: <CAHTX3d+dubuetK634YnM3UM-ZFz8b6xCY8CxQ5FFCBoT+dVsWQ@mail.gmail.com> (raw)
In-Reply-To: <e4f54ddce33b79a783aa7c76e0dc6e9787933610.1606918493.git.michal.simek@xilinx.com>
st 2. 12. 2020 v 15:14 odesílatel Michal Simek <michal.simek@xilinx.com> napsal:
>
> The commit 3eb619b2f7d8 ("scripts/dtc: Update to upstream version
> v1.6.0-11-g9d7888cbf19c") updated dtc version which also contained DTC
> commit
> "81e0919a3e21 checks: Add interrupt provider test"
> where reasons for this checking are mentioned as
> "A missing #address-cells property is less critical, but creates
> ambiguities when used in interrupt-map properties, so warn about this as
> well now."
>
> That's why add address-cells property to gic and gpio nodes to get rid of
> this warning.
>
> CC: Andre Przywara <andre.przywara@arm.com>
> Signed-off-by: Michal Simek <michal.simek@xilinx.com>
> ---
>
> I was grepping DTSes in the kernel and most of them list it as 0.
> In gicv3 case where its node is added it needs to be filled property that's
> why also non 0 values are there.
> Definitely please let me know if 0 is not the right value here.
>
> Based on https://lore.kernel.org/r/cover.1606917949.git.michal.simek@xilinx.com/
>
> ---
> arch/arm64/boot/dts/xilinx/zynqmp.dtsi | 2 ++
> 1 file changed, 2 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> index 14a2e69cf98b..5b2051ac6965 100644
> --- a/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> +++ b/arch/arm64/boot/dts/xilinx/zynqmp.dtsi
> @@ -368,6 +368,7 @@ fpd_dma_chan8: dma@fd570000 {
>
> gic: interrupt-controller@f9010000 {
> compatible = "arm,gic-400";
> + #address-cells = <0>;
> #interrupt-cells = <3>;
> reg = <0x0 0xf9010000 0x0 0x10000>,
> <0x0 0xf9020000 0x0 0x20000>,
> @@ -574,6 +575,7 @@ gem3: ethernet@ff0e0000 {
> gpio: gpio@ff0a0000 {
> compatible = "xlnx,zynqmp-gpio-1.0";
> status = "disabled";
> + #address-cells = <0>;
> #gpio-cells = <0x2>;
> gpio-controller;
> interrupt-parent = <&gic>;
> --
> 2.29.2
>
Applied.
M
--
Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91
w: www.monstr.eu p: +42-0-721842854
Maintainer of Linux kernel - Xilinx Microblaze
Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs
U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs
prev parent reply other threads:[~2021-01-21 10:23 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-12-02 14:14 [PATCH] arm64: dts: zynqmp: Add address-cells property to interrupt controllers Michal Simek
2021-01-21 10:17 ` Michal Simek [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHTX3d+dubuetK634YnM3UM-ZFz8b6xCY8CxQ5FFCBoT+dVsWQ@mail.gmail.com \
--to=monstr@monstr.eu \
--cc=andre.przywara@arm.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=kalyani.akula@xilinx.com \
--cc=krzk@kernel.org \
--cc=laurent.pinchart@ideasonboard.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=rajan.vaja@xilinx.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).