From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-9.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 684C6C4741F for ; Thu, 5 Nov 2020 16:42:20 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id E8D2620936 for ; Thu, 5 Nov 2020 16:42:19 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=monstr-eu.20150623.gappssmtp.com header.i=@monstr-eu.20150623.gappssmtp.com header.b="v5LK4B07" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1730808AbgKEQmS (ORCPT ); Thu, 5 Nov 2020 11:42:18 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:37258 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1725862AbgKEQmS (ORCPT ); Thu, 5 Nov 2020 11:42:18 -0500 Received: from mail-ej1-x642.google.com (mail-ej1-x642.google.com [IPv6:2a00:1450:4864:20::642]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id CEF4BC0613CF for ; Thu, 5 Nov 2020 08:42:17 -0800 (PST) Received: by mail-ej1-x642.google.com with SMTP id gn41so3545603ejc.4 for ; Thu, 05 Nov 2020 08:42:17 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monstr-eu.20150623.gappssmtp.com; s=20150623; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc:content-transfer-encoding; bh=6NI8PLn6qYNBnYjgB4FzOkwm+CyN8AnQY7eSxHSLiUs=; b=v5LK4B07XpF53LTXlvJ4vQ0jRMnYoY0zyNRgtixsX8gNAu6h5BDYphx4hUcfV5/Xc4 asIgNvV6k0GYj3f268dXkvZ7gIP5/oWKYOJJ+joUA92Q6eeJXmmaTp2FcfXkZSTw68au efowyULVQErGKWecCrqO4QwjpMPHCAXLetwzO2vjmlELE21x/GxToT+febKAkv1CXObr TK6WSl2O6/g1rmBk+lzo9IrBpjaHjIqgESq8LZF8hk5dIuu4oeQGHFkr/8OLDmxTfWkf OmmmcVAHuQH/VGsOvfbZjrKcyQv1GKFtfZyf4zsXjMmoTutFj8/Y0hRvqRbX9tXZrBx3 zofQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc:content-transfer-encoding; bh=6NI8PLn6qYNBnYjgB4FzOkwm+CyN8AnQY7eSxHSLiUs=; b=mmPSwgH/2Cc4Oocro5MIr/ZBGxcZEaDq4+agMMOkh1/aDBvRGBZ2BPbxe6pdnzTGkF 9ihviFIDKvQeaQRJqQ0gJRvlabL39OSi5UV9G6HJMF6pI1zL9Dh8PQ7hHpHhEG2SM1eV EQc0RnMD33NYptH7wBCy3ZDaoZoa7aEoNqtyJtsSIVYo4v84+KG5vrmYvQ2bGfGG1FWN iRI658XuZ9keIyfp34HKxqk5bZda7mQ8fIVQQELspxY+S9Z12DCwGRs3vfNDVYRqm3/K NcvdnRfRrd19Pti88G1qt1GCW/79noJpJiH2zWt6I6Fk7/L/0OkYo7gDCslhHL3DWI1Q jNRg== X-Gm-Message-State: AOAM530sbmu7mdo0OBjveYQVXLpx78aohVRqaCOPKpOK/BNvzhbBH/2a ulNrYLnnuk2fpw823AgpquQQNy8brlAAqGdg2BKX+cRRaQgF0w== X-Google-Smtp-Source: ABdhPJzHZ8cTd60580bhBaaAB5Pjkd8pHwdrSshuGLPU99WQJ3zuS/OsF0LXMM6VnQv5qWxcaJfs0esrp+/DEdqgvGA= X-Received: by 2002:a17:906:6702:: with SMTP id a2mr3048755ejp.309.1604594536549; Thu, 05 Nov 2020 08:42:16 -0800 (PST) MIME-Version: 1.0 References: In-Reply-To: From: Michal Simek Date: Thu, 5 Nov 2020 17:42:05 +0100 Message-ID: Subject: Re: [PATCH] microblaze: add support for TIF_NOTIFY_SIGNAL To: Jens Axboe Cc: "linux-kernel@vger.kernel.org" Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi, =C4=8Dt 5. 11. 2020 v 17:18 odes=C3=ADlatel Jens Axboe na= psal: > > Gentle nudge on this one. > > On 10/29/20 10:16 AM, Jens Axboe wrote: > > Wire up TIF_NOTIFY_SIGNAL handling for microblaze. > > > > Cc: Michal Simek > > Signed-off-by: Jens Axboe > > --- > > > > 5.11 has support queued up for TIF_NOTIFY_SIGNAL, see this posting > > for details: > > > > https://lore.kernel.org/io-uring/20201026203230.386348-1-axboe@kernel.d= k/ > > > > As part of that work, I'm adding TIF_NOTIFY_SIGNAL support to all archs= , > > as that will enable a set of cleanups once all of them support it. I'm > > happy carrying this patch if need be, or it can be funelled through the > > arch tree. Let me know. > > > > arch/microblaze/include/asm/thread_info.h | 2 ++ > > arch/microblaze/kernel/signal.c | 3 ++- > > 2 files changed, 4 insertions(+), 1 deletion(-) > > > > diff --git a/arch/microblaze/include/asm/thread_info.h b/arch/microblaz= e/include/asm/thread_info.h > > index ad8e8fcb90d3..44f5ca331862 100644 > > --- a/arch/microblaze/include/asm/thread_info.h > > +++ b/arch/microblaze/include/asm/thread_info.h > > @@ -107,6 +107,7 @@ static inline struct thread_info *current_thread_in= fo(void) > > #define TIF_NEED_RESCHED 3 /* rescheduling necessary */ > > /* restore singlestep on return to user mode */ > > #define TIF_SINGLESTEP 4 > > +#define TIF_NOTIFY_SIGNAL 5 /* signal notifications exist */ > > #define TIF_MEMDIE 6 /* is terminating due to OOM kill= er */ > > #define TIF_SYSCALL_AUDIT 9 /* syscall auditing active */ > > #define TIF_SECCOMP 10 /* secure computing */ > > @@ -119,6 +120,7 @@ static inline struct thread_info *current_thread_in= fo(void) > > #define _TIF_SIGPENDING (1 << TIF_SIGPENDING) > > #define _TIF_NEED_RESCHED (1 << TIF_NEED_RESCHED) > > #define _TIF_SINGLESTEP (1 << TIF_SINGLESTEP) > > +#define _TIF_NOTIFY_SIGNAL (1 << TIF_NOTIFY_SIGNAL) > > #define _TIF_POLLING_NRFLAG (1 << TIF_POLLING_NRFLAG) > > #define _TIF_SYSCALL_AUDIT (1 << TIF_SYSCALL_AUDIT) > > #define _TIF_SECCOMP (1 << TIF_SECCOMP) > > diff --git a/arch/microblaze/kernel/signal.c b/arch/microblaze/kernel/s= ignal.c > > index f11a0ccccabc..5a8d173d7b75 100644 > > --- a/arch/microblaze/kernel/signal.c > > +++ b/arch/microblaze/kernel/signal.c > > @@ -313,7 +313,8 @@ static void do_signal(struct pt_regs *regs, int in_= syscall) > > > > asmlinkage void do_notify_resume(struct pt_regs *regs, int in_syscall) > > { > > - if (test_thread_flag(TIF_SIGPENDING)) > > + if (test_thread_flag(TIF_SIGPENDING) || > > + test_thread_flag(TIF_NOTIFY_SIGNAL)) > > do_signal(regs, in_syscall); > > > > if (test_thread_flag(TIF_NOTIFY_RESUME)) > > > > > -- > Jens Axboe > Give me some time. I have it on my todo list. M --=20 Michal Simek, Ing. (M.Eng), OpenPGP -> KeyID: FE3D1F91 w: www.monstr.eu p: +42-0-721842854 Maintainer of Linux kernel - Xilinx Microblaze Maintainer of Linux kernel - Xilinx Zynq ARM and ZynqMP ARM64 SoCs U-Boot custodian - Xilinx Microblaze/Zynq/ZynqMP/Versal SoCs