From: Jens Wiklander <jens.wiklander@linaro.org>
To: linux-kernel@vger.kernel.org, op-tee@lists.trustedfirmware.org,
Herbert Xu <herbert@gondor.apana.org.au>
Cc: Sumit Garg <sumit.garg@linaro.org>,
Devaraj Rangasamy <Devaraj.Rangasamy@amd.com>,
Rijo Thomas <Rijo-john.Thomas@amd.com>,
David Howells <dhowells@redhat.com>,
Tyler Hicks <tyhicks@linux.microsoft.com>
Subject: Re: [PATCH v4 01/10] hwrng: optee-rng: use tee_shm_alloc_kernel_buf()
Date: Wed, 9 Feb 2022 15:12:05 +0100 [thread overview]
Message-ID: <CAHUa44F8JVw1vab_BBPx7iXMevYRAtMtpYQpa+PDQosV9_y7zA@mail.gmail.com> (raw)
In-Reply-To: <20220204093359.359059-2-jens.wiklander@linaro.org>
Hi Herbert,
On Fri, Feb 4, 2022 at 10:34 AM Jens Wiklander
<jens.wiklander@linaro.org> wrote:
>
> Uses the new simplified tee_shm_alloc_kernel_buf() function instead of
> the old deprecated tee_shm_alloc() function which required specific
> TEE_SHM-flags.
>
> Reviewed-by: Sumit Garg <sumit.garg@linaro.org>
> Signed-off-by: Jens Wiklander <jens.wiklander@linaro.org>
> ---
> drivers/char/hw_random/optee-rng.c | 6 +++---
> 1 file changed, 3 insertions(+), 3 deletions(-)
Since this patch depends on other patches in this patch set and vice
versa is it OK if I take this patch via my tree? I'm aiming for v5.18
with this.
Thanks,
Jens
>
> diff --git a/drivers/char/hw_random/optee-rng.c b/drivers/char/hw_random/optee-rng.c
> index 135a82590923..a948c0727b2b 100644
> --- a/drivers/char/hw_random/optee-rng.c
> +++ b/drivers/char/hw_random/optee-rng.c
> @@ -145,10 +145,10 @@ static int optee_rng_init(struct hwrng *rng)
> struct optee_rng_private *pvt_data = to_optee_rng_private(rng);
> struct tee_shm *entropy_shm_pool = NULL;
>
> - entropy_shm_pool = tee_shm_alloc(pvt_data->ctx, MAX_ENTROPY_REQ_SZ,
> - TEE_SHM_MAPPED | TEE_SHM_DMA_BUF);
> + entropy_shm_pool = tee_shm_alloc_kernel_buf(pvt_data->ctx,
> + MAX_ENTROPY_REQ_SZ);
> if (IS_ERR(entropy_shm_pool)) {
> - dev_err(pvt_data->dev, "tee_shm_alloc failed\n");
> + dev_err(pvt_data->dev, "tee_shm_alloc_kernel_buf failed\n");
> return PTR_ERR(entropy_shm_pool);
> }
>
> --
> 2.31.1
>
next prev parent reply other threads:[~2022-02-09 14:12 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-02-04 9:33 [PATCH v4 00/10] tee: shared memory updates Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 01/10] hwrng: optee-rng: use tee_shm_alloc_kernel_buf() Jens Wiklander
2022-02-09 14:12 ` Jens Wiklander [this message]
2022-02-04 9:33 ` [PATCH v4 02/10] tee: remove unused tee_shm_pool_alloc_res_mem() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 03/10] tee: add tee_shm_alloc_user_buf() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 04/10] tee: simplify shm pool handling Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 05/10] tee: replace tee_shm_alloc() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 06/10] optee: add optee_pool_op_free_helper() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 07/10] tee: add tee_shm_register_{user,kernel}_buf() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 08/10] KEYS: trusted: tee: use tee_shm_register_kernel_buf() Jens Wiklander
2022-02-09 14:08 ` Jens Wiklander
2022-02-21 1:52 ` Jarkko Sakkinen
2022-03-01 14:54 ` Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 09/10] tee: replace tee_shm_register() Jens Wiklander
2022-02-04 9:33 ` [PATCH v4 10/10] tee: refactor TEE_SHM_* flags Jens Wiklander
2022-02-16 6:40 ` [PATCH v4 00/10] tee: shared memory updates Jens Wiklander
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHUa44F8JVw1vab_BBPx7iXMevYRAtMtpYQpa+PDQosV9_y7zA@mail.gmail.com \
--to=jens.wiklander@linaro.org \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=dhowells@redhat.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=op-tee@lists.trustedfirmware.org \
--cc=sumit.garg@linaro.org \
--cc=tyhicks@linux.microsoft.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).