From: Jens Wiklander <jens.wiklander@linaro.org>
To: Nishanth Menon <nm@ti.com>
Cc: Rob Herring <robh+dt@kernel.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
Devicetree List <devicetree@vger.kernel.org>,
Linux ARM <linux-arm-kernel@lists.infradead.org>
Subject: Re: [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema
Date: Tue, 20 Apr 2021 10:32:37 +0200 [thread overview]
Message-ID: <CAHUa44GZenrwVWRZW6BKB8cktfXvktJ4OCF0AgPKanYGV01m5g@mail.gmail.com> (raw)
In-Reply-To: <20210416222518.15801-1-nm@ti.com>
On Sat, Apr 17, 2021 at 12:25 AM Nishanth Menon <nm@ti.com> wrote:
>
> Convert linaro,optee-tz to json schema format for better documentation
> and error checks.
>
> NOTE:
> 1. This change does introduce a stricter naming convention for
> optee nodes.
> 2. We do have false positive checkpatch warning with this patch:
> "DT binding docs and includes should be a separate patch"
>
> Signed-off-by: Nishanth Menon <nm@ti.com>
> ---
> .../bindings/arm/firmware/linaro,optee-tz.txt | 31 ----------
> .../arm/firmware/linaro,optee-tz.yaml | 62 +++++++++++++++++++
> 2 files changed, 62 insertions(+), 31 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> create mode 100644 Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
>
> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> deleted file mode 100644
> index d38834c67dff..000000000000
> --- a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.txt
> +++ /dev/null
> @@ -1,31 +0,0 @@
> -OP-TEE Device Tree Bindings
> -
> -OP-TEE is a piece of software using hardware features to provide a Trusted
> -Execution Environment. The security can be provided with ARM TrustZone, but
> -also by virtualization or a separate chip.
> -
> -We're using "linaro" as the first part of the compatible property for
> -the reference implementation maintained by Linaro.
> -
> -* OP-TEE based on ARM TrustZone required properties:
> -
> -- compatible : should contain "linaro,optee-tz"
> -
> -- method : The method of calling the OP-TEE Trusted OS. Permitted
> - values are:
> -
> - "smc" : SMC #0, with the register assignments specified
> - in drivers/tee/optee/optee_smc.h
> -
> - "hvc" : HVC #0, with the register assignments specified
> - in drivers/tee/optee/optee_smc.h
> -
> -
> -
> -Example:
> - firmware {
> - optee {
> - compatible = "linaro,optee-tz";
> - method = "smc";
> - };
> - };
> diff --git a/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> new file mode 100644
> index 000000000000..6513b5ac8b2c
> --- /dev/null
> +++ b/Documentation/devicetree/bindings/arm/firmware/linaro,optee-tz.yaml
> @@ -0,0 +1,62 @@
> +# SPDX-License-Identifier: (GPL-2.0 OR BSD-2-Clause)
> +%YAML 1.2
> +---
> +$id: http://devicetree.org/schemas/arm/firmware/linaro,optee-tz.yaml#
> +$schema: http://devicetree.org/meta-schemas/core.yaml#
Are these links supposed to work?
Thanks,
Jens
> +
> +title: OP-TEE Device Tree Bindings
> +
> +maintainers:
> + - Jens Wiklander <jens.wiklander@linaro.org>
> +
> +description: |
> + OP-TEE is a piece of software using hardware features to provide a Trusted
> + Execution Environment. The security can be provided with ARM TrustZone, but
> + also by virtualization or a separate chip.
> +
> + We're using "linaro" as the first part of the compatible property for
> + the reference implementation maintained by Linaro.
> +
> +properties:
> + $nodename:
> + const: 'optee'
> +
> + compatible:
> + const: linaro,optee-tz
> +
> + method:
> + description: The method of calling the OP-TEE Trusted OS.
> + oneOf:
> + - description: |
> + SMC #0, with the register assignments specified
> + in drivers/tee/optee/optee_smc.h
> + items:
> + - const: smc
> + - description: |
> + HVC #0, with the register assignments specified
> + in drivers/tee/optee/optee_smc.h
> + items:
> + - const: hvc
> +
> +required:
> + - compatible
> + - method
> +
> +additionalProperties: false
> +
> +examples:
> + - |
> + firmware {
> + optee {
> + compatible = "linaro,optee-tz";
> + method = "smc";
> + };
> + };
> +
> + - |
> + firmware {
> + optee {
> + compatible = "linaro,optee-tz";
> + method = "hvc";
> + };
> + };
> --
> 2.31.0
>
next prev parent reply other threads:[~2021-04-20 8:32 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-04-16 22:25 [PATCH] dt-bindings: arm: firmware: Convert linaro,optee-tz to json schema Nishanth Menon
2021-04-20 8:32 ` Jens Wiklander [this message]
2021-04-20 13:49 ` Nishanth Menon
2021-04-21 22:48 ` Rob Herring
2021-04-21 22:52 ` Rob Herring
2021-04-22 14:20 ` Nishanth Menon
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHUa44GZenrwVWRZW6BKB8cktfXvktJ4OCF0AgPKanYGV01m5g@mail.gmail.com \
--to=jens.wiklander@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=robh+dt@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).