From: Jens Wiklander <jens.wiklander@linaro.org>
To: Arnd Bergmann <arnd@arndb.de>
Cc: soc@kernel.org,
"Vesa Jääskeläinen" <vesa.jaaskelainen@vaisala.com>,
"Devaraj Rangasamy" <Devaraj.Rangasamy@amd.com>,
"Rijo Thomas" <Rijo-john.Thomas@amd.com>,
"Gary R Hook" <gary.hook@amd.com>,
"Herbert Xu" <herbert@gondor.apana.org.au>,
"tee-dev @ lists . linaro . org" <tee-dev@lists.linaro.org>,
"Linux Kernel Mailing List" <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] tee: fix crypto select
Date: Wed, 27 May 2020 17:07:24 +0200 [thread overview]
Message-ID: <CAHUa44HXs_h5ZBizHXDtYWa9Ubk=64AgiM5zj7rGx0CxVcSbTA@mail.gmail.com> (raw)
In-Reply-To: <20200527133924.724819-1-arnd@arndb.de>
Hi Arnd,
On Wed, May 27, 2020 at 3:39 PM Arnd Bergmann <arnd@arndb.de> wrote:
>
> When selecting a crypto cipher, we also need to select the
> subsystem itself:
>
> WARNING: unmet direct dependencies detected for CRYPTO_SHA1
> Depends on [m]: CRYPTO [=m]
> Selected by [y]:
> - TEE [=y] && (HAVE_ARM_SMCCC [=n] || COMPILE_TEST [=y] || CPU_SUP_AMD [=y])
> Selected by [m]:
> - CRYPTO_DEV_QAT [=m] && CRYPTO [=m] && CRYPTO_HW [=y]
> - CRYPTO_DEV_MEDIATEK [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (ARM && ARCH_MEDIATEK || COMPILE_TEST [=y])
> - CRYPTO_DEV_SAFEXCEL [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && (OF [=y] || PCI [=y] || COMPILE_TEST [=y]) && HAS_IOMEM [=y]
> - CRYPTO_DEV_CCREE [=m] && CRYPTO [=m] && CRYPTO_HW [=y] && OF [=y] && HAS_DMA [=y]
> - CRYPTO_DEV_SP_CCP [=y] && CRYPTO [=m] && CRYPTO_HW [=y] && CRYPTO_DEV_CCP [=y] && CRYPTO_DEV_CCP_DD [=m] && DMADEVICES [=y]
>
> Fixes: e33bcbab16d1 ("tee: add support for session's client UUID generation")
> Signed-off-by: Arnd Bergmann <arnd@arndb.de>
> ---
> The regression was introduced in the soc tree, I'd pick this patch
> up directly into that unless someone sees a problem
Thanks for taking care of this, please go ahead.
Cheers,
Jens
> ---
> drivers/tee/Kconfig | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/drivers/tee/Kconfig b/drivers/tee/Kconfig
> index 806eb87d4da0..e99d840c2511 100644
> --- a/drivers/tee/Kconfig
> +++ b/drivers/tee/Kconfig
> @@ -3,6 +3,7 @@
> config TEE
> tristate "Trusted Execution Environment support"
> depends on HAVE_ARM_SMCCC || COMPILE_TEST || CPU_SUP_AMD
> + select CRYPTO
> select CRYPTO_SHA1
> select DMA_SHARED_BUFFER
> select GENERIC_ALLOCATOR
> --
> 2.26.2
>
next prev parent reply other threads:[~2020-05-27 15:07 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-05-27 13:39 [PATCH] tee: fix crypto select Arnd Bergmann
2020-05-27 15:07 ` Jens Wiklander [this message]
2020-05-28 6:08 ` Vesa Jääskeläinen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHUa44HXs_h5ZBizHXDtYWa9Ubk=64AgiM5zj7rGx0CxVcSbTA@mail.gmail.com' \
--to=jens.wiklander@linaro.org \
--cc=Devaraj.Rangasamy@amd.com \
--cc=Rijo-john.Thomas@amd.com \
--cc=arnd@arndb.de \
--cc=gary.hook@amd.com \
--cc=herbert@gondor.apana.org.au \
--cc=linux-kernel@vger.kernel.org \
--cc=soc@kernel.org \
--cc=tee-dev@lists.linaro.org \
--cc=vesa.jaaskelainen@vaisala.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).