From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B6F9CC677F1 for ; Fri, 13 Jan 2023 18:17:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231152AbjAMSRH (ORCPT ); Fri, 13 Jan 2023 13:17:07 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:57918 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231202AbjAMSPz (ORCPT ); Fri, 13 Jan 2023 13:15:55 -0500 Received: from mail-yw1-x1131.google.com (mail-yw1-x1131.google.com [IPv6:2607:f8b0:4864:20::1131]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id D5D3010E7 for ; Fri, 13 Jan 2023 10:07:04 -0800 (PST) Received: by mail-yw1-x1131.google.com with SMTP id 00721157ae682-4b6255ce5baso295248817b3.11 for ; Fri, 13 Jan 2023 10:07:04 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:from:to:cc:subject:date:message-id:reply-to; bh=qoxr5X5imkz2olyJUzF1rhC2GFm22yRwb2J/WfLDgXQ=; b=dpxojtaZxe37je5lIn27UJw3451J9nTITh/73Iz7YPdEwivuYKLF+mEsM4TPJordCx tOK6i53c6fxIEjCBN4osHXTal+EL8RJ4weGrEjHrGUgzIl6AREQAc6U4iFTNU3+bsei7 6WZcxhcmbCNrg/fGvcMuje4hfNbWEbtY4x1UnpXbSYuZcEZrAbMkS00736iqJbdgXsYc MASpAof7wBsOjMKaeyzUTLKkqGlwKc/IIUfeKXiflNewBpGEHg/HZqhyChic8FNa34l1 wTQY6ezJ2la+PL0kJNHw/+bsAWL84qKZPUoQPZFqxZgk443sxu1O0HeFg8ImFTrlurLM DXKQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=cc:to:subject:message-id:date:from:in-reply-to:references :mime-version:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=qoxr5X5imkz2olyJUzF1rhC2GFm22yRwb2J/WfLDgXQ=; b=QutWR2Soc4LrgAwe12SSW6AYnxlO/le46T0pqJKgSurNMdxEHbvs41sj4uutRyEoTw GFqaVXTj0tNphkzGUwWTx8pZR4LuIiem61vPyfUjLqdkc2Q+M48IozZ1tOrpqN6Y8Ev9 JHIYwMcK2lDGsOn1jNO1WKPKtlWVxbA9VboH0h7VEn+0glQda5epGvVG7b0pxJLDRFzE 0lqlA4CJlujQXRbx0VAU90J7H1xBGWDpmOIh1zJ3jUwm4PHcIwxBbzVsfn5bsN7069Kf cVHjoNOYXe4EBtg+u4okaDoCObRoHBIRwk116nn386SpADXg+gzRZqu5G6+4ijFPAHNW HFSA== X-Gm-Message-State: AFqh2kr1ruuJZ+ep5B9KnEtxw74AomhG9X1XTkbgnVFjaHpvxU/+Xn9f 8ksQf4g4TJWnhe2fnYQwIXPLzx9ScW2rrIiV9pRnkg== X-Google-Smtp-Source: AMrXdXum2Aq9jKTZUMljeuJMdEobnuyptEBNDCpABh7ohWzPstzMjndzTJDzVcRD+Cv6ug9+n/QrfiUUmFF1+xaHyKs= X-Received: by 2002:a0d:d9c5:0:b0:4de:4c70:5504 with SMTP id b188-20020a0dd9c5000000b004de4c705504mr368547ywe.318.1673633223864; Fri, 13 Jan 2023 10:07:03 -0800 (PST) MIME-Version: 1.0 References: <20221221222418.3307832-1-bgardon@google.com> <20221221222418.3307832-4-bgardon@google.com> In-Reply-To: From: Vipin Sharma Date: Fri, 13 Jan 2023 10:06:27 -0800 Message-ID: Subject: Re: [RFC 03/14] KVM: x86/MMU: Move the Shadow MMU implementation to shadow_mmu.c To: Ben Gardon Cc: linux-kernel@vger.kernel.org, kvm@vger.kernel.org, Paolo Bonzini , Peter Xu , Sean Christopherson , David Matlack , Nagareddy Reddy Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Wed, Dec 21, 2022 at 2:40 PM Ben Gardon wrote: > > On Wed, Dec 21, 2022 at 2:24 PM Ben Gardon wrote: > > > > Cut and paste the implementation of the Shadow MMU to shadow_mmu.(c|h). > > This is a monsterously large commit, moving ~3500 lines. With such a > > large move, there's no way to make it easy. Do the move in one massive > > step to simplify dealing with merge conflicts and to make the git > > history a little easier to dig through. Several cleanup commits follow > > this one rather than preceed it so that their git history will remain > > easy to see. > > > > No functional change intended. > > > > Signed-off-by: Ben Gardon > > Woops, I guess this message bounced because the patch was just too long. > I can try to split it in two if folks would prefer, or just send a > list of the functions / definitions moved. > Interesting, I can see this patch in my email client, lore.kernel.org/lkml but not in patchwork.kernel.org One more way can be to move declarations to shadow_mmu.h first and then in subsequent patch move definitions to shadow_mmu.c. I do agree it won't reduce size much but it will make it easier to see which functions are becoming the part of API. > > --- > > arch/x86/kvm/debugfs.c | 1 + > > arch/x86/kvm/mmu/mmu.c | 4526 ++++--------------------------- > > arch/x86/kvm/mmu/mmu_internal.h | 4 +- > > arch/x86/kvm/mmu/shadow_mmu.c | 3408 +++++++++++++++++++++++ > > arch/x86/kvm/mmu/shadow_mmu.h | 145 + > > 5 files changed, 4086 insertions(+), 3998 deletions(-) > > > > ... > > > -- > > 2.39.0.314.g84b9a713c41-goog > >