From: Vipin Sharma <vipinsh@google.com>
To: Sean Christopherson <seanjc@google.com>
Cc: pbonzini@redhat.com, dmatlack@google.com, andrew.jones@linux.dev,
wei.w.wang@intel.com, kvm@vger.kernel.org,
linux-kernel@vger.kernel.org
Subject: Re: [PATCH v7 3/5] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi()
Date: Mon, 31 Oct 2022 12:44:04 -0700 [thread overview]
Message-ID: <CAHVum0f_Bv8rH8F3Q5GsdeJkjsQpgArmukFQ-bw6VryjaAsdaQ@mail.gmail.com> (raw)
In-Reply-To: <Y2AfUKJ19yZrlHzN@google.com>
On Mon, Oct 31, 2022 at 12:17 PM Sean Christopherson <seanjc@google.com> wrote:
>
> On Mon, Oct 31, 2022, Vipin Sharma wrote:
> > atoi() doesn't detect errors. There is no way to know that a 0 return
> > is correct conversion or due to an error.
> >
> > Introduce atoi_paranoid() to detect errors and provide correct
> > conversion. Replace all atoi() calls with atoi_paranoid().
> > diff --git a/tools/testing/selftests/kvm/lib/test_util.c b/tools/testing/selftests/kvm/lib/test_util.c
> > index 6d23878bbfe1..ec0f070a6f21 100644
> > --- a/tools/testing/selftests/kvm/lib/test_util.c
> > +++ b/tools/testing/selftests/kvm/lib/test_util.c
> > @@ -334,3 +334,22 @@ long get_run_delay(void)
> >
> > return val[1];
> > }
> > +
> > +int atoi_paranoid(const char *num_str)
> > +{
> > + char *end_ptr;
> > + long num;
> > +
> > + errno = 0;
> > + num = strtol(num_str, &end_ptr, 10);
>
> I take back my review. This forces specifying params in decimal, e.g. a large
> hex number yields:
>
> strtol("0xffffffffff") failed to parse trailing characters "xffffffffff".
>
> Obviously I'm intentionally being a bad user in this particular case, but there
> will inevitably be tests that want to take hex input, e.g. an x86 test that takes
> an MSR index would definitely want hex input.
>
> Looking through all selftests, I don't think there are existing cases that would
> likely want hex, but it's trivial to support since strtol() will autodetect the
> format if the base is '0', i.e.
atoi_paranoid() replaced atoi() which only works for base 10. I was
keeping it similar.
I'll wait a couple of days for any other feedback and send v8.
>
> diff --git a/tools/testing/selftests/kvm/lib/test_util.c b/tools/testing/selftests/kvm/lib/test_util.c
> index 210e98a49a83..8c37cfa12edc 100644
> --- a/tools/testing/selftests/kvm/lib/test_util.c
> +++ b/tools/testing/selftests/kvm/lib/test_util.c
> @@ -341,7 +341,7 @@ int atoi_paranoid(const char *num_str)
> long num;
>
> errno = 0;
> - num = strtol(num_str, &end_ptr, 10);
> + num = strtol(num_str, &end_ptr, 0);
> TEST_ASSERT(!errno, "strtol(\"%s\") failed", num_str);
> TEST_ASSERT(num_str != end_ptr,
> "strtol(\"%s\") didn't find a valid integer.\n", num_str);
next prev parent reply other threads:[~2022-10-31 19:44 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-10-31 17:38 [PATCH v7 0/5] dirty_log_perf_test vCPU pinning Vipin Sharma
2022-10-31 17:38 ` [PATCH v7 1/5] KVM: selftests: Add missing break between -e and -g option in dirty_log_perf_test Vipin Sharma
2022-10-31 18:46 ` Sean Christopherson
2022-10-31 17:38 ` [PATCH v7 2/5] KVM: selftests: Put command line options in alphabetical order " Vipin Sharma
2022-10-31 18:47 ` Sean Christopherson
2022-10-31 17:38 ` [PATCH v7 3/5] KVM: selftests: Add atoi_paranoid() to catch errors missed by atoi() Vipin Sharma
2022-10-31 18:49 ` Sean Christopherson
2022-10-31 19:17 ` Sean Christopherson
2022-10-31 19:44 ` Vipin Sharma [this message]
2022-10-31 17:38 ` [PATCH v7 4/5] KVM: selftests: Add atoi_positive() and atoi_non_negative() for input validation Vipin Sharma
2022-10-31 19:48 ` Sean Christopherson
2022-11-01 19:01 ` Vipin Sharma
2022-11-01 19:20 ` Sean Christopherson
2022-11-01 19:28 ` Vipin Sharma
2022-10-31 17:38 ` [PATCH v7 5/5] KVM: selftests: Allowing running dirty_log_perf_test on specific CPUs Vipin Sharma
2022-10-31 19:49 ` Sean Christopherson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHVum0f_Bv8rH8F3Q5GsdeJkjsQpgArmukFQ-bw6VryjaAsdaQ@mail.gmail.com \
--to=vipinsh@google.com \
--cc=andrew.jones@linux.dev \
--cc=dmatlack@google.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=pbonzini@redhat.com \
--cc=seanjc@google.com \
--cc=wei.w.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).