From: Nick Crews <ncrews@chromium.org>
To: Daniel Campello <campello@chromium.org>
Cc: Enric Balletbo i Serra <enric.balletbo@collabora.com>,
Benson Leung <bleung@chromium.org>,
linux-leds@vger.kernel.org,
Jacek Anaszewski <jacek.anaszewski@gmail.com>,
Pavel Machek <pavel@ucw.cz>,
linux-kernel <linux-kernel@vger.kernel.org>,
Arnd Bergmann <arnd@arndb.de>,
Wei Yongjun <weiyongjun1@huawei.com>,
Duncan Laurie <dlaurie@chromium.org>,
Daniel Kurtz <djkurtz@chromium.org>,
Dmitry Torokhov <dtor@google.com>, Simon Glass <sjg@chromium.org>,
groeck@chromium.com
Subject: Re: [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support
Date: Fri, 25 Oct 2019 13:18:18 -0600 [thread overview]
Message-ID: <CAHX4x87jLHxZwvaU6nAX5VKy=LZutiRohE6rGd1GffJg-Pt0JA@mail.gmail.com> (raw)
In-Reply-To: <20191025173319.GA1768@chromium.org>
On Fri, Oct 25, 2019 at 11:33 AM Daniel Campello <campello@chromium.org> wrote:
>
> LGTM.
> Reviewed-by: Daniel Campello <campello@chromium.
FYI I realized some of the imports in keyboard_leds.c are
unneeded, so I sent a v8 version that fixes this. I presume
you would LGTM that one too though.
next prev parent reply other threads:[~2019-10-25 19:18 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-10-24 22:28 [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support Nick Crews
2019-10-24 22:28 ` [PATCH v8 2/2] power_supply: platform/chrome: wilco_ec: Add charging config driver Nick Crews
2019-11-06 15:16 ` Enric Balletbo i Serra
2019-10-25 17:33 ` [PATCH v8 1/2] platform/chrome: wilco_ec: Add keyboard backlight LED support Daniel Campello
2019-10-25 19:18 ` Nick Crews [this message]
2019-11-06 15:15 ` Enric Balletbo i Serra
[not found] ` <CAHcu+VYdMxoFbcxYxB1FnDSdsM=w9UsVKjF0S48LZGG0ZxKUDA@mail.gmail.com>
2019-11-06 16:39 ` Daniel Campello
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHX4x87jLHxZwvaU6nAX5VKy=LZutiRohE6rGd1GffJg-Pt0JA@mail.gmail.com' \
--to=ncrews@chromium.org \
--cc=arnd@arndb.de \
--cc=bleung@chromium.org \
--cc=campello@chromium.org \
--cc=djkurtz@chromium.org \
--cc=dlaurie@chromium.org \
--cc=dtor@google.com \
--cc=enric.balletbo@collabora.com \
--cc=groeck@chromium.com \
--cc=jacek.anaszewski@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-leds@vger.kernel.org \
--cc=pavel@ucw.cz \
--cc=sjg@chromium.org \
--cc=weiyongjun1@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).