From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=DKIM_SIGNED,DKIM_VALID, DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SIGNED_OFF_BY,SPF_PASS,URIBL_BLOCKED,USER_AGENT_MUTT autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8B49BC46460 for ; Tue, 14 May 2019 16:12:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 591AA20879 for ; Tue, 14 May 2019 16:12:58 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="nNZvEWx/" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1726610AbfENQM5 (ORCPT ); Tue, 14 May 2019 12:12:57 -0400 Received: from mail-lj1-f195.google.com ([209.85.208.195]:35830 "EHLO mail-lj1-f195.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726142AbfENQM4 (ORCPT ); Tue, 14 May 2019 12:12:56 -0400 Received: by mail-lj1-f195.google.com with SMTP id m20so3107106lji.2 for ; Tue, 14 May 2019 09:12:54 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=date:from:to:cc:subject:message-id:references:mime-version :content-disposition:in-reply-to:user-agent; bh=zfQddiOq+yGGXgJWvgghz1ralncjsTYvFgLd2q9NqWE=; b=nNZvEWx/rFjfVThvl7XDlvrse2Tx/2cWqc4X+mp+jVlfV3qf+s7ufqbSaIalYSrw80 0eA0gHN629gImnlapJQJFp342J9gRE4yv7EZBFHDV5MZjL0x9RqlDFQP/irmJTLe88aS //Cfoia50oc2JNU0LsOPP1pAv53HFseGLC1k3oobOzAG043Q62ylR8CVyHmPTpTHFRuo w59D2+URas9X9dCu9eRGIS8+IV8S62UvBUuwtHZrWbX3vGDeyJLEsePQwbno3ovBkbCT W8WeBULQUWutSOpvNwxljTy0RLBP0AX0rCFicu+qf3A2r5AdFhXmjM5PkBCgeaxklOPB 8CEA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:from:to:cc:subject:message-id:references :mime-version:content-disposition:in-reply-to:user-agent; bh=zfQddiOq+yGGXgJWvgghz1ralncjsTYvFgLd2q9NqWE=; b=W3eLecOJ5qsBs9O6w0mSmEI/ZLnkHsDDKWRr7NEJ7QWjo/3WE2M98X/+NqF4Lct8Lo nYsUy1WkNfUTbxzz2ezcJbjoCsoQedogRbMIzbKN0PVwWO2X8H8n/p+TquOH7yT7winf iO1g73eTBEV8m3AnLD6yGvgWHpZf7TKNqjpz70dHB4woQcQLjdVQ36de3EzZPEQbm5mv a10ziK/eNrr5VX67nYg0eVAKUCgjolA8OYuIERWZiv0m9K5OA4SMNQwR7B0TJCq06oHh qS5PV+HX98SA9EAGgwEVZiUwKUOWgrOsWvLusKragNSgVxDQsoioUPCje7Ar3v3QXCsN C2+g== X-Gm-Message-State: APjAAAXc1KrdQ1Wnb2gpjixYuZsk7nHviD36aAeftWisti9AUCuhrRJ9 eorpwcfSzLYGCHu/epyDbAL0OA== X-Google-Smtp-Source: APXvYqy2E5MlY+OvjuCOEAWZdqfDU3RAdwYwk3Humcsl5K9EzCU3UbbxjastyVsuoCXvxqGsQookgg== X-Received: by 2002:a2e:9b92:: with SMTP id z18mr7595076lji.190.1557850373861; Tue, 14 May 2019 09:12:53 -0700 (PDT) Received: from centauri.ideon.se ([85.235.10.227]) by smtp.gmail.com with ESMTPSA id j1sm799183lja.17.2019.05.14.09.12.50 (version=TLS1_3 cipher=AEAD-AES256-GCM-SHA384 bits=256/256); Tue, 14 May 2019 09:12:50 -0700 (PDT) Date: Tue, 14 May 2019 18:12:49 +0200 From: Niklas Cassel To: Amit Kucheria Cc: Linux Kernel Mailing List , linux-arm-msm , Bjorn Andersson , Andy Gross , David Brown , Li Yang , Shawn Guo , devicetree Subject: Re: [PATCHv1 6/8] arm64: dts: qcom: msm8996: Add PSCI cpuidle low power states Message-ID: References: <8648ba97d49a9f731001e4b36611be9650e37f37.1557486950.git.amit.kucheria@linaro.org> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <8648ba97d49a9f731001e4b36611be9650e37f37.1557486950.git.amit.kucheria@linaro.org> User-Agent: Mutt/1.11.4 (2019-03-13) Sender: linux-kernel-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Fri, May 10, 2019 at 04:59:44PM +0530, Amit Kucheria wrote: > Add device bindings for cpuidle states for cpu devices. > > Signed-off-by: Amit Kucheria > --- > arch/arm64/boot/dts/qcom/msm8996.dtsi | 28 +++++++++++++++++++++++++++ > 1 file changed, 28 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8996.dtsi b/arch/arm64/boot/dts/qcom/msm8996.dtsi > index c761269caf80..b615bcb9e351 100644 > --- a/arch/arm64/boot/dts/qcom/msm8996.dtsi > +++ b/arch/arm64/boot/dts/qcom/msm8996.dtsi > @@ -95,6 +95,7 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x0>; > enable-method = "psci"; > + cpu-idle-states = <&LITTLE_CPU_PD>; > next-level-cache = <&L2_0>; > L2_0: l2-cache { > compatible = "cache"; > @@ -107,6 +108,7 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x1>; > enable-method = "psci"; > + cpu-idle-states = <&LITTLE_CPU_PD>; > next-level-cache = <&L2_0>; > }; > > @@ -115,6 +117,7 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x100>; > enable-method = "psci"; > + cpu-idle-states = <&BIG_CPU_PD>; > next-level-cache = <&L2_1>; > L2_1: l2-cache { > compatible = "cache"; > @@ -127,6 +130,7 @@ > compatible = "qcom,kryo"; > reg = <0x0 0x101>; > enable-method = "psci"; > + cpu-idle-states = <&BIG_CPU_PD>; > next-level-cache = <&L2_1>; > }; > > @@ -151,6 +155,30 @@ > }; > }; > }; > + > + idle-states { > + entry-method="psci"; Please add a space before and after "=". > + > + LITTLE_CPU_PD: little-power-down { In Documentation/devicetree/bindings/arm/idle-states.txt they seem to use labels such as CPU_SLEEP_0_0 for the first cluster and CPU_SLEEP_1_0 for the second cluster. Please also consider my comment in patch 4/8. > + compatible = "arm,idle-state"; > + idle-state-name = "standalone-power-collapse"; > + arm,psci-suspend-param = <0x00000004>; > + entry-latency-us = <40>; > + exit-latency-us = <40>; Where did you get the latency values from? Downstream seems to use qcom,latency-us = <80> for "fpc". (Sure downstream also defines "fpc-def", but that seems to require additional psci code/calls that doesn't exist upstream.) > + min-residency-us = <300>; > + local-timer-stop; Are you sure that the local timer is stopped? the equivalent DT property to "local-timer-stop" in downstream is "qcom,use-broadcast-timer", and this property seems to be missing from this node: https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8996-pm.dtsi?h=msm-4.4#n158 You could try to remove "local-timer-stop", if it is really needed, then the system should hang without this property. > + }; > + > + BIG_CPU_PD: big-power-down { > + compatible = "arm,idle-state"; > + idle-state-name = "standalone-power-collapse"; > + arm,psci-suspend-param = <0x00000004>; > + entry-latency-us = <40>; > + exit-latency-us = <40>; Where did you get the latency values from? Downstream seems to use qcom,latency-us = <80> for "fpc". (Sure downstream also defines "fpc-def", but that seems to require additional psci code/calls that doesn't exist upstream.) > + min-residency-us = <300>; > + local-timer-stop; Are you sure that the local timer is stopped? the equivalent DT property to "local-timer-stop" in downstream is "qcom,use-broadcast-timer", and this property seems to be missing from this node: https://source.codeaurora.org/quic/la/kernel/msm-4.4/tree/arch/arm/boot/dts/qcom/msm8996-pm.dtsi?h=msm-4.4#n247 You could try to remove "local-timer-stop", if it is really needed, then the system should hang without this property. > + }; > + }; > }; > > thermal-zones { > -- > 2.17.1 >