From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S1752368AbdLLNXM (ORCPT <rfc822;w@1wt.eu>);
        Tue, 12 Dec 2017 08:23:12 -0500
Received: from mail-it0-f66.google.com ([209.85.214.66]:43342 "EHLO
        mail-it0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S1752152AbdLLNWm (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Tue, 12 Dec 2017 08:22:42 -0500
X-Google-Smtp-Source: ACJfBos+C41Q8jcwGMQzC+cBOHqdotjsGGt4nLTsuZENyrPfneYd2wbAg5DRY4wPkSeI+uxoQpZy6ptyv8sT31QQer8=
MIME-Version: 1.0
In-Reply-To: <20171212114937.GA23534@kroah.com>
References: <20171212143910.146724d2@canb.auug.org.au> <1513075258-10860-1-git-send-email-gomonovych@gmail.com>
 <20171212114937.GA23534@kroah.com>
From: "Gomonovych, Vasyl" <gomonovych@gmail.com>
Date: Tue, 12 Dec 2017 14:22:41 +0100
Message-ID: <CAHYXAnJw78JRqBj9LBr5-e0PffO=xXeRDJvs9cHCYjR0Wcw3tg@mail.gmail.com>
Subject: Re: [PATCH v2] misc: mic: Use memdup_user() as a cleanup
To: Greg KH <greg@kroah.com>
Cc: Stephen Rothwell <sfr@canb.auug.org.au>, Arnd Bergmann <arnd@arndb.de>,
        sudeep.dutt@intel.com, ashutosh.dixit@intel.com,
        dan.carpenter@oracle.com, linux-kernel@vger.kernel.org,
        linux-next@vger.kernel.org
Content-Type: text/plain; charset="UTF-8"
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by nfs id vBCDNINW032098

Hi,
Thanks.
Should I prepare fix patch only for missed label?

Regards Vasyl.

On Tue, Dec 12, 2017 at 12:49 PM, Greg KH <greg@kroah.com> wrote:
> On Tue, Dec 12, 2017 at 11:40:58AM +0100, Vasyl Gomonovych wrote:
>> Fix coccicheck warning which recommends to use memdup_user():
>>
>> drivers/misc/mic/vop/vop_vringh.c:940:14-21: WARNING opportunity for memdup_user
>> drivers/misc/mic/vop/vop_vringh.c:998:8-15: WARNING opportunity for memdup_user
>>
>> Generated by: scripts/coccinelle/memdup_user/memdup_user.cocci
>>
>> Changelog:
>>  - v1:
>>    - Replace kzalloc + copy_from_user on memdup_user
>>  - v2:
>>    - Clear forgotten done label
>>      After merging the char-misc tree, today's linux-next build
>>      (x86_64_allmodconfig) produced this warning:
>>      drivers/misc/mic/vop/vop_vringh.c: In function 'vop_ioctl':
>>      drivers/misc/mic/vop/vop_vringh.c:1001:1: warning: label 'done' defined but not used [-Wunused-label]
>
> Will not work as I already have taken v1.
>
> Also, put the changelog below the --- line please.
>
> thanks,
>
> greg k-h



-- 
Доброї вам пори дня.