From: Stephen Suryaputra <ssuryaextr@gmail.com>
To: Nikolay Aleksandrov <nikolay@cumulusnetworks.com>
Cc: Brodie Greenfield <brodie.greenfield@alliedtelesis.co.nz>,
David Miller <davem@davemloft.net>,
Stephen Hemminger <stephen@networkplumber.org>,
kuznet@ms2.inr.ac.ru, yoshfuji@linux-ipv6.org,
netdev <netdev@vger.kernel.org>,
linux-kernel@vger.kernel.org, chris.packham@alliedtelesis.co.nz,
luuk.paulussen@alliedtelesis.co.nz
Subject: Re: [PATCH 1/2] ipmr: Make cache queue length configurable
Date: Sat, 27 Jul 2019 13:03:31 -0400 [thread overview]
Message-ID: <CAHapkUhEVGFRH=-R+obSUMh6rSVxZmEC9GQSnvUkvuj6dwVxjA@mail.gmail.com> (raw)
In-Reply-To: <6e8c51a0-cd34-e14a-7661-6fa5945f278b@cumulusnetworks.com>
On Fri, Jul 26, 2019 at 7:18 AM Nikolay Aleksandrov
<nikolay@cumulusnetworks.com> wrote:
> > You've said it yourself - it has linear traversal time, but doesn't this patch allow any netns on the
> > system to increase its limit to any value, thus possibly affecting others ?
> > Though the socket limit will kick in at some point. I think that's where David
> > was going with his suggestion back in 2018:
> > https://www.spinics.net/lists/netdev/msg514543.html
> >
> > If we add this sysctl now, we'll be stuck with it. I'd prefer David's suggestion
> > so we can rely only on the receive queue queue limit which is already configurable.
> > We still need to be careful with the defaults though, the NOCACHE entry is 128 bytes
> > and with the skb overhead currently on my setup we end up at about 277 entries default limit.
>
> I mean that people might be surprised if they increased that limit by default, that's the
> only problem I'm not sure how to handle. Maybe we need some hard limit anyway.
> Have you done any tests what value works for your setup ?
FYI: for ours, it is 2048.
next prev parent reply other threads:[~2019-07-27 17:03 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-25 20:42 [PATCH 0/2] Make ipmr queue length configurable Brodie Greenfield
2019-07-25 20:42 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-07-26 10:10 ` Stephen Suryaputra
2019-07-26 11:05 ` Nikolay Aleksandrov
2019-07-26 11:15 ` Nikolay Aleksandrov
2019-07-27 17:03 ` Stephen Suryaputra [this message]
2019-07-25 20:42 ` [PATCH 2/2] ip6mr: " Brodie Greenfield
2019-07-26 10:10 ` Stephen Suryaputra
2019-07-27 20:18 ` [PATCH 0/2] Make ipmr " David Miller
-- strict thread matches above, loose matches on Subject: below --
2019-03-07 4:57 Brodie Greenfield
2019-03-07 4:57 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-03-06 20:19 [PATCH 0/2] Make ipmr " Brodie Greenfield
2019-03-06 20:19 ` [PATCH 1/2] ipmr: Make cache " Brodie Greenfield
2019-03-07 15:40 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHapkUhEVGFRH=-R+obSUMh6rSVxZmEC9GQSnvUkvuj6dwVxjA@mail.gmail.com' \
--to=ssuryaextr@gmail.com \
--cc=brodie.greenfield@alliedtelesis.co.nz \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=davem@davemloft.net \
--cc=kuznet@ms2.inr.ac.ru \
--cc=linux-kernel@vger.kernel.org \
--cc=luuk.paulussen@alliedtelesis.co.nz \
--cc=netdev@vger.kernel.org \
--cc=nikolay@cumulusnetworks.com \
--cc=stephen@networkplumber.org \
--cc=yoshfuji@linux-ipv6.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).