From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: devel <devel@driverdev.osuosl.org>,
Lidza Louina <lidza.louina@gmail.com>,
driverdev-devel@linuxdriverproject.org,
linux-kernel <linux-kernel@vger.kernel.org>,
Greg KH <gregkh@linuxfoundation.org>
Subject: Re: [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister()
Date: Fri, 13 Jun 2014 17:50:22 +0900 [thread overview]
Message-ID: <CAHb8M2ACpVdjCLMvJir=x1qoG6wJzyzVF9CTVoCzMfnXuN8cDg@mail.gmail.com> (raw)
In-Reply-To: <20140613083846.GY5500@mwanda>
2014-06-13 17:38 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, Jun 13, 2014 at 05:16:27PM +0900, DaeSeok Youn wrote:
>> Hi, Dan
>>
>>
>>
>> 2014-06-13 17:00 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
>> > On Fri, Jun 13, 2014 at 04:41:47PM +0900, Daeseok Youn wrote:
>> >> dgap_tty_unregister() will unregister serial_driver
>> >> and print_driver, and also free related variables.
>> >>
>> >
>> > Introducing a static function without a caller will cause a GCC warning
>> > about unused functions.
>> >
>> > Fold 5,7 and 8 together into one patch. This is still "one thing per
>> > patch" because they can't be done separately.
>> OK. I will do. And then this series of patches will resend, right?
>
> I'm afraid so. New GCC warnings are against the rules even if you fix
> it in a later patch.
>
> Since you're redoing it, can I suggest that patch 8 should just move
> the code to dgap_init_one() and change the dgap_firmware_load()
> prototype and then another patch should add the error handling.
Ok. I will do as your comment.
Thanks.
regards,
Daeseok Youn
>
> regards,
> dan carpenter
prev parent reply other threads:[~2014-06-13 8:50 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-06-13 7:41 [PATCH 5/9] staging: dgap: introduce dgap_tty_unregister() Daeseok Youn
2014-06-13 8:00 ` Dan Carpenter
2014-06-13 8:16 ` DaeSeok Youn
2014-06-13 8:38 ` Dan Carpenter
2014-06-13 8:50 ` DaeSeok Youn [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHb8M2ACpVdjCLMvJir=x1qoG6wJzyzVF9CTVoCzMfnXuN8cDg@mail.gmail.com' \
--to=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=driverdev-devel@linuxdriverproject.org \
--cc=gregkh@linuxfoundation.org \
--cc=lidza.louina@gmail.com \
--cc=linux-kernel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).