From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: Greg KH <gregkh@linuxfoundation.org>,
devel <devel@driverdev.osuosl.org>,
nandini h <nandu.hgowda@gmail.com>,
"sachin.kamat" <sachin.kamat@linaro.org>,
peter.p.waskiewicz.jr@intel.com,
linux-kernel <linux-kernel@vger.kernel.org>,
Himangi Saraogi <himangi774@gmail.com>,
Chekameh Cobbler <fempsci@gmail.com>
Subject: Re: [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c
Date: Fri, 9 May 2014 17:22:18 +0900 [thread overview]
Message-ID: <CAHb8M2AOxLS_nA4BFy2q7+TyyLYxUTmzVULn8dvuR-X2fsET=w@mail.gmail.com> (raw)
In-Reply-To: <20140509075904.GJ26890@mwanda>
2014-05-09 16:59 GMT+09:00 Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, May 09, 2014 at 10:38:43AM +0900, Daeseok Youn wrote:
>> clean up checkpatch.pl warning:
>> WARNING: please no spaces at the start of a line in
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>> This patch includes cleanup for fixing line length.
>>
>
> This patch is super hard to review. Your "line length" fixes include
> moving variable declarations around, deleting comments, getting rid of
> nonsense curly braces. Those are all great but the patch is over a
> thousand lines long and it's difficult to review.
Yes.. I knew that. And sorry about that. but I was really hard to
separate this patch for
fixing coding style. :-(
When I replaced spaces with tabs, it has too many tabs so I cannot leave
that lines on this patch.(and removed curly braces can solve my concern..)
But I should do as your comment.
>
> If you just change spaces to tabs, that takes me 5 seconds to review
> because I have scripts and email macros to do that.
>
> If you just delete the #if 0 blocks that also is easy to review in a
> single patch.
OK. I will make a patch for that.
>
> Just delete all the code that depends on #ifdef RLD_DUMP_BUFDATA because
> that stuff is never set.
I think developer can be set with "#define RLD_DUMP_BUFDATA" for
debugging before
building this module. OK. I will remove that.
>
> Please break this up into smaller patches and also write a better
> changelog.
OK. sorry I will try breaking this up into smaller patches.
It need to take some time for this. :-)
Thanks for review.
Regards,
Daeseok Youn.
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2014-05-09 8:22 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-09 1:38 [PATCH 1/3] staging: cxt1e1: Fix no spaces at the start of a line in musycc.c Daeseok Youn
2014-05-09 7:59 ` Dan Carpenter
2014-05-09 8:22 ` DaeSeok Youn [this message]
2014-05-09 8:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHb8M2AOxLS_nA4BFy2q7+TyyLYxUTmzVULn8dvuR-X2fsET=w@mail.gmail.com' \
--to=daeseok.youn@gmail.com \
--cc=dan.carpenter@oracle.com \
--cc=devel@driverdev.osuosl.org \
--cc=fempsci@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=himangi774@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=nandu.hgowda@gmail.com \
--cc=peter.p.waskiewicz.jr@intel.com \
--cc=sachin.kamat@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).