linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: DaeSeok Youn <daeseok.youn@gmail.com>
To: Dan Carpenter <dan.carpenter@oracle.com>
Cc: gregkh@linuxfoundation.org, himangi774@gmail.com,
	sachin.kamat@linaro.org, fempsci@gmail.com,
	nandu.hgowda@gmail.com, devel@driverdev.osuosl.org,
	linux-kernel@vger.kernel.org
Subject: Re: [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c
Date: Fri, 9 May 2014 23:09:35 +0900	[thread overview]
Message-ID: <CAHb8M2AopFJGhgZOu_hbn2YWvMgeuFz2zK2uYo4Fnt6kACKSOg@mail.gmail.com> (raw)
In-Reply-To: <20140509105149.GH4963@mwanda>

2014-05-09 19:51 GMT+09:00, Dan Carpenter <dan.carpenter@oracle.com>:
> On Fri, May 09, 2014 at 07:06:06PM +0900, Daeseok Youn wrote:
>> Removes "#if 0" blocks.
>>
>> Signed-off-by: Daeseok Youn <daeseok.youn@gmail.com>
>> ---
>> Dan,
>>  I decided to leave musycc_dump_rxbuffer_ring(ch, 0) which is commented
>>  out and make a block as "RLD_DEBUG". Because i think this block need to
>> debug
>>  with define "RLD_DEBUG". If I am wrong, let me know.
>>
>
> This change should maybe have been in a separate patch.  It's a border
> line thing.  But definitely, it should have been mentioned in the
> changelog.
>
> Btw, you can use `git citool` to add or remove lines from a
> commit.  Highlight and right click on the lines you want to add or
> remove.
Thanks for the tip. I used "git add -p" after "git rebase" and "git
reset HEAD" for
spliting a patch.
But I have a question, Do I have to resend rest of patches after
spliting this patch?
In this case, 2/5 is splited to two, it doesn't need to rebase but
numbering of patches are changed.

>
> I don't really care either way if you keep it or delete it.
Ok. I will leave this.

Thanks for review.

Regards,
Daeseok Youn

>
> regards,
> dan carpenter
>
>

  reply	other threads:[~2014-05-09 14:09 UTC|newest]

Thread overview: 5+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-05-09 10:06 [PATCH 2/5] staging: cxt1e1: remove dead code in musycc.c Daeseok Youn
2014-05-09 10:51 ` Dan Carpenter
2014-05-09 14:09   ` DaeSeok Youn [this message]
2014-05-09 14:15     ` Dan Carpenter
2014-05-09 14:25       ` DaeSeok Youn

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=CAHb8M2AopFJGhgZOu_hbn2YWvMgeuFz2zK2uYo4Fnt6kACKSOg@mail.gmail.com \
    --to=daeseok.youn@gmail.com \
    --cc=dan.carpenter@oracle.com \
    --cc=devel@driverdev.osuosl.org \
    --cc=fempsci@gmail.com \
    --cc=gregkh@linuxfoundation.org \
    --cc=himangi774@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=nandu.hgowda@gmail.com \
    --cc=sachin.kamat@linaro.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).