From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S965552AbcCJKGs (ORCPT ); Thu, 10 Mar 2016 05:06:48 -0500 Received: from mail-vk0-f66.google.com ([209.85.213.66]:33302 "EHLO mail-vk0-f66.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S965429AbcCJKGe (ORCPT ); Thu, 10 Mar 2016 05:06:34 -0500 MIME-Version: 1.0 In-Reply-To: <1457598119-7149-1-git-send-email-tanvisurana20@gmail.com> References: <1457598119-7149-1-git-send-email-tanvisurana20@gmail.com> Date: Thu, 10 Mar 2016 19:06:32 +0900 Message-ID: Subject: Re: [PATCH 2/2] Staging: dgap: modified the block comments From: DaeSeok Youn To: Tanvi Surana Cc: devel , linux-kernel Content-Type: text/plain; charset=UTF-8 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org 2016-03-10 17:21 GMT+09:00 Tanvi Surana : > I have modified the file dgap.c ,making changes to the multiline comments,thus making them appear presentable > > Signed-Off-By: Tanvi Surana > --- > drivers/staging/dgap/dgap.c | 59 +++++++++++++++++++++++++-------------------- > 1 file changed, 33 insertions(+), 26 deletions(-) > > diff --git a/drivers/staging/dgap/dgap.c b/drivers/staging/dgap/dgap.c > index bad3551..deff2c4 100644 > --- a/drivers/staging/dgap/dgap.c > +++ b/drivers/staging/dgap/dgap.c > @@ -91,22 +91,22 @@ static uint dgap_poll_stop; /* Used to tell poller to stop */ > static struct timer_list dgap_poll_timer; > > /* > - SUPPORTED PRODUCTS > - > - Card Model Number of Ports Interface > - ---------------------------------------------------------------- > - Acceleport Xem 4 - 64 (EIA232 & EIA422) > - Acceleport Xr 4 & 8 (EIA232) > - Acceleport Xr 920 4 & 8 (EIA232) > - Acceleport C/X 8 - 128 (EIA232) > - Acceleport EPC/X 8 - 224 (EIA232) > - Acceleport Xr/422 4 & 8 (EIA422) > - Acceleport 2r/920 2 (EIA232) > - Acceleport 4r/920 4 (EIA232) > - Acceleport 8r/920 8 (EIA232) > - > - IBM 8-Port Asynchronous PCI Adapter (EIA232) > - IBM 128-Port Asynchronous PCI Adapter (EIA232 & EIA422) > + SUPPORTED PRODUCTS > + > + Card Model Number of Ports Interface > + ---------------------------------------------------------------- > + Acceleport Xem 4 - 64 (EIA232 & EIA422) > + Acceleport Xr 4 & 8 (EIA232) > + Acceleport Xr 920 4 & 8 (EIA232) > + Acceleport C/X 8 - 128 (EIA232) > + Acceleport EPC/X 8 - 224 (EIA232) > + Acceleport Xr/422 4 & 8 (EIA422) > + Acceleport 2r/920 2 (EIA232) > + Acceleport 4r/920 4 (EIA232) > + Acceleport 8r/920 8 (EIA232) > + > + IBM 8-Port Asynchronous PCI Adapter (EIA232) > + IBM 128-Port Asynchronous PCI Adapter (EIA232 & EIA422) > */ > > static struct pci_device_id dgap_pci_tbl[] = { > @@ -1465,7 +1465,8 @@ static void dgap_parity_scan(struct channel_t *ch, unsigned char *cbuf, > * > * ch - Pointer to channel structure. > * > - *=======================================================================*/ > + *======================================================================= > + */ > > static void dgap_input(struct channel_t *ch) > { > @@ -1694,7 +1695,8 @@ static void dgap_write_wakeup(struct board_t *bd, struct channel_t *ch, > /************************************************************************ > * Determines when CARRIER changes state and takes appropriate > * action. > - ************************************************************************/ > + *********************************************************************** > + */ > static void dgap_carrier(struct channel_t *ch) > { > struct board_t *bd; > @@ -2339,7 +2341,8 @@ schedule_poller: > * ncmds - Wait until ncmds or fewer cmds are left > * in the cmd buffer before returning. > * > - *=======================================================================*/ > + *======================================================================= > + */ > static void dgap_cmdb(struct channel_t *ch, u8 cmd, u8 byte1, > u8 byte2, uint ncmds) > { > @@ -2424,7 +2427,8 @@ static void dgap_cmdb(struct channel_t *ch, u8 cmd, u8 byte1, > * ncmds - Wait until ncmds or fewer cmds are left > * in the cmd buffer before returning. > * > - *=======================================================================*/ > + *======================================================================= > + */ > static void dgap_cmdw(struct channel_t *ch, u8 cmd, u16 word, uint ncmds) > { > char __iomem *vaddr; > @@ -2506,7 +2510,8 @@ static void dgap_cmdw(struct channel_t *ch, u8 cmd, u16 word, uint ncmds) > * ncmds - Wait until ncmds or fewer cmds are left > * in the cmd buffer before returning. > * > - *=======================================================================*/ > + *======================================================================= > + */ > static void dgap_cmdw_ext(struct channel_t *ch, u16 cmd, u16 word, uint ncmds) > { > char __iomem *vaddr; > @@ -2598,7 +2603,8 @@ static void dgap_cmdw_ext(struct channel_t *ch, u16 cmd, u16 word, uint ncmds) > * buf - Pointer to characters to be moved. > * cnt - Number of characters to move. > * > - *=======================================================================*/ > + *======================================================================= > + */ > static void dgap_wmove(struct channel_t *ch, char *buf, uint cnt) > { > int n; > @@ -2680,7 +2686,8 @@ static void dgap_firmware_reset_port(struct channel_t *ch) > * > * struct tty_struct * - TTY for port. > * > - *=======================================================================*/ > + *======================================================================= > + */ > static int dgap_param(struct channel_t *ch, struct board_t *bd, u32 un_type) > { > u16 head; > @@ -4819,11 +4826,10 @@ static int dgap_tty_ioctl(struct tty_struct *tty, unsigned int cmd, > > case TCSBRKP: > /* support for POSIX tcsendbreak() > - > * According to POSIX.1 spec (7.2.2.1.2) breaks should be > * between 0.25 and 0.5 seconds so we'll ask for something > * in the middle: 0.375 seconds. > - */ > + */ > rc = tty_check_change(tty); > spin_unlock_irqrestore(&ch->ch_lock, lock_flags2); > spin_unlock_irqrestore(&bd->bd_lock, lock_flags); > @@ -7023,7 +7029,8 @@ failed_class: > * > * Driver load/unload functions > * > - ************************************************************************/ > + ************************************************************************ > + */ > > /* > * init_module() > -- > 1.9.1 > Hi Tanvi, This driver was removed in linux-next branch. You can see the last commit of this driver. http://git.kernel.org/cgit/linux/kernel/git/next/linux-next.git/commit/?id=7e3933df9874b70745548ce9177295d11c58fc21 Thanks. Regards, Daeseok.