* [PATCH v2 0/3] arm: dts: zynq: improvements and cleanup
@ 2018-07-06 6:01 Luis Araneda
2018-07-06 6:01 ` [PATCH v2 1/3] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards Luis Araneda
` (2 more replies)
0 siblings, 3 replies; 6+ messages in thread
From: Luis Araneda @ 2018-07-06 6:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Michal Simek
Cc: devicetree, linux-arm-kernel, linux-kernel, Luis Araneda
This series attempts to standardize device naming and improve
its information for better identification
The values of the "compatible" and "model" device-tree properties
are corrected for some devices, adding complementary information
when necessary
Changes since v1 (RFC):
- Add values to compatible property instead of replacing them
- Don't remove "internal" word from Xilinx boards on dt-bindings
- Migrate content of adapteva dt-binding file into Xilinx's
- Sort additional compatible strings alphabetically
by manufacturer
- Dropped patch that renamed the zedboard development board
(no apparent benefit)
- Dropped the patch that removed the "zynq" value from the
compatible strings (breaks the ABI)
Luis Araneda (3):
arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed
boards
dt-bindings: xilinx: Add missing zynq boards and sort entries
arm: dts: zynq: correct and improve the model property of dt files
.../devicetree/bindings/arm/adapteva.txt | 7 -----
.../devicetree/bindings/arm/xilinx.txt | 30 +++++++++++++++----
arch/arm/boot/dts/zynq-cc108.dts | 2 +-
arch/arm/boot/dts/zynq-microzed.dts | 4 +--
arch/arm/boot/dts/zynq-parallella.dts | 2 +-
arch/arm/boot/dts/zynq-zc702.dts | 2 +-
arch/arm/boot/dts/zynq-zc706.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm010.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm011.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm012.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm013.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 4 +--
arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
arch/arm/boot/dts/zynq-zybo.dts | 2 +-
14 files changed, 39 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt
--
2.18.0
^ permalink raw reply [flat|nested] 6+ messages in thread
* [PATCH v2 1/3] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards
2018-07-06 6:01 [PATCH v2 0/3] arm: dts: zynq: improvements and cleanup Luis Araneda
@ 2018-07-06 6:01 ` Luis Araneda
2018-07-06 6:01 ` [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries Luis Araneda
2018-07-06 6:01 ` [PATCH v2 3/3] arm: dts: zynq: correct and improve the model property of dt files Luis Araneda
2 siblings, 0 replies; 6+ messages in thread
From: Luis Araneda @ 2018-07-06 6:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Michal Simek
Cc: devicetree, linux-arm-kernel, linux-kernel, Luis Araneda
Both boards are made by Avnet, Inc. So add an additional
value to the compatible property
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
---
Changes since v1 (RFC):
- Add values to compatible property instead of replacing them
arch/arm/boot/dts/zynq-microzed.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/zynq-microzed.dts b/arch/arm/boot/dts/zynq-microzed.dts
index aa4a0b6defb8..574ef2276182 100644
--- a/arch/arm/boot/dts/zynq-microzed.dts
+++ b/arch/arm/boot/dts/zynq-microzed.dts
@@ -8,7 +8,7 @@
/ {
model = "Zynq MicroZED Development Board";
- compatible = "xlnx,zynq-microzed", "xlnx,zynq-7000";
+ compatible = "avnet,zynq-microzed", "xlnx,zynq-microzed", "xlnx,zynq-7000";
aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-zed.dts b/arch/arm/boot/dts/zynq-zed.dts
index 53c6883ce1f6..595022487965 100644
--- a/arch/arm/boot/dts/zynq-zed.dts
+++ b/arch/arm/boot/dts/zynq-zed.dts
@@ -8,7 +8,7 @@
/ {
model = "Zynq Zed Development Board";
- compatible = "xlnx,zynq-zed", "xlnx,zynq-7000";
+ compatible = "avnet,zynq-zed", "xlnx,zynq-zed", "xlnx,zynq-7000";
aliases {
ethernet0 = &gem0;
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries
2018-07-06 6:01 [PATCH v2 0/3] arm: dts: zynq: improvements and cleanup Luis Araneda
2018-07-06 6:01 ` [PATCH v2 1/3] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards Luis Araneda
@ 2018-07-06 6:01 ` Luis Araneda
2018-07-09 8:18 ` Michal Simek
2018-07-06 6:01 ` [PATCH v2 3/3] arm: dts: zynq: correct and improve the model property of dt files Luis Araneda
2 siblings, 1 reply; 6+ messages in thread
From: Luis Araneda @ 2018-07-06 6:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Michal Simek
Cc: devicetree, linux-arm-kernel, linux-kernel, Luis Araneda
The bindings were missing when adding the device-tree files
Also, improve description of existing boards, sort them
alphabetically by manufacturer, and migrate the contents
of adapteva dt dindigns into Xilinx's
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
---
Changes since v1 (RFC):
- Don't remove "internal" word from Xilinx boards on dt-bindings
- Migrate content of adapteva dt-binding file into Xilinx's
- Sort additional compatible strings alphabetically
by manufacturer
.../devicetree/bindings/arm/adapteva.txt | 7 -----
.../devicetree/bindings/arm/xilinx.txt | 30 +++++++++++++++----
2 files changed, 25 insertions(+), 12 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt
diff --git a/Documentation/devicetree/bindings/arm/adapteva.txt b/Documentation/devicetree/bindings/arm/adapteva.txt
deleted file mode 100644
index 1d8af9e36065..000000000000
--- a/Documentation/devicetree/bindings/arm/adapteva.txt
+++ /dev/null
@@ -1,7 +0,0 @@
-Adapteva Platforms Device Tree Bindings
----------------------------------------
-
-Parallella board
-
-Required root node properties:
- - compatible = "adapteva,parallella";
diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
index b9043bc35c14..26fe5ecc4332 100644
--- a/Documentation/devicetree/bindings/arm/xilinx.txt
+++ b/Documentation/devicetree/bindings/arm/xilinx.txt
@@ -8,18 +8,38 @@ Required root node properties:
Additional compatible strings:
-- Xilinx internal board cc108
+- Adapteva Parallella board
+ "adapteva,parallella"
+
+- Avnet MicroZed board
+ "avnet,zynq-microzed"
+ "xlnx,zynq-microzed"
+
+- Avnet ZedBoard board
+ "avnet,zynq-zed"
+ "xlnx,zynq-zed"
+
+- Digilent Zybo board
+ "digilent,zynq-zybo"
+
+- Digilent Zybo Z7 board
+ "digilent,zynq-zybo-z7"
+
+- Xilinx CC108 internal board
"xlnx,zynq-cc108"
-- Xilinx internal board zc770 with different FMC cards
+- Xilinx ZC702 internal board
+ "xlnx,zynq-zc702"
+
+- Xilinx ZC706 internal board
+ "xlnx,zynq-zc706"
+
+- Xilinx ZC770 internal board, with different FMC cards
"xlnx,zynq-zc770-xm010"
"xlnx,zynq-zc770-xm011"
"xlnx,zynq-zc770-xm012"
"xlnx,zynq-zc770-xm013"
-- Digilent Zybo Z7 board
- "digilent,zynq-zybo-z7"
-
---------------------------------------------------------------
Xilinx Zynq UltraScale+ MPSoC Platforms Device Tree Bindings
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* [PATCH v2 3/3] arm: dts: zynq: correct and improve the model property of dt files
2018-07-06 6:01 [PATCH v2 0/3] arm: dts: zynq: improvements and cleanup Luis Araneda
2018-07-06 6:01 ` [PATCH v2 1/3] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards Luis Araneda
2018-07-06 6:01 ` [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries Luis Araneda
@ 2018-07-06 6:01 ` Luis Araneda
2 siblings, 0 replies; 6+ messages in thread
From: Luis Araneda @ 2018-07-06 6:01 UTC (permalink / raw)
To: Rob Herring, Mark Rutland, Michal Simek
Cc: devicetree, linux-arm-kernel, linux-kernel, Luis Araneda
Replace the current value of the model property by a more accurate
description of each board (which includes the manufacturer), as some
of the boards had the same value ("Xilinx Zynq")
Signed-off-by: Luis Araneda <luaraneda@gmail.com>
---
Changes since v1 (RFC):
- No changes
arch/arm/boot/dts/zynq-cc108.dts | 2 +-
arch/arm/boot/dts/zynq-microzed.dts | 2 +-
arch/arm/boot/dts/zynq-parallella.dts | 2 +-
arch/arm/boot/dts/zynq-zc702.dts | 2 +-
arch/arm/boot/dts/zynq-zc706.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm010.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm011.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm012.dts | 2 +-
arch/arm/boot/dts/zynq-zc770-xm013.dts | 2 +-
arch/arm/boot/dts/zynq-zed.dts | 2 +-
arch/arm/boot/dts/zynq-zybo-z7.dts | 2 +-
arch/arm/boot/dts/zynq-zybo.dts | 2 +-
12 files changed, 12 insertions(+), 12 deletions(-)
diff --git a/arch/arm/boot/dts/zynq-cc108.dts b/arch/arm/boot/dts/zynq-cc108.dts
index 1a0f631c1d8d..8b9ab9bba23b 100644
--- a/arch/arm/boot/dts/zynq-cc108.dts
+++ b/arch/arm/boot/dts/zynq-cc108.dts
@@ -12,8 +12,8 @@
/include/ "zynq-7000.dtsi"
/ {
+ model = "Xilinx CC108 board";
compatible = "xlnx,zynq-cc108", "xlnx,zynq-7000";
- model = "Xilinx Zynq";
aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-microzed.dts b/arch/arm/boot/dts/zynq-microzed.dts
index 574ef2276182..6ed84fb15902 100644
--- a/arch/arm/boot/dts/zynq-microzed.dts
+++ b/arch/arm/boot/dts/zynq-microzed.dts
@@ -7,7 +7,7 @@
/include/ "zynq-7000.dtsi"
/ {
- model = "Zynq MicroZED Development Board";
+ model = "Avnet MicroZed board";
compatible = "avnet,zynq-microzed", "xlnx,zynq-microzed", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-parallella.dts b/arch/arm/boot/dts/zynq-parallella.dts
index c05f4b67d4c1..54592aeb92b9 100644
--- a/arch/arm/boot/dts/zynq-parallella.dts
+++ b/arch/arm/boot/dts/zynq-parallella.dts
@@ -12,7 +12,7 @@
/include/ "zynq-7000.dtsi"
/ {
- model = "Adapteva Parallella Board";
+ model = "Adapteva Parallella board";
compatible = "adapteva,parallella", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-zc702.dts b/arch/arm/boot/dts/zynq-zc702.dts
index f2330b0cb63d..3f84b94db995 100644
--- a/arch/arm/boot/dts/zynq-zc702.dts
+++ b/arch/arm/boot/dts/zynq-zc702.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"
/ {
- model = "Zynq ZC702 Development Board";
+ model = "Xilinx ZC702 board";
compatible = "xlnx,zynq-zc702", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-zc706.dts b/arch/arm/boot/dts/zynq-zc706.dts
index 3ad1260ff2a1..a15908cacbcf 100644
--- a/arch/arm/boot/dts/zynq-zc706.dts
+++ b/arch/arm/boot/dts/zynq-zc706.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"
/ {
- model = "Zynq ZC706 Development Board";
+ model = "Xilinx ZC706 board";
compatible = "xlnx,zynq-zc706", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-zc770-xm010.dts b/arch/arm/boot/dts/zynq-zc770-xm010.dts
index 6884f1ad66b7..0e1bfdd3421f 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm010.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm010.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"
/ {
+ model = "Xilinx ZC770 XM010 board";
compatible = "xlnx,zynq-zc770-xm010", "xlnx,zynq-7000";
- model = "Xilinx Zynq";
aliases {
ethernet0 = &gem0;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm011.dts b/arch/arm/boot/dts/zynq-zc770-xm011.dts
index b78883cee96a..b7f65862c022 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm011.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm011.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"
/ {
+ model = "Xilinx ZC770 XM011 board";
compatible = "xlnx,zynq-zc770-xm011", "xlnx,zynq-7000";
- model = "Xilinx Zynq";
aliases {
i2c0 = &i2c1;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm012.dts b/arch/arm/boot/dts/zynq-zc770-xm012.dts
index c3169d63600d..d2359b789eb8 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm012.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm012.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"
/ {
+ model = "Xilinx ZC770 XM012 board";
compatible = "xlnx,zynq-zc770-xm012", "xlnx,zynq-7000";
- model = "Xilinx Zynq";
aliases {
i2c0 = &i2c0;
diff --git a/arch/arm/boot/dts/zynq-zc770-xm013.dts b/arch/arm/boot/dts/zynq-zc770-xm013.dts
index 8bb66859d774..651913f1afa2 100644
--- a/arch/arm/boot/dts/zynq-zc770-xm013.dts
+++ b/arch/arm/boot/dts/zynq-zc770-xm013.dts
@@ -8,8 +8,8 @@
#include "zynq-7000.dtsi"
/ {
+ model = "Xilinx ZC770 XM013 board";
compatible = "xlnx,zynq-zc770-xm013", "xlnx,zynq-7000";
- model = "Xilinx Zynq";
aliases {
ethernet0 = &gem1;
diff --git a/arch/arm/boot/dts/zynq-zed.dts b/arch/arm/boot/dts/zynq-zed.dts
index 595022487965..3a4ae51ca4da 100644
--- a/arch/arm/boot/dts/zynq-zed.dts
+++ b/arch/arm/boot/dts/zynq-zed.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"
/ {
- model = "Zynq Zed Development Board";
+ model = "Avnet ZedBoard board";
compatible = "avnet,zynq-zed", "xlnx,zynq-zed", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-zybo-z7.dts b/arch/arm/boot/dts/zynq-zybo-z7.dts
index 1e713dc98920..be40be9b7222 100644
--- a/arch/arm/boot/dts/zynq-zybo-z7.dts
+++ b/arch/arm/boot/dts/zynq-zybo-z7.dts
@@ -3,7 +3,7 @@
#include "zynq-7000.dtsi"
/ {
- model = "Zynq ZYBO Z7 Development Board";
+ model = "Digilent Zybo Z7 board";
compatible = "digilent,zynq-zybo-z7", "xlnx,zynq-7000";
aliases {
diff --git a/arch/arm/boot/dts/zynq-zybo.dts b/arch/arm/boot/dts/zynq-zybo.dts
index a6c00e7fa767..0439e9f1ea6f 100644
--- a/arch/arm/boot/dts/zynq-zybo.dts
+++ b/arch/arm/boot/dts/zynq-zybo.dts
@@ -7,7 +7,7 @@
#include "zynq-7000.dtsi"
/ {
- model = "Zynq ZYBO Development Board";
+ model = "Digilent Zybo board";
compatible = "digilent,zynq-zybo", "xlnx,zynq-7000";
aliases {
--
2.18.0
^ permalink raw reply related [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries
2018-07-06 6:01 ` [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries Luis Araneda
@ 2018-07-09 8:18 ` Michal Simek
2018-07-09 14:17 ` Luis Araneda
0 siblings, 1 reply; 6+ messages in thread
From: Michal Simek @ 2018-07-09 8:18 UTC (permalink / raw)
To: Luis Araneda, Rob Herring, Mark Rutland, Michal Simek
Cc: devicetree, linux-arm-kernel, linux-kernel
On 6.7.2018 08:01, Luis Araneda wrote:
> The bindings were missing when adding the device-tree files
>
> Also, improve description of existing boards, sort them
> alphabetically by manufacturer, and migrate the contents
> of adapteva dt dindigns into Xilinx's
>
> Signed-off-by: Luis Araneda <luaraneda@gmail.com>
> ---
>
> Changes since v1 (RFC):
> - Don't remove "internal" word from Xilinx boards on dt-bindings
> - Migrate content of adapteva dt-binding file into Xilinx's
> - Sort additional compatible strings alphabetically
> by manufacturer
>
> .../devicetree/bindings/arm/adapteva.txt | 7 -----
> .../devicetree/bindings/arm/xilinx.txt | 30 +++++++++++++++----
> 2 files changed, 25 insertions(+), 12 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/arm/adapteva.txt
>
> diff --git a/Documentation/devicetree/bindings/arm/adapteva.txt b/Documentation/devicetree/bindings/arm/adapteva.txt
> deleted file mode 100644
> index 1d8af9e36065..000000000000
> --- a/Documentation/devicetree/bindings/arm/adapteva.txt
> +++ /dev/null
> @@ -1,7 +0,0 @@
> -Adapteva Platforms Device Tree Bindings
> ----------------------------------------
> -
> -Parallella board
> -
> -Required root node properties:
> - - compatible = "adapteva,parallella";
> diff --git a/Documentation/devicetree/bindings/arm/xilinx.txt b/Documentation/devicetree/bindings/arm/xilinx.txt
> index b9043bc35c14..26fe5ecc4332 100644
> --- a/Documentation/devicetree/bindings/arm/xilinx.txt
> +++ b/Documentation/devicetree/bindings/arm/xilinx.txt
> @@ -8,18 +8,38 @@ Required root node properties:
>
> Additional compatible strings:
>
> -- Xilinx internal board cc108
> +- Adapteva Parallella board
> + "adapteva,parallella"
> +
> +- Avnet MicroZed board
> + "avnet,zynq-microzed"
> + "xlnx,zynq-microzed"
> +
> +- Avnet ZedBoard board
> + "avnet,zynq-zed"
> + "xlnx,zynq-zed"
> +
> +- Digilent Zybo board
> + "digilent,zynq-zybo"
> +
> +- Digilent Zybo Z7 board
> + "digilent,zynq-zybo-z7"
> +
> +- Xilinx CC108 internal board
> "xlnx,zynq-cc108"
>
> -- Xilinx internal board zc770 with different FMC cards
> +- Xilinx ZC702 internal board
> + "xlnx,zynq-zc702"
> +
> +- Xilinx ZC706 internal board
> + "xlnx,zynq-zc706"
> +
> +- Xilinx ZC770 internal board, with different FMC cards
> "xlnx,zynq-zc770-xm010"
> "xlnx,zynq-zc770-xm011"
> "xlnx,zynq-zc770-xm012"
> "xlnx,zynq-zc770-xm013"
>
> -- Digilent Zybo Z7 board
> - "digilent,zynq-zybo-z7"
> -
> ---------------------------------------------------------------
>
> Xilinx Zynq UltraScale+ MPSoC Platforms Device Tree Bindings
>
Please do it with more patches. There are 3 changes in one patch.
Thanks,
Michal
^ permalink raw reply [flat|nested] 6+ messages in thread
* Re: [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries
2018-07-09 8:18 ` Michal Simek
@ 2018-07-09 14:17 ` Luis Araneda
0 siblings, 0 replies; 6+ messages in thread
From: Luis Araneda @ 2018-07-09 14:17 UTC (permalink / raw)
To: Michal Simek
Cc: Rob Herring, Mark Rutland, devicetree, linux-arm-kernel, linux-kernel
Hi Michal,
On Mon, Jul 9, 2018 at 4:18 AM Michal Simek <michal.simek@xilinx.com> wrote:
> Please do it with more patches. There are 3 changes in one patch.
Ok, I'll split it into 3 different patches on v3.
Thanks,
Luis Araneda.
^ permalink raw reply [flat|nested] 6+ messages in thread
end of thread, other threads:[~2018-07-09 14:17 UTC | newest]
Thread overview: 6+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2018-07-06 6:01 [PATCH v2 0/3] arm: dts: zynq: improvements and cleanup Luis Araneda
2018-07-06 6:01 ` [PATCH v2 1/3] arm: dts: zynq: Set correct manufacturer for ZedBoard and MicroZed boards Luis Araneda
2018-07-06 6:01 ` [PATCH v2 2/3] dt-bindings: xilinx: Add missing zynq boards and sort entries Luis Araneda
2018-07-09 8:18 ` Michal Simek
2018-07-09 14:17 ` Luis Araneda
2018-07-06 6:01 ` [PATCH v2 3/3] arm: dts: zynq: correct and improve the model property of dt files Luis Araneda
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).