From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-12.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 952CAC433C1 for ; Tue, 23 Mar 2021 17:47:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 64B9261931 for ; Tue, 23 Mar 2021 17:47:28 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230480AbhCWRq5 (ORCPT ); Tue, 23 Mar 2021 13:46:57 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:35630 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231131AbhCWRqw (ORCPT ); Tue, 23 Mar 2021 13:46:52 -0400 Received: from mail-ej1-x629.google.com (mail-ej1-x629.google.com [IPv6:2a00:1450:4864:20::629]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 0E727C061574 for ; Tue, 23 Mar 2021 10:46:52 -0700 (PDT) Received: by mail-ej1-x629.google.com with SMTP id u9so28519671ejj.7 for ; Tue, 23 Mar 2021 10:46:51 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=Ql4xcjbxDiQewQBjoY2RWA9a9mOAjHNHjjlKvX5iKME=; b=ImQ/kiWhqm2FHjRW4oVru2YORFDIcuEufuObYX9u2FjTzqYgYl6/r+JWf6xVtdTz2u 7AU6abiSQGDTT7olhxvb6fgkSt7EelRi/m7lBYnOoYzmq+N6bwBvzfhamelCfOTKlKle 94UAtK9vvgLBgLB2JkZPoTsTnbiIp05/3xP8smzwihxYVzAP+gS/E9HrRpzqNq8onYCH N6xrpljENJkRbmx++O8szjm5Yptf9M+IQ5PegIQH8voLWKR9AW3xgdeoauIT7JLEsOJd 9eLo41s0uq/w0dFZVtNXmypUl0lDG4ZDlWSDdKAzbnjDG9q0qgF2pnf6fVPUNs6NuRIx gkyg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=Ql4xcjbxDiQewQBjoY2RWA9a9mOAjHNHjjlKvX5iKME=; b=At7eASmTDOlYwl/37F7N4O/HldPMEEyNv87qJypvAeZgd4q0eQARxkeHV5qLyq5NPF d13RawDwlVSb0PF4QFe5Ric7LCwXKKNYMFBObUDdtxU3YKnQ0mHu/pTklMk7qKSpmwIg 0w9ivxkHQE5Bck3G5UrK3pYiXhPfeTpUQxkqsmISV1LRDf7OQNg/gf0eYDzQ591bxJau 7o8bsMKrTLQOEnL2lJ/A8hdGNHtfnch3tGihIjbAtF1U7NF0OzP/sYlLwTI1gVenQv+a aXwhVoHjosX5cdmI2jlFsOj6sWrCJn/cemvoeN+S+y4TUT94tBjIaqJtZBLAc/0AWmy6 3hMg== X-Gm-Message-State: AOAM5320wNRD1cGYVCW8IrdYcbeX8cSMieh/1Fa1zoLMZTHBexiUcwRe f8hgzQyyXasU/5QXo6xUInygLc1iFXovW2hHzk8= X-Google-Smtp-Source: ABdhPJxzFOGovvGm7xPD0TAOzpfYJ7X7k6cVcDxxZ6cFVl+Mf2WmiyLIAIKDWgQsgMBVjCyZho29t1+GVrcC1UKB3GE= X-Received: by 2002:a17:906:bcfc:: with SMTP id op28mr6035782ejb.238.1616521610786; Tue, 23 Mar 2021 10:46:50 -0700 (PDT) MIME-Version: 1.0 References: <20210323135405.65059-1-linmiaohe@huawei.com> <20210323135405.65059-3-linmiaohe@huawei.com> In-Reply-To: <20210323135405.65059-3-linmiaohe@huawei.com> From: Yang Shi Date: Tue, 23 Mar 2021 10:46:39 -0700 Message-ID: Subject: Re: [PATCH v2 2/5] mm/migrate.c: remove unnecessary rc != MIGRATEPAGE_SUCCESS check in 'else' case To: Miaohe Lin Cc: Andrew Morton , Jerome Glisse , Rafael Aquini , David Hildenbrand , Alistair Popple , Linux Kernel Mailing List , Linux MM Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Mar 23, 2021 at 6:54 AM Miaohe Lin wrote: > > It's guaranteed that in the 'else' case of the rc == MIGRATEPAGE_SUCCESS > check, rc does not equal to MIGRATEPAGE_SUCCESS. Remove this unnecessary > check. Reviewed-by: Yang Shi > > Reviewed-by: David Hildenbrand > Signed-off-by: Miaohe Lin > --- > mm/migrate.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/mm/migrate.c b/mm/migrate.c > index facec65c7374..97da1fabdf72 100644 > --- a/mm/migrate.c > +++ b/mm/migrate.c > @@ -1374,7 +1374,7 @@ static int unmap_and_move_huge_page(new_page_t get_new_page, > out: > if (rc == MIGRATEPAGE_SUCCESS) > putback_active_hugepage(hpage); > - else if (rc != -EAGAIN && rc != MIGRATEPAGE_SUCCESS) > + else if (rc != -EAGAIN) > list_move_tail(&hpage->lru, ret); > > /* > -- > 2.19.1 >