From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-7.7 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FORGED_FROMDOMAIN,FREEMAIL_FROM, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CD7C1C433E0 for ; Wed, 10 Feb 2021 17:00:30 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9A5DA64E7D for ; Wed, 10 Feb 2021 17:00:30 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S233206AbhBJRAK (ORCPT ); Wed, 10 Feb 2021 12:00:10 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232724AbhBJQ7o (ORCPT ); Wed, 10 Feb 2021 11:59:44 -0500 Received: from mail-ej1-x62e.google.com (mail-ej1-x62e.google.com [IPv6:2a00:1450:4864:20::62e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 2E40EC061574; Wed, 10 Feb 2021 08:59:05 -0800 (PST) Received: by mail-ej1-x62e.google.com with SMTP id jj19so5463110ejc.4; Wed, 10 Feb 2021 08:59:05 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=CZixN6Q/4ReK9YtVCNtVo5cDo+F6iIEK6tabVtfOzxo=; b=Rq7xCOotKS9ZpLJt7mztI4zaEi7hNGUIkviW+Rh0IHqkEftTg4Ao0h6MELWhz+xcle E/IQHaPwkqKKu+ymFzsU/pg7WI73tsddPelKXby+JVgt6OqjmwceDddIBPMHgon1b03Q qHTO7RokQtGa7vNbp0aeyyzJxbXVgnajTj15dyvyECpv90PceOJQfRNPbbmejRzarwzE Psq8DugOhJXTH2BgccoDMJFjNiNE6oGWSUvxiwUdz//D8rjrttPMQvRT0ymwXslFOuNW qXJ+2wwE0WtTjTh0mJlvxBF6dd9HZ1bftTrQAWLbAAzuKmFoqoQhJvUZDiApiThkQyK2 MexA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=CZixN6Q/4ReK9YtVCNtVo5cDo+F6iIEK6tabVtfOzxo=; b=orRGJTqfiolbPzJtvPNrsp9CQDz1PuFrxuZgLh3tAKtzqk0jUlLfC+ku5oijIpJB10 vBVl4TLvRCpwGsfnKEd0og9c0bwXzYwL834dqp2QfPNO/eScVBzo1OwaX7AkT4ePos8M yEXSiVlJTDU9eTGIVgN267kvbXW2G2mEwEdBpuRt3b7K6AboJVWPVqNIkMTpLVJUAW4r O4eSuOFwOLsIgewGuNW7FAa8Vn1Kih4RaBbD2MSpGe9IwisBKr8uwfkeWLTs8CSip8hc HaWRRT6kgymDCUNwVKsU47hnXey1CIl2L++yBhcHS8jpFwbhVZVdvaVZTOj1/CZXaJNJ 96KQ== X-Gm-Message-State: AOAM533PRZS/F6Hzx8EkyWz34nrAn96kkvOmYc29R+TP+x6vnd6A6Uu3 nh9koHeqXluBhlKMPJd2czgsUY997ns9073tGoo= X-Google-Smtp-Source: ABdhPJyOUgWmInD4qVcgQuWqw8PD0zsXXPLcq6zX4rspY74T4IQSbdnnewUZt7QWQDAqh4rzLc+HPrDLiAWQqIA/5yM= X-Received: by 2002:a17:906:755:: with SMTP id z21mr3949721ejb.514.1612976343938; Wed, 10 Feb 2021 08:59:03 -0800 (PST) MIME-Version: 1.0 References: <20210209174646.1310591-1-shy828301@gmail.com> <20210209174646.1310591-2-shy828301@gmail.com> In-Reply-To: From: Yang Shi Date: Wed, 10 Feb 2021 08:58:52 -0800 Message-ID: Subject: Re: [v7 PATCH 01/12] mm: vmscan: use nid from shrink_control for tracepoint To: Shakeel Butt Cc: Roman Gushchin , Kirill Tkhai , Vlastimil Babka , Dave Chinner , Johannes Weiner , Michal Hocko , Andrew Morton , Linux MM , linux-fsdevel , LKML Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Tue, Feb 9, 2021 at 11:14 AM Shakeel Butt wrote: > > On Tue, Feb 9, 2021 at 9:47 AM Yang Shi wrote: > > > > The tracepoint's nid should show what node the shrink happens on, the start tracepoint > > uses nid from shrinkctl, but the nid might be set to 0 before end tracepoint if the > > shrinker is not NUMA aware, so the traceing > > tracing Fixed. Thanks. > > > log may show the shrink happens on one > > node but end up on the other node. It seems confusing. And the following patch > > will remove using nid directly in do_shrink_slab(), this patch also helps cleanup > > the code. > > > > Acked-by: Vlastimil Babka > > Acked-by: Kirill Tkhai > > Signed-off-by: Yang Shi > > Reviewed-by: Shakeel Butt