From: Yang Shi <shy828301@gmail.com>
To: Michal Hocko <mhocko@suse.com>
Cc: Yang Li <yang.lee@linux.alibaba.com>,
Johannes Weiner <hannes@cmpxchg.org>,
Vladimir Davydov <vdavydov.dev@gmail.com>,
Andrew Morton <akpm@linux-foundation.org>,
Cgroups <cgroups@vger.kernel.org>, Linux MM <linux-mm@kvack.org>,
Linux Kernel Mailing List <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] mm: memcontrol: fix kernel-doc
Date: Tue, 25 May 2021 09:09:26 -0700 [thread overview]
Message-ID: <CAHbLzkr1rUM7M5uv=LgCQtOngpwg-tUGMj9MUp7CkirDLMSwHw@mail.gmail.com> (raw)
In-Reply-To: <YKy2o2WGRcD7vht8@dhcp22.suse.cz>
On Tue, May 25, 2021 at 1:34 AM Michal Hocko <mhocko@suse.com> wrote:
>
> On Mon 24-05-21 18:24:22, Yang Li wrote:
> > Fix function name in mm/memcontrol.c kernel-doc comment
> > to remove a warning.
> >
> > mm/memcontrol.c:6546: warning: expecting prototype for
> > mem_cgroup_protected(). Prototype was for
> > mem_cgroup_calculate_protection() instead.
> >
> > Reported-by: Abaci Robot <abaci@linux.alibaba.com>
> > Signed-off-by: Yang Li <yang.lee@linux.alibaba.com>
>
> Acked-by: Michal Hocko <mhocko@suse.com>
It seems this has been covered by Mel's W=1 warning cleanup series,
see https://lore.kernel.org/linux-mm/20210520084809.8576-7-mgorman@techsingularity.net/.
>
> Thanks!
>
> > ---
> > mm/memcontrol.c | 2 +-
> > 1 file changed, 1 insertion(+), 1 deletion(-)
> >
> > diff --git a/mm/memcontrol.c b/mm/memcontrol.c
> > index 64ada9e..030c1dc 100644
> > --- a/mm/memcontrol.c
> > +++ b/mm/memcontrol.c
> > @@ -6456,7 +6456,7 @@ static unsigned long effective_protection(unsigned long usage,
> > }
> >
> > /**
> > - * mem_cgroup_protected - check if memory consumption is in the normal range
> > + * mem_cgroup_calculate_protection - check if memory consumption is in the normal range
> > * @root: the top ancestor of the sub-tree being checked
> > * @memcg: the memory cgroup to check
> > *
> > --
> > 1.8.3.1
>
> --
> Michal Hocko
> SUSE Labs
>
prev parent reply other threads:[~2021-05-25 16:09 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-24 10:24 [PATCH] mm: memcontrol: fix kernel-doc Yang Li
2021-05-25 8:34 ` Michal Hocko
2021-05-25 16:09 ` Yang Shi [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHbLzkr1rUM7M5uv=LgCQtOngpwg-tUGMj9MUp7CkirDLMSwHw@mail.gmail.com' \
--to=shy828301@gmail.com \
--cc=akpm@linux-foundation.org \
--cc=cgroups@vger.kernel.org \
--cc=hannes@cmpxchg.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=mhocko@suse.com \
--cc=vdavydov.dev@gmail.com \
--cc=yang.lee@linux.alibaba.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).