From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
        id S933470AbcIULfL (ORCPT <rfc822;w@1wt.eu>);
        Wed, 21 Sep 2016 07:35:11 -0400
Received: from mail-wm0-f67.google.com ([74.125.82.67]:33621 "EHLO
        mail-wm0-f67.google.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
        with ESMTP id S933448AbcIULfG (ORCPT
        <rfc822;linux-kernel@vger.kernel.org>);
        Wed, 21 Sep 2016 07:35:06 -0400
MIME-Version: 1.0
In-Reply-To: <c0ee1dc0-ca47-9d0c-6def-a9a0f1921e62@linux.intel.com>
References: <1471463761-26796-1-git-send-email-cpaul@redhat.com>
 <1471463761-26796-6-git-send-email-cpaul@redhat.com> <CAHbf0-HOLeg6p3K=df3eOk0nuu-FcR63VkMUVUSFKnK4=SJJ5g@mail.gmail.com>
 <c0ee1dc0-ca47-9d0c-6def-a9a0f1921e62@linux.intel.com>
From: Mike Lothian <mike@fireburn.co.uk>
Date: Wed, 21 Sep 2016 12:34:44 +0100
Message-ID: <CAHbf0-H29EeBt9e0zKpbgbM4-AG7L1nP+N7Lf=4UZp3e6R-G2A@mail.gmail.com>
Subject: Re: [PATCH v12 5/7] drm/i915/skl: Ensure pipes with changed wms get
 added to the state
To: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
Cc: Lyude <cpaul@redhat.com>, intel-gfx@lists.freedesktop.org,
        =?UTF-8?B?VmlsbGUgU3lyasOkbMOk?= <ville.syrjala@linux.intel.com>,
        Matt Roper <matthew.d.roper@intel.com>,
        Radhakrishna Sripada <radhakrishna.sripada@intel.com>,
        Maling list - DRI developers 
        <dri-devel@lists.freedesktop.org>,
        Linux Kernel Mailing List <linux-kernel@vger.kernel.org>,
        Hans de Goede <hdegoede@redhat.com>, stable@vger.kernel.org,
        Daniel Vetter <daniel.vetter@intel.com>
Content-Type: text/plain; charset=UTF-8
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org
Content-Transfer-Encoding: 8bit
X-MIME-Autoconverted: from quoted-printable to 8bit by mail.home.local id u8LBZGlg006980

I've raised https://bugs.freedesktop.org/show_bug.cgi?id=97888 I'll
attach the info you requested once I get back to my machine

On 21 September 2016 at 07:56, Maarten Lankhorst
<maarten.lankhorst@linux.intel.com> wrote:
> Hey,
>
> Op 20-09-16 om 20:45 schreef Mike Lothian:
>> Hi
>>
>> I've bisected back to this commit in the drm-intel-nightly branch
>>
>> 05a76d3d6ad1ee9f9814f88949cc9305fc165460 is the first bad commit
>> commit 05a76d3d6ad1ee9f9814f88949cc9305fc165460
>> Author: Lyude <cpaul@redhat.com>
>> Date:   Wed Aug 17 15:55:57 2016 -0400
>>
>>    drm/i915/skl: Ensure pipes with changed wms get added to the state
>>
>>    If we're enabling a pipe, we'll need to modify the watermarks on all
>>    active planes. Since those planes won't be added to the state on
>>    their own, we need to add them ourselves.
>>
>>    Signed-off-by: Lyude <cpaul@redhat.com>
>>    Reviewed-by: Matt Roper <matthew.d.roper@intel.com>
>>    Cc: stable@vger.kernel.org
>>    Cc: Ville Syrjälä <ville.syrjala@linux.intel.com>
>>    Cc: Daniel Vetter <daniel.vetter@intel.com>
>>    Cc: Radhakrishna Sripada <radhakrishna.sripada@intel.com>
>>    Cc: Hans de Goede <hdegoede@redhat.com>
>>    Signed-off-by: Maarten Lankhorst <maarten.lankhorst@linux.intel.com>
>>    Link: http://patchwork.freedesktop.org/patch/msgid/1471463761-26796-6-git-send-email-cpaul@redhat.com
>>
>> The symptoms I'm seeing look like tearing at the top of the screen and
>> it's especially noticeable in Chrome - reverting this commit makes the
>> issue go away
>>
>> Let me know if you'd like me to raise a bug
> Please do so, it's nice to refer to when making a fix for it.
>
> Could you attach the contents of /sys/kernel/debug/dri/0/i915_ddb_info for working and not-working in it?
>
> ~Maarten