From: Li Feng <fengli@smartx.com>
To: Song Liu <song@kernel.org>,
linux-raid@vger.kernel.org,
open list <linux-kernel@vger.kernel.org>
Subject: Re: [PATCH] md: allow to set the fail_fast on RAID1/RAID10
Date: Wed, 15 Sep 2021 23:08:51 +0800 [thread overview]
Message-ID: <CAHckoCyDULok_QLLh5Nmbx4qLCxKL43TgtFgCSAwuaPpRy1BFw@mail.gmail.com> (raw)
In-Reply-To: <20210913032003.2836583-1-fengli@smartx.com>
ping ...
Thanks,
Feng Li
Li Feng <fengli@smartx.com> 于2021年9月13日周一 上午11:22写道:
>
> When the running RAID1/RAID10 need to be set with the fail_fast flag,
> we have to remove each device from RAID and re-add it again with the
> --fail_fast flag.
>
> Export the fail_fast flag to the userspace to support the read and
> write.
>
> Signed-off-by: Li Feng <fengli@smartx.com>
> ---
> drivers/md/md.c | 30 ++++++++++++++++++++++++++++++
> 1 file changed, 30 insertions(+)
>
> diff --git a/drivers/md/md.c b/drivers/md/md.c
> index ae8fe54ea358..ce63972a4555 100644
> --- a/drivers/md/md.c
> +++ b/drivers/md/md.c
> @@ -3583,6 +3583,35 @@ ppl_size_store(struct md_rdev *rdev, const char *buf, size_t len)
> static struct rdev_sysfs_entry rdev_ppl_size =
> __ATTR(ppl_size, S_IRUGO|S_IWUSR, ppl_size_show, ppl_size_store);
>
> +static ssize_t
> +fail_fast_show(struct md_rdev *rdev, char *page)
> +{
> + return sprintf(page, "%d\n", test_bit(FailFast, &rdev->flags));
> +}
> +
> +static ssize_t
> +fail_fast_store(struct md_rdev *rdev, const char *buf, size_t len)
> +{
> + int ret;
> + bool bit;
> +
> + ret = kstrtobool(buf, &bit);
> + if (ret)
> + return ret;
> +
> + if (test_bit(FailFast, &rdev->flags) && !bit) {
> + clear_bit(FailFast, &rdev->flags);
> + md_update_sb(rdev->mddev, 1);
> + } else if (!test_bit(FailFast, &rdev->flags) && bit) {
> + set_bit(FailFast, &rdev->flags);
> + md_update_sb(rdev->mddev, 1);
> + }
> + return len;
> +}
> +
> +static struct rdev_sysfs_entry rdev_fail_fast =
> +__ATTR(fail_fast, 0644, fail_fast_show, fail_fast_store);
> +
> static struct attribute *rdev_default_attrs[] = {
> &rdev_state.attr,
> &rdev_errors.attr,
> @@ -3595,6 +3624,7 @@ static struct attribute *rdev_default_attrs[] = {
> &rdev_unack_bad_blocks.attr,
> &rdev_ppl_sector.attr,
> &rdev_ppl_size.attr,
> + &rdev_fail_fast.attr,
> NULL,
> };
> static ssize_t
> --
> 2.31.1
>
next prev parent reply other threads:[~2021-09-15 15:09 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-09-13 3:20 [PATCH] md: allow to set the fail_fast on RAID1/RAID10 Li Feng
2021-09-15 15:08 ` Li Feng [this message]
2021-09-27 13:24 ` Li Feng
2021-10-07 7:00 ` Li Feng
2021-10-07 14:58 ` Song Liu
2021-10-08 3:23 ` Li Feng
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHckoCyDULok_QLLh5Nmbx4qLCxKL43TgtFgCSAwuaPpRy1BFw@mail.gmail.com \
--to=fengli@smartx.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-raid@vger.kernel.org \
--cc=song@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).