From: meir elisha <meir6264@gmail.com>
To: Dan Carpenter <dan.carpenter@linaro.org>
Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
Hans de Goede <hdegoede@redhat.com>,
Ruan Jinjie <ruanjinjie@huawei.com>,
Yang Yingliang <yangyingliang@huawei.com>,
linux-staging@lists.linux.dev, linux-kernel@vger.kernel.org
Subject: Re: [PATCH v3] Staging: rtl8723bs: Remove spaces before tabs in rtw_set_auth
Date: Mon, 26 Feb 2024 14:05:19 +0200 [thread overview]
Message-ID: <CAHdEp89HhwiBuQEqTP8nTTy0VPrLr5PKWi8mKLx6wFzeTb9eXw@mail.gmail.com> (raw)
In-Reply-To: <96ab1a91-7682-4aed-a522-ceaed0dbf56c@moroto.mountain>
Hi Dan
Thanks for the response.
Not sure I got the problem here.
In V2 I removed spaces and deleted dead code. In V3 I just removed
spaces after tabs (reverting the dead code changes).
I'll want to create a seperate patch for the dead code deletion later on.
What am I missing here?
בתאריך יום ב׳, 26 בפבר׳ 2024 ב-12:23 מאת Dan Carpenter
<dan.carpenter@linaro.org>:
>
> On Mon, Feb 26, 2024 at 09:52:25AM +0200, Meir Elisha wrote:
> > Remove spaces before tabs to improve coding style.
> >
> > Signed-off-by: Meir Elisha <meir6264@gmail.com>
> > ---
> > Changes in v3: subject and description changed, revert dead code changes
> > Changes in v2: remove dead code
> >
>
> Sorry that I was not clear. This needs to be split into two patches:
> [patch 1] delete dead code
> [patch 2] remove spaces before tabs
>
> regards,
> dan carpenter
>
next prev parent reply other threads:[~2024-02-26 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-26 7:52 [PATCH v3] Staging: rtl8723bs: Remove spaces before tabs in rtw_set_auth Meir Elisha
2024-02-26 10:23 ` Dan Carpenter
2024-02-26 12:05 ` meir elisha [this message]
2024-02-26 13:28 ` Dan Carpenter
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAHdEp89HhwiBuQEqTP8nTTy0VPrLr5PKWi8mKLx6wFzeTb9eXw@mail.gmail.com \
--to=meir6264@gmail.com \
--cc=dan.carpenter@linaro.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-staging@lists.linux.dev \
--cc=ruanjinjie@huawei.com \
--cc=yangyingliang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).