From: "devendra.aaru" <devendra.aaru@gmail.com>
To: Fengguang Wu <fengguang.wu@intel.com>
Cc: Anton Altaparmakov <anton@tuxera.com>,
kernel-janitors@vger.kernel.org,
linux-ntfs-dev@lists.sourceforge.net,
linux-kernel@vger.kernel.org
Subject: Re: fs/ntfs/super.c:2717:1-14: alloc with no test
Date: Sun, 26 Aug 2012 14:42:12 +0530 [thread overview]
Message-ID: <CAHdPZaNs99QLOD=-QeUvFj5soSJMZCPU24V=5QXuVWx0r1jC5g@mail.gmail.com> (raw)
In-Reply-To: <20120826090447.GA11098@localhost>
On Sun, Aug 26, 2012 at 2:34 PM, Fengguang Wu <fengguang.wu@intel.com> wrote:
>
> Hi Anton,
>
> FYI, coccinelle warns about
>
> fs/ntfs/super.c:2717:1-14: alloc with no test, possible model on line 2718
>
> vim +2717 fs/ntfs/super.c
> 2714 sb->s_flags |= MS_RDONLY;
> 2715 #endif /* ! NTFS_RW */
> 2716 /* Allocate a new ntfs_volume and place it in sb->s_fs_info. */
>> 2717 sb->s_fs_info = kmalloc(sizeof(ntfs_volume), GFP_NOFS);
That's i think a false alarm.
> 2718 vol = NTFS_SB(sb);
The NTFS_SB(buf) {
buf->s_fs_info;
}
so we are validating the allocated pointer s_fs_info.
correct me if i am wrong.
Thanks,
> 2719 if (!vol) {
> 2720 if (!silent)
>
> ---
> 0-DAY kernel build testing backend Open Source Technology Centre
> Fengguang Wu <wfg@linux.intel.com> Intel Corporation
> --
> To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at http://vger.kernel.org/majordomo-info.html
> Please read the FAQ at http://www.tux.org/lkml/
next prev parent reply other threads:[~2012-08-26 9:12 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2012-08-26 9:04 fs/ntfs/super.c:2717:1-14: alloc with no test Fengguang Wu
2012-08-26 9:12 ` devendra.aaru [this message]
2012-08-26 9:31 ` Fengguang Wu
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHdPZaNs99QLOD=-QeUvFj5soSJMZCPU24V=5QXuVWx0r1jC5g@mail.gmail.com' \
--to=devendra.aaru@gmail.com \
--cc=anton@tuxera.com \
--cc=fengguang.wu@intel.com \
--cc=kernel-janitors@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-ntfs-dev@lists.sourceforge.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).