* [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
@ 2012-01-30 12:46 Devendra.Naga
2012-01-30 23:35 ` Larry Finger
0 siblings, 1 reply; 4+ messages in thread
From: Devendra.Naga @ 2012-01-30 12:46 UTC (permalink / raw)
To: Larry.Finger, chaoming_li, linville, linux-wireless, netdev,
linux-kernel
Cc: Devendra.Naga
From: "Devendra.Naga" <devendra.aaru@gmail.com>
the return value from _rtl_pci_switch_clk_req is not used by any of its callers.
Signed-off-by: Devendra.Naga <devendra.aaru@gmail.com>
---
drivers/net/wireless/rtlwifi/pci.c | 3 +--
1 files changed, 1 insertions(+), 2 deletions(-)
diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
index 4326fd1..35f4a0d 100644
--- a/drivers/net/wireless/rtlwifi/pci.c
+++ b/drivers/net/wireless/rtlwifi/pci.c
@@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
}
/*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
-static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
+static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
{
struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
@@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
udelay(100);
- return true;
}
/*Disable RTL8192SE ASPM & Disable Pci Bridge ASPM*/
--
1.7.5.4
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
2012-01-30 12:46 [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req Devendra.Naga
@ 2012-01-30 23:35 ` Larry Finger
2012-01-30 23:45 ` Joe Perches
0 siblings, 1 reply; 4+ messages in thread
From: Larry Finger @ 2012-01-30 23:35 UTC (permalink / raw)
To: Devendra.Naga; +Cc: chaoming_li, linville, linux-wireless, netdev, linux-kernel
On 01/30/2012 06:46 AM, Devendra.Naga wrote:
> From: "Devendra.Naga"<devendra.aaru@gmail.com>
>
> the return value from _rtl_pci_switch_clk_req is not used by any of its callers.
>
> Signed-off-by: Devendra.Naga<devendra.aaru@gmail.com>
> ---
> drivers/net/wireless/rtlwifi/pci.c | 3 +--
> 1 files changed, 1 insertions(+), 2 deletions(-)
The patch is OK, but the patch subject is bad. You should have "[PATCH]
rtlwifi:...". Your patch is for rtlwifi, not wireless.
Larry
>
> diff --git a/drivers/net/wireless/rtlwifi/pci.c b/drivers/net/wireless/rtlwifi/pci.c
> index 4326fd1..35f4a0d 100644
> --- a/drivers/net/wireless/rtlwifi/pci.c
> +++ b/drivers/net/wireless/rtlwifi/pci.c
> @@ -198,7 +198,7 @@ static bool _rtl_pci_platform_switch_device_pci_aspm(
> }
>
> /*When we set 0x01 to enable clk request. Set 0x0 to disable clk req.*/
> -static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> +static void _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> {
> struct rtl_pci *rtlpci = rtl_pcidev(rtl_pcipriv(hw));
> struct rtl_hal *rtlhal = rtl_hal(rtl_priv(hw));
> @@ -208,7 +208,6 @@ static bool _rtl_pci_switch_clk_req(struct ieee80211_hw *hw, u8 value)
> if (rtlhal->hw_type == HARDWARE_TYPE_RTL8192SE)
> udelay(100);
>
> - return true;
> }
>
> /*Disable RTL8192SE ASPM& Disable Pci Bridge ASPM*/
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
2012-01-30 23:35 ` Larry Finger
@ 2012-01-30 23:45 ` Joe Perches
2012-01-31 6:22 ` devendra.aaru
0 siblings, 1 reply; 4+ messages in thread
From: Joe Perches @ 2012-01-30 23:45 UTC (permalink / raw)
To: Larry Finger
Cc: Devendra.Naga, chaoming_li, linville, linux-wireless, netdev,
linux-kernel
On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote:
> The patch is OK, but the patch subject is bad. You should have "[PATCH]
> rtlwifi:...". Your patch is for rtlwifi, not wireless.
Hi Devendra.
A reasonable rule of thumb is use the deepest directory
path basename you can to prefix the patch.
Something like:
[PATCH] $(basename $(dirname $file)): terse description
If you are patching drivers/net/ethernet/realtek/apt.c
this becomes:
[PATCH] realtek: terse description
There are some exceptions though. One of them
is if the patch is in staging, prefix with
[PATCH] staging: $(basename $(dirname $file)): description
cheers, Joe
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req
2012-01-30 23:45 ` Joe Perches
@ 2012-01-31 6:22 ` devendra.aaru
0 siblings, 0 replies; 4+ messages in thread
From: devendra.aaru @ 2012-01-31 6:22 UTC (permalink / raw)
To: Joe Perches
Cc: Larry Finger, chaoming_li, linville, linux-wireless, netdev,
linux-kernel
On Mon, Jan 30, 2012 at 6:45 PM, Joe Perches <joe@perches.com> wrote:
> On Mon, 2012-01-30 at 17:35 -0600, Larry Finger wrote:
>> The patch is OK, but the patch subject is bad. You should have "[PATCH]
>> rtlwifi:...". Your patch is for rtlwifi, not wireless.
>
Will post a new patch, Thanks !!
> Hi Devendra.
>
> A reasonable rule of thumb is use the deepest directory
> path basename you can to prefix the patch.
> Something like:
>
> [PATCH] $(basename $(dirname $file)): terse description
>
> If you are patching drivers/net/ethernet/realtek/apt.c
> this becomes:
>
> [PATCH] realtek: terse description
>
> There are some exceptions though. One of them
> is if the patch is in staging, prefix with
> [PATCH] staging: $(basename $(dirname $file)): description
>
> cheers, Joe
>
Thanks a lot Joe, will follow your suggestions :).
Devendra.
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2012-01-31 6:22 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2012-01-30 12:46 [PATCH 1/1] wireless: remove return in _rtl_pci_switch_clk_req Devendra.Naga
2012-01-30 23:35 ` Larry Finger
2012-01-30 23:45 ` Joe Perches
2012-01-31 6:22 ` devendra.aaru
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).