From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id A8A2BC38142 for ; Wed, 1 Feb 2023 09:00:14 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231509AbjBAJAL (ORCPT ); Wed, 1 Feb 2023 04:00:11 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:55442 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231226AbjBAI74 (ORCPT ); Wed, 1 Feb 2023 03:59:56 -0500 Received: from mail-yw1-x112f.google.com (mail-yw1-x112f.google.com [IPv6:2607:f8b0:4864:20::112f]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id BDFA646712 for ; Wed, 1 Feb 2023 00:59:55 -0800 (PST) Received: by mail-yw1-x112f.google.com with SMTP id 00721157ae682-4b718cab0e4so236821317b3.9 for ; Wed, 01 Feb 2023 00:59:55 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=sifive.com; s=google; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:from:to:cc:subject:date :message-id:reply-to; bh=ZC1Teq7XfaidJwL0w/SdzFX7XLaiTcmzfle7ylS8rkM=; b=jqBJ/Wy2ccQVFxo6tA6/JjU7nOnDtBg6NU7moAmy2SQWIwT5grBWro9bQ7KJesWUVk EtTKNDu0IbecZ/dYauIEPpv/WGVkVLiFqPrdMBIvYhYHDxxOoWXyaOKHPQFwbP+UIuNS CD2Hq/3Wukx+tOyTxQbler6OZHdDSY+2xG7Cbl8kt8IYlrLqCo2/MCrJYJAY74G219mn XLiMmp0TnTANvC1pGv6h0ZQCTMLZaXHeThsSdCGZGQNbXqnaV6+y4moko61zH8Nx22E2 JobhaKWj2Xg9k+DCtWZQrfXPLzD7vWBgMyefqzM7wxRelBGgBwLXMe0flBbdYnI5BCzC pDyQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:cc:to:subject:message-id:date:from :in-reply-to:references:mime-version:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=ZC1Teq7XfaidJwL0w/SdzFX7XLaiTcmzfle7ylS8rkM=; b=PvZqG6uOVZRVENj0ICvFrztU++syiypKf2C6KajlA/jy3H6kBEDC9j4zwBZzFP5UB5 1HyuI3Nufugs2WIZfLyUwL0u7lG4EOqhKfOMKioH7qk9uJbVdbHGlEdz9R43phk9swc6 DzLabRYdi3JG6aCCkYloUq4dxSZBZOf0i03xtHT8V0zERnmxpjhFzogKCLup7FmOt3XH F+9bJq4DOqLcclLWI9VyYxaugjfda7gblwd91TQqpq9wDp2uGVc5l9RUxpM79iBQh62S GjLMzMmxFy6sdnRs0CTfnVvH8fEr8YhhVkxp9iHhgF93u9661hevJm1EGD8Ov+O0TkEM TlRA== X-Gm-Message-State: AO0yUKVRo06Qb1WGOBQrH07ELpaZ2szdz9d/SAYKf44ws27Rh8t+bbSz B8QRhXp9zjYU4XtwIiaqs8xE1Dw6vs8h5CYxvjB3Kg== X-Google-Smtp-Source: AK7set+z1Sq/bReNxuGLJvSaXuf+C9wc9S9RP/PcrOXVL2vHdpyUdGOLcIV6A6Swpl/aJQNAD3xQDjok58MVZ9iLBHQ= X-Received: by 2002:a81:8ac5:0:b0:506:8253:3444 with SMTP id a188-20020a818ac5000000b0050682533444mr173887ywg.436.1675241994924; Wed, 01 Feb 2023 00:59:54 -0800 (PST) MIME-Version: 1.0 References: <20230130093229.27489-1-nylon.chen@sifive.com> <20230130093229.27489-2-nylon.chen@sifive.com> In-Reply-To: From: Nylon Chen Date: Wed, 1 Feb 2023 16:59:40 +0800 Message-ID: Subject: Re: [PATCH v2 1/2] riscv: dts: sifive: unleashed/unmatched: Remove PWM controlled LED's active-low properties To: Conor Dooley Cc: aou@eecs.berkeley.edu, emil.renner.berthing@canonical.com, geert+renesas@glider.be, heiko@sntech.de, krzysztof.kozlowski+dt@linaro.org, palmer@dabbelt.com, paul.walmsley@sifive.com, robh+dt@kernel.org, thierry.reding@gmail.com, u.kleine-koenig@pengutronix.de, devicetree@vger.kernel.org, linux-pwm@vger.kernel.org, linux-riscv@lists.infradead.org, linux-kernel@vger.kernel.org, nylon7717@gmail.com, zong.li@sifive.com, greentime.hu@sifive.com, vincent.chen@sifive.com Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hi Conor, Thanks for your reply. Conor Dooley =E6=96=BC 2023=E5=B9=B42=E6=9C=881=E6=97=A5= =E9=80=B1=E4=B8=89 =E4=B8=8A=E5=8D=882:32=E5=AF=AB=E9=81=93=EF=BC=9A > > Hey Nylon, > > On Mon, Jan 30, 2023 at 05:32:28PM +0800, Nylon Chen wrote: > > This removes the active-low properties of the PWM-controlled LEDs in > > the HiFive Unmatched device tree. > > > > The reference is hifive-unleashed-a00.pdf[0] and hifive-unmatched-schem= atics-v3.pdf[1]. > > > > [0]: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf84= 53f8698_hifive-unleashed-a00-schematics-1.pdf > > [1]: https://sifive.cdn.prismic.io/sifive/6a06d6c0-6e66-49b5-8e9e-e68ce= 76f4192_hifive-unmatched-schematics-v3.pdf > > Ideally these would be: > Link: https://sifive.cdn.prismic.io/sifive/c52a8e32-05ce-4aaf-95c8-7bf845= 3f8698_hifive-unleashed-a00-schematics-1.pdf [0] > so that they integrate nice with the git trailers mechanism. > If you resend, please update them to regular link tags. > I will fix this issue. > I checked out the circuits last time around and agreed that they should > not be active-low. > Reviewed-by: Conor Dooley > > I expect that both patches will go through the PWM tree together, so: > Acked-by: Conor Dooley > > Thanks, > Conor. > Thanks a lot. > > > > Signed-off-by: Nylon Chen > > --- > > arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts | 4 ---- > > arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts | 4 ---- > > 2 files changed, 8 deletions(-) > > > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts b/arch= /riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > index 900a50526d77..7a9f336a391c 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unleashed-a00.dts > > @@ -50,7 +50,6 @@ led-controller { > > > > led-d1 { > > pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color =3D ; > > max-brightness =3D <255>; > > label =3D "d1"; > > @@ -58,7 +57,6 @@ led-d1 { > > > > led-d2 { > > pwms =3D <&pwm0 1 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color =3D ; > > max-brightness =3D <255>; > > label =3D "d2"; > > @@ -66,7 +64,6 @@ led-d2 { > > > > led-d3 { > > pwms =3D <&pwm0 2 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color =3D ; > > max-brightness =3D <255>; > > label =3D "d3"; > > @@ -74,7 +71,6 @@ led-d3 { > > > > led-d4 { > > pwms =3D <&pwm0 3 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color =3D ; > > max-brightness =3D <255>; > > label =3D "d4"; > > diff --git a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts b/arch= /riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > index 07387f9c135c..11f08a545ee6 100644 > > --- a/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > +++ b/arch/riscv/boot/dts/sifive/hifive-unmatched-a00.dts > > @@ -52,7 +52,6 @@ led-controller-1 { > > > > led-d12 { > > pwms =3D <&pwm0 0 7812500 PWM_POLARITY_INVERTED>; > > - active-low; > > color =3D ; > > max-brightness =3D <255>; > > label =3D "d12"; > > @@ -69,19 +68,16 @@ multi-led { > > > > led-red { > > pwms =3D <&pwm0 2 7812500 PWM_POLARITY_IN= VERTED>; > > - active-low; > > color =3D ; > > }; > > > > led-green { > > pwms =3D <&pwm0 1 7812500 PWM_POLARITY_IN= VERTED>; > > - active-low; > > color =3D ; > > }; > > > > led-blue { > > pwms =3D <&pwm0 3 7812500 PWM_POLARITY_IN= VERTED>; > > - active-low; > > color =3D ; > > }; > > }; > > -- > > 2.36.1 > >