From: Linus Torvalds <torvalds@linux-foundation.org>
To: Joe Perches <joe@perches.com>
Cc: Miguel Ojeda <miguel.ojeda.sandonis@gmail.com>,
Kees Cook <keescook@chromium.org>,
Peter Zijlstra <peterz@infradead.org>,
Borislav Petkov <bp@alien8.de>, "H . Peter Anvin" <hpa@zytor.com>,
Thomas Gleixner <tglx@linutronix.de>,
Ingo Molnar <mingo@redhat.com>, Pavel Machek <pavel@ucw.cz>,
"Gustavo A . R . Silva" <gustavo@embeddedor.com>,
Arnaldo Carvalho de Melo <acme@kernel.org>,
Kan Liang <kan.liang@linux.intel.com>,
Namhyung Kim <namhyung@kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Alexander Shishkin <alexander.shishkin@linux.intel.com>,
Shawn Landden <shawn@git.icu>,
"the arch/x86 maintainers" <x86@kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Neil Horman <nhorman@tuxdriver.com>,
David Miller <davem@davemloft.net>
Subject: Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use
Date: Sun, 4 Aug 2019 11:09:19 -0700 [thread overview]
Message-ID: <CAHk-=wg1PAJR6ChVXE7O_H2wEG=1mWxi2uc0fH5bthOC_81uTA@mail.gmail.com> (raw)
In-Reply-To: <c0669a7130645a20e99915385b7e712360c31ed9.camel@perches.com>
On Sun, Aug 4, 2019 at 11:01 AM Joe Perches <joe@perches.com> wrote:
>
> Linus? Do you have an opinion about this RFC/patch?
So my only real concern is that the comment approach has always been
the really traditional one, going back all the way to 'lint' days.
And you obviously cannot use a #define to create a comment, so this
whole keyword model will never be able to do that.
At the same time, all the modern tools we care about do seem to be
happy with it, either through the gcc attribute, the clang
[[clang:fallthrough]] or the (eventual) standard C [[fallthrough]]
model.
So I'm ok with just saying "the comment model may be traditional, but
it's not very good".
I didn't look at all the patches, but the one I *did* see had a few issues:
- it didn't seem to handle clang
- we'd need to make -Wimplicit-fallthrough be dependent on the
compiler actually supporting the attribute, not just on supporting the
flag.
without those changes, nobody can actually start doing any
conversions. But I assume such patches exist somewhere, and I've just
missed them.
Linus
next prev parent reply other threads:[~2019-08-04 18:09 UTC|newest]
Thread overview: 52+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-07-31 5:04 [PATCH] net: sctp: Rename fallthrough label to unhandled Joe Perches
2019-07-31 5:35 ` [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use Joe Perches
2019-07-31 9:02 ` Peter Zijlstra
2019-07-31 9:34 ` Joe Perches
2019-07-31 17:14 ` Pavel Machek
2019-07-31 17:51 ` Joe Perches
2019-07-31 18:24 ` hpa
2019-07-31 18:48 ` Peter Zijlstra
2019-07-31 20:02 ` Kees Cook
2019-07-31 20:59 ` Miguel Ojeda
2019-07-31 22:07 ` Joe Perches
2019-08-01 0:00 ` Miguel Ojeda
2019-08-01 12:25 ` Peter Zijlstra
2019-08-15 18:15 ` Kees Cook
2019-08-15 22:31 ` Kees Cook
2019-09-16 22:19 ` treewide replacement of fallthrough comments with "fallthrough" macro (was Re: [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use) Kees Cook
2019-09-17 22:26 ` Joe Perches
2019-09-17 23:38 ` Kees Cook
2019-07-31 21:01 ` [RFC PATCH] compiler_attributes.h: Add 'fallthrough' pseudo keyword for switch/case use hpa
2019-07-31 23:55 ` Miguel Ojeda
2019-08-01 6:10 ` hpa
2019-08-01 7:52 ` Joe Perches
2019-08-01 12:24 ` Peter Zijlstra
2019-08-01 20:09 ` hpa
2019-08-01 20:26 ` Miguel Ojeda
2019-08-01 20:47 ` Joe Perches
2019-08-02 11:00 ` Neil Horman
2019-08-02 12:34 ` Pavel Machek
2019-08-02 16:09 ` Kees Cook
2019-08-02 16:16 ` Joe Perches
2019-08-04 18:01 ` Joe Perches
2019-08-04 18:09 ` Linus Torvalds [this message]
2019-08-04 19:38 ` Miguel Ojeda
2019-08-05 0:39 ` Joe Perches
2019-08-05 1:18 ` Nathan Chancellor
2019-08-05 2:01 ` Joe Perches
2019-07-31 11:19 ` [PATCH] net: sctp: Rename fallthrough label to unhandled Neil Horman
2019-07-31 11:32 ` Joe Perches
2019-07-31 12:16 ` Neil Horman
2019-07-31 16:35 ` Joe Perches
2019-07-31 20:58 ` Neil Horman
2019-07-31 22:23 ` Joe Perches
2019-08-01 10:50 ` Neil Horman
2019-08-01 17:42 ` Joe Perches
2019-08-01 20:48 ` Neil Horman
2019-08-05 11:49 ` David Laight
2019-08-02 17:47 ` Joe Perches
2019-08-02 23:19 ` David Miller
2019-08-02 23:26 ` Joe Perches
2019-08-03 18:01 ` Joe Perches
2019-08-04 19:26 ` Neil Horman
2019-08-02 17:50 ` Neil Horman
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg1PAJR6ChVXE7O_H2wEG=1mWxi2uc0fH5bthOC_81uTA@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=acme@kernel.org \
--cc=alexander.shishkin@linux.intel.com \
--cc=bp@alien8.de \
--cc=davem@davemloft.net \
--cc=gustavo@embeddedor.com \
--cc=hpa@zytor.com \
--cc=joe@perches.com \
--cc=jolsa@redhat.com \
--cc=kan.liang@linux.intel.com \
--cc=keescook@chromium.org \
--cc=linux-kernel@vger.kernel.org \
--cc=miguel.ojeda.sandonis@gmail.com \
--cc=mingo@redhat.com \
--cc=namhyung@kernel.org \
--cc=nhorman@tuxdriver.com \
--cc=pavel@ucw.cz \
--cc=peterz@infradead.org \
--cc=shawn@git.icu \
--cc=tglx@linutronix.de \
--cc=x86@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).