From: Linus Torvalds <torvalds@linux-foundation.org>
To: Brian Norris <briannorris@chromium.org>
Cc: Marcel Holtmann <marcel@holtmann.org>,
Johan Hedberg <johan.hedberg@gmail.com>,
linux-bluetooth <linux-bluetooth@vger.kernel.org>,
Linux List Kernel Mailing <linux-kernel@vger.kernel.org>,
Matthias Kaehlcke <mka@chromium.org>,
Rajat Jain <rajatja@google.com>, Heiko Stuebner <heiko@sntech.de>
Subject: Re: [PULL -- 5.1 REGRESSION] Bluetooth: btusb: request wake pin with NOAUTOEN
Date: Tue, 9 Apr 2019 16:20:33 -1000 [thread overview]
Message-ID: <CAHk-=wg6_i9WcqiGu4kg97yAg1du26RpXdxd=uEjo4yXjotdiQ@mail.gmail.com> (raw)
In-Reply-To: <20190409184917.65062-1-briannorris@chromium.org>
On Tue, Apr 9, 2019 at 8:49 AM Brian Norris <briannorris@chromium.org> wrote:
>
> Badly-designed systems might have (for example) active-high wake pins
> that default to high (e.g., because of external pull ups) until they
> have an active firmware which starts driving it low. This can cause an
> interrupt storm in the time between request_irq() and disable_irq().
Why is the fix not to move the request_irq() down to below the proper
initialization sequence?
That's what drivers *should* do: initialize their hardware first,
request interrupts only after that. Initializing the interrupt handler
before the hw is actually up seems wrong..
Linus
next prev parent reply other threads:[~2019-04-10 2:20 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-04-09 18:49 [PULL -- 5.1 REGRESSION] Bluetooth: btusb: request wake pin with NOAUTOEN Brian Norris
2019-04-10 2:20 ` Linus Torvalds [this message]
2019-04-10 3:26 ` Brian Norris
2019-04-10 3:43 ` Linus Torvalds
2019-04-10 17:44 ` Brian Norris
2019-04-10 19:50 ` Linus Torvalds
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='CAHk-=wg6_i9WcqiGu4kg97yAg1du26RpXdxd=uEjo4yXjotdiQ@mail.gmail.com' \
--to=torvalds@linux-foundation.org \
--cc=briannorris@chromium.org \
--cc=heiko@sntech.de \
--cc=johan.hedberg@gmail.com \
--cc=linux-bluetooth@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=marcel@holtmann.org \
--cc=mka@chromium.org \
--cc=rajatja@google.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).