linux-kernel.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: Linus Torvalds <torvalds@linux-foundation.org>
To: Andrei Vagin <avagin@gmail.com>
Cc: kernel test robot <oliver.sang@intel.com>,
	Dmitry Safonov <0x7f454c46@gmail.com>,
	Alexander Viro <viro@zeniv.linux.org.uk>,
	Andrew Morton <akpm@linux-foundation.org>,
	LKML <linux-kernel@vger.kernel.org>,
	lkp@lists.01.org, kernel test robot <lkp@intel.com>,
	Mike Rapoport <rppt@linux.ibm.com>,
	Pavel Emelyanov <ovzxemul@gmail.com>
Subject: Re: [fs/pipe] 5a519c8fe4: WARNING:at_mm/page_alloc.c:#__alloc_pages
Date: Sat, 23 Apr 2022 14:02:36 -0700	[thread overview]
Message-ID: <CAHk-=wgBH+11vHDEKaPmDeVQ557mSruEXmEwBThACz3Xx-pvKA@mail.gmail.com> (raw)
In-Reply-To: <CANaxB-whArowHWaWsFMJf6B4idPabAmJNawzk9FdokNQ-1xrSA@mail.gmail.com>

On Sat, Apr 23, 2022 at 1:23 PM Andrei Vagin <avagin@gmail.com> wrote:
>
> vmsplice & splice  is the best. /proc/pid/mem is 30% slower.
> process_vm_readv is 20% slower.

Hmm.

I wonder how much low-hanging fruit there would be to optimize there.

Because process_vm_readv() in particular is pretty much _designed_ for
what you do, so it would be much nicer to basically work on that being
optimal, rather than doing vmsplice hackery.

(And yes, vmsplice is designed for efficient copies from the VM too,
of course, but that "limited to kernel pipe buffer" part is arguably
even more fundamental to it)

            Linus

      reply	other threads:[~2022-04-23 21:03 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-04-20  7:37 [fs/pipe] 5a519c8fe4: WARNING:at_mm/page_alloc.c:#__alloc_pages kernel test robot
2022-04-20 19:07 ` Linus Torvalds
2022-04-21 15:35   ` Andrei Vagin
2022-04-21 16:30     ` Linus Torvalds
2022-04-21 19:28       ` Linus Torvalds
2022-04-22  5:23         ` Andrei Vagin
2022-04-22 17:23           ` Linus Torvalds
2022-04-23 20:23             ` Andrei Vagin
2022-04-23 21:02               ` Linus Torvalds [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to='CAHk-=wgBH+11vHDEKaPmDeVQ557mSruEXmEwBThACz3Xx-pvKA@mail.gmail.com' \
    --to=torvalds@linux-foundation.org \
    --cc=0x7f454c46@gmail.com \
    --cc=akpm@linux-foundation.org \
    --cc=avagin@gmail.com \
    --cc=linux-kernel@vger.kernel.org \
    --cc=lkp@intel.com \
    --cc=lkp@lists.01.org \
    --cc=oliver.sang@intel.com \
    --cc=ovzxemul@gmail.com \
    --cc=rppt@linux.ibm.com \
    --cc=viro@zeniv.linux.org.uk \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).