From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-5.8 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 61D8AC4338F for ; Thu, 19 Aug 2021 22:39:03 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 40B6A6109E for ; Thu, 19 Aug 2021 22:39:03 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S236690AbhHSWji (ORCPT ); Thu, 19 Aug 2021 18:39:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:44628 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S236282AbhHSWjf (ORCPT ); Thu, 19 Aug 2021 18:39:35 -0400 Received: from mail-ed1-x534.google.com (mail-ed1-x534.google.com [IPv6:2a00:1450:4864:20::534]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 939AEC061575 for ; Thu, 19 Aug 2021 15:38:58 -0700 (PDT) Received: by mail-ed1-x534.google.com with SMTP id cn28so11092385edb.6 for ; Thu, 19 Aug 2021 15:38:58 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linux-foundation.org; s=google; h=mime-version:references:in-reply-to:from:date:message-id:subject:to :cc; bh=d7xFbb+3EvqQGpxyml4JHHWLdIJirfcFBHOQItDEp7E=; b=WJcRZ5ECnMTu5Q30pfx/0sVzarr1xcPILRNADM84n9O0Z5vxSCIEUyI67jzVtA2erg 2u4KECFy2YAYP9QfFCE1KRjE+0ldOJD2qybITXQz3MnjYBy7U8BGR/S3O2zpZU3ODREn vt5dXowvmoFxXKfn8qNFotVfe953q+8cvuBsw= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:mime-version:references:in-reply-to:from:date :message-id:subject:to:cc; bh=d7xFbb+3EvqQGpxyml4JHHWLdIJirfcFBHOQItDEp7E=; b=rkXdBXuCMXTfywf99tZwFUuBCe2Vnj6TlL1XpeTJOdONmQpdbkItDrsIOFKqt5pfbI durUijG/zpv6XaZ4o4KQcbU6ymrZDYISi3gzSpWJn0jqZQqgOGQ0+FabG1SBrPThuy1U E/RkWMum1RIZh/53WIo/a7JLSvYgHDHkrooAlZFfoi+Qqm4f8U6ldO9BHMT5/emGDjOt JbHadp9P2xnBeUmahChIR0iKZr0k5JncKCFaGvfC0bhA0r/N6ohOfM0uBR0iRshz9vEH vfdf546makXLrjRuKYDroaxmNKyTdI9nYwS5m4+gaIqo9KLWERPoPMYXhkRC6ncqSXDD ufAA== X-Gm-Message-State: AOAM530ipM2Nkd1kfvzlBQHRMIWmSd5oeL9PUA/KhnWAhYMm6q0w3IvM vlAG/u3vko362tDDN/rzS1isMPUGO0Azcq4foPI= X-Google-Smtp-Source: ABdhPJzNGF8r5pfFil8sw6L3h1GtJzmrPVgCjyZJKSe5b5hHeCwL9FBUVsh3JRZQqycoqjIw76N3bw== X-Received: by 2002:aa7:d896:: with SMTP id u22mr18673274edq.290.1629412737138; Thu, 19 Aug 2021 15:38:57 -0700 (PDT) Received: from mail-wr1-f41.google.com (mail-wr1-f41.google.com. [209.85.221.41]) by smtp.gmail.com with ESMTPSA id c21sm2469620edv.27.2021.08.19.15.38.56 for (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 19 Aug 2021 15:38:57 -0700 (PDT) Received: by mail-wr1-f41.google.com with SMTP id q10so11294843wro.2 for ; Thu, 19 Aug 2021 15:38:56 -0700 (PDT) X-Received: by 2002:a2e:557:: with SMTP id 84mr13704523ljf.507.1629412367774; Thu, 19 Aug 2021 15:32:47 -0700 (PDT) MIME-Version: 1.0 References: <20210812084348.6521-1-david@redhat.com> <87o8a2d0wf.fsf@disp2133> <60db2e61-6b00-44fa-b718-e4361fcc238c@www.fastmail.com> <87lf56bllc.fsf@disp2133> <87eeay8pqx.fsf@disp2133> <5b0d7c1e73ca43ef9ce6665fec6c4d7e@AcuMS.aculab.com> <87h7ft2j68.fsf@disp2133> <87k0kkxbjn.fsf_-_@disp2133> <0c2af732e4e9f74c9d20b09fc4b6cbae40351085.camel@kernel.org> <639d90212662cf5cdf80c71bbfec95907c70114a.camel@kernel.org> In-Reply-To: <639d90212662cf5cdf80c71bbfec95907c70114a.camel@kernel.org> From: Linus Torvalds Date: Thu, 19 Aug 2021 15:32:31 -0700 X-Gmail-Original-Message-ID: Message-ID: Subject: Re: Removing Mandatory Locks To: Jeff Layton Cc: "Eric W. Biederman" , Matthew Wilcox , Andy Lutomirski , David Laight , David Hildenbrand , Linux Kernel Mailing List , Andrew Morton , Thomas Gleixner , Ingo Molnar , Borislav Petkov , "H. Peter Anvin" , Al Viro , Alexey Dobriyan , Steven Rostedt , "Peter Zijlstra (Intel)" , Arnaldo Carvalho de Melo , Mark Rutland , Alexander Shishkin , Jiri Olsa , Namhyung Kim , Petr Mladek , Sergey Senozhatsky , Andy Shevchenko , Rasmus Villemoes , Kees Cook , Greg Ungerer , Geert Uytterhoeven , Mike Rapoport , Vlastimil Babka , Vincenzo Frascino , Chinwen Chang , Michel Lespinasse , Catalin Marinas , Huang Ying , Jann Horn , Feng Tang , Kevin Brodsky , Michael Ellerman , Shawn Anastasio , Steven Price , Nicholas Piggin , Christian Brauner , Jens Axboe , Gabriel Krisman Bertazi , Peter Xu , Suren Baghdasaryan , Shakeel Butt , Marco Elver , Daniel Jordan , Nicolas Viennot , Thomas Cedeno , Collin Fijalkovich , Michal Hocko , Miklos Szeredi , Chengguang Xu , =?UTF-8?Q?Christian_K=C3=B6nig?= , "linux-unionfs@vger.kernel.org" , Linux API , "the arch/x86 maintainers" , "" , Linux-MM , Florian Weimer , Michael Kerrisk Content-Type: text/plain; charset="UTF-8" Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thu, Aug 19, 2021 at 2:43 PM Jeff Layton wrote: > > What sort of big, ugly warning did you have in mind? I originally thought WARN_ON_ONCE() just to get the distro automatic error handling involved, but it would probably be a big problem for the people who end up having panic-on-warn or something. So probably just a "make it a big box" thing that stands out, kind of what lockdep etc does with pr_warn("======...====\n"); around the messages.. I don't know if distros have some pattern we could use that would end up being something that gets reported to the user? Linus